Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1HCq-0003Z1-Ev for pgsql-committers@arkaria.postgresql.org; Wed, 15 Jun 2022 00:48:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1o1HCp-0006mx-8J for pgsql-committers@arkaria.postgresql.org; Wed, 15 Jun 2022 00:48:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1HCp-0006mo-1B for pgsql-committers@lists.postgresql.org; Wed, 15 Jun 2022 00:48:23 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1HCm-0002zL-Gc for pgsql-committers@lists.postgresql.org; Wed, 15 Jun 2022 00:48:22 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 77CF05C01BF; Tue, 14 Jun 2022 20:48:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 14 Jun 2022 20:48:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1655254098; x=1655340498; bh=Jt11qqe5tY We0hbbGnlf3WYYbjS9sOy+kStMh9Wk0XE=; b=ThhGZa69Qa01RWXam+sArSGpRd Umdr+R+hUieM/v9re8G6rrUQdWpWGoSWqAp6rxNnpH2+kOM4KI85wnc0k42RiOds LmycuqvlkqgfFf/gWJxe5d6poSO6XxJvivCMuXuaKRQUqSq1R3Dp1gmPovVcMcKD MmfGzhndbs31baeu9UYy4gOsd1oV+FEa2XLtyrcko6fXt2g7lBq3/bkCporVaQom VMniAluda35H4t3SkcbYLJrvPBvdcVXGhQtvBjqRaG4D60If1Pc7MdR/DMydGGM4 ARYst5dbb/oPqX2F/IMQydbVgLlrkhVWZYqAeCOs8Q6Th2I0uBEgolTGfAMw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1655254098; x=1655340498; bh=Jt11qqe5tYWe0hbbGnlf3WYYbjS9 sOy+kStMh9Wk0XE=; b=O6oVmscI6xybXW1i7z/fLFXRUF0FCcXsG9fZXMvi6/u5 vMCTttyRsN/ttLqMMM32tRHYMaVboTXwdKW889t9Bcm3OBDpF6KBY6lviGA51XgY Lug4E32u+cyKDcXzjNohjOzEMQqvTkCqypupw4X4e+TdIfnn9/QlSO31MRKGVv44 ezEU00vpAog0C3DlcUt8fx1TQe1ZCWLI2C4AC3ipWvhzxKuULAuBS7JtrDGKAWpg hHAJ5H4vKqej5IVHS2Wh3bEvE7oiWl5pbCwTtVlOJEEJV3g9XAE1SXpLiSqYLp95 RBQm3VYC1l3uJ8KLafDOUfbWWS6InrHVaqGS5bYFTw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedruddvtddgfeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucgfrhhlucfvnfffucdljedtmdenucfjughrpeffhf fvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfrrghq uhhivghruceomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvg hrnhepteelieefudffhffhtdetleeggeegfffhkeeuveetiefgudduvedutefggeeivdej necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitg hhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 14 Jun 2022 20:48:17 -0400 (EDT) Date: Wed, 15 Jun 2022 09:48:14 +0900 From: Michael Paquier To: Tom Lane Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Force run of pg_upgrade in the build directory in its TAP test Message-ID: References: <90595.1655227384@sss.pgh.pa.us> <191585.1655251919@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ftVOHFl4P+J1rirI" Content-Disposition: inline In-Reply-To: <191585.1655251919@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --ftVOHFl4P+J1rirI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 14, 2022 at 08:11:59PM -0400, Tom Lane wrote: > Sorry, I wasn't very clear: I'd tested pg_upgrade with a manual > invocation, like "./pg_upgrade -d ...". That used to be OK and > now it leaves junk around. I think it's worth keeping the > .gitignore entries (and I guess the "make clean" rule step too) > so that that approach still works without making a mess. No big deal to me to add that both the .gitignore entry and the cleanup rule if that's annoying for some. FWIW, I just have some scripts lying around to launch my upgrade commands in isolated paths, pretty much like the TAP tests. -- Michael --ftVOHFl4P+J1rirI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmKpLE4ACgkQnvQgOdby QH1yKw//ZR3aoGNBR1V9i+5AY796h+QMK7J1bbYbGE83R0zd0W5DjDRGOLNQ287i hN65tOA4m8lZs9/83+lEweML9SIL5X+2dvP6k9Monuo5SZBkLWq/rottyj7yQbQj pPYMPc64201bNNNwP/5YHY/A0pRCauThxSpsrkqFEosMUFPE/r/q9zy4z0c9H8LY ceL21I1kTpQUEOUCBhQe6j/fZor7iF745Xzn+ZuAPaSVySLVXHLY8SEBsR5Z/EV7 RMQG7HEO5vqF1jjg1DOl2bjolk01qMW0vNkaSoFkfe9SPpakQkVvVB+lxMcLiR0X 4U7f4FWJ50t7ohhFjELbG+1ghLn26+nZB4r1RbxCh95NUGIeRap04DbA2H2DQJrU XTx77p+PpJZg5QQe7ypbWPSsru8GSxZwAIqbHCBxvE9kSsXeOh8/ss6alSops5NS x7TONzquJAttll8CLvw6dMvkGneo+BF3WUffIQ9qcPwJREQJhpxkEvy6dIL6oPGp ZFkxpWJ296jbXh8UkuiU2nthYZn0HAYxmM2exuWgfh+oxirYNI8yQXvtUeqGOBkM D0z4UYG46MqJVovLWkYSTzWzcNDwohjARU6oNP/hTbbzHzZTsC0yU0b4QyKoGTRd CF50Wkf/h4XApZS5V1/BIAnF7oUvdRiE5MM4bb3UPH1rUSuC3ac= =mynY -----END PGP SIGNATURE----- --ftVOHFl4P+J1rirI--