Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8Wkg-0003US-5b for pgsql-committers@arkaria.postgresql.org; Tue, 05 Jul 2022 00:49:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1o8Wke-0004g7-Vr for pgsql-committers@arkaria.postgresql.org; Tue, 05 Jul 2022 00:49:16 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8Wke-0004ce-8Q for pgsql-committers@lists.postgresql.org; Tue, 05 Jul 2022 00:49:16 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8Wkb-0000gZ-Vd for pgsql-committers@lists.postgresql.org; Tue, 05 Jul 2022 00:49:15 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 619EB32005BC; Mon, 4 Jul 2022 20:49:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 04 Jul 2022 20:49:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1656982151; x=1657068551; bh=PatWhaU6xk uh66Zx1xAzcZAfzGdxidEWebRuSdu0P7w=; b=HK9u2vg9z42/J1XkBSkv22DpEL bginaV/zxShMQE2E/u2lMzTvpNCMAYZf7Ya12FUtGiPV65ZvCC3QGRbkAsxvkmrL D1AEu2ZOMXD/dsgVR8VNMlLjRmWBa9FpvloWkeuHx05m91sMAHEne8CyqH/Fr7Yd gpoGLF/E21K8n83E5i6abZXe6xqW8g2NMXq1wCmIKyRZUTOyTbb8ir64mbGtloE4 VrQsvWULd6Nf6TrmeXxa/yfvIsh3zSRWGQe4Ql98oBLcZsHXptdPNvy/QFkjWI4l JrCsyimRnWa+0XAaIR4ZzqnA28yt0Ib1LdklYOa+X0GNK3DNuXtyARo0DO+w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1656982151; x=1657068551; bh=PatWhaU6xkuh66Zx1xAzcZAfzGdx idEWebRuSdu0P7w=; b=hRQJ1HrgQ7a2zPVbFpj27xq342uw6UBMsXFtf5FsFAsd +I6c1oCZsM69E5d+ai94CosZOF6Gfk8erVKY493BbcTgEU+sxId+jrdFd0PIhCZz DKf+EjqjEtXAu74RfPXcRiuf5LNTapk/vvNtHbeEZ/K9pPFoWwNkZ2qIXn90ejJH 06HlIE6Elbkpz0tihVdhZAEGeu7+5tHaDvCzIHP7nsHscUUhDyRAi3gx5rIAl4dI 0p7TvUs65n1SxtaXfwRNuROUbDVuYfWnMzE1qu4j3HvhZzgbGnZ1i8p74IiCiyMB fCDOYEcxd4TNiCudewSE20Q5cmcIXvtb+RX4olKQgw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeitddgfeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdlfeehmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 4 Jul 2022 20:49:10 -0400 (EDT) Date: Tue, 5 Jul 2022 09:49:07 +0900 From: Michael Paquier To: Tom Lane Cc: Peter Eisentraut , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Change timeline field of IDENTIFY_SYSTEM to int8 Message-ID: References: <1467434.1656914113@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wnvgml3Vew3NnKi4" Content-Disposition: inline In-Reply-To: <1467434.1656914113@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --wnvgml3Vew3NnKi4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 04, 2022 at 01:55:13AM -0400, Tom Lane wrote: > Peter Eisentraut writes: > > Change timeline field of IDENTIFY_SYSTEM to int8 >=20 > Surely this patch is far from complete? Yeah.. > But what about whatever code is reading the output? And what if > that code isn't v16? I can't believe that we can make a wire > protocol change as summarily as this. Assuming that one reaches a timeline of 2 billion, this change would make the TLI consumption of the client safe to signedness. But why is it safe to do a protocol change when running IDENTIFY_SYSTEM? We've been very strict to maintain compatibility for any protocol change, hence why should the replication protocol be treated differently? -- Michael --wnvgml3Vew3NnKi4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmLDioMACgkQnvQgOdby QH1bqQ/7BV76ttDXJtpNWOiaSq0RirDx3fNjmssy71fS36yPI+VQ+7018209ReVQ we0xgNcKgWGdbYZnMGjF1K583vd+zknzTuH0EIPw7XlpqV3uR9/r4ILN5fkgPzsA yiI9FdAADa/EGw8boW2oJ0DQksj9kaXTOIc+9ZNyifmuOEsBecO4LfIWPZWFEhRY zEov7/FjxPjzuEhzPwmCutX7EhWslXFw3wdHKGcbPAiQGtdbP1ngSlk0uGKHqOLI LhuJ7I+xys4s7loAsvodjtZDHzsR0qWLLk8/6ZWq3sXpBQ62vAm4hB+4sTs+BwIV H4k52skvrzG5porGFIcxvFE9lUOLKdem3v6+pdTeiItuoAFK7J22RlNKtkTap8X5 oP1EhT/uPmy1oNGbygXFWqZrXwhuPd/wILI+YHufx3042PsF/p33CcS944pLMkxf CWha+ONlQBYhBuNWdoQPv8q2iHj5LHiLioh1dwewGtxiv+i9SIf+qwj4aKXVXUrI I9yYO0GGRO/PBt8CiRg7lKP79rQ/LGJuFVw+S5ghgaudMFYcNjLy/3wLxDKPZEQK LlVqnkqPMmsnvbA+K0upMPDTHjiIEy4D+utl7gTptgDYJNihUH01geH3EiYMeQwN YXanVX5gAfrQHtP27D6bkxejXVuWkK4k3nbxHa+FlR5Tu/tSicw= =4aeh -----END PGP SIGNATURE----- --wnvgml3Vew3NnKi4--