Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9l6A-0002N4-7u for pgsql-committers@arkaria.postgresql.org; Fri, 08 Jul 2022 10:20:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1o9l68-0006XN-TT for pgsql-committers@arkaria.postgresql.org; Fri, 08 Jul 2022 10:20:32 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9l67-0006V1-98 for pgsql-committers@lists.postgresql.org; Fri, 08 Jul 2022 10:20:32 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9l5z-0001sy-4n for pgsql-committers@lists.postgresql.org; Fri, 08 Jul 2022 10:20:30 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9B2955C019A; Fri, 8 Jul 2022 06:20:19 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 08 Jul 2022 06:20:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1657275619; x=1657362019; bh=GBJejr2F+d Ja7IovKqdvtJvSyAoXRWNb/AfrJoEei9A=; b=asHcZPhBg5NdmuwWq3bFkCI58a PK8GD+kSXSKtRaRUuGRaowoce8xsFKTfGLpxPrX91y19sHDvXtZF+CmDQF0S2YEd NWlx7miH5OasPQFJwD1cyhmwYdjr0NYgE1/4N6qVYNbZ6fINjKubCND1HdleFkPH 0xSs9gADQe+8dChrVOB7Ym8OX6fHyxTI8NF0/Oxpwmvlp8sFBQXg0FzWbFtZI5TJ a9i3qUSwo9rLotFIj9pg+9z7AGzgQwfit5IwRrlb9A7V6otIVeyOc62RRkoQgogC NNuYyBjikf3Rs7OcaLD9NLyGwgwQ4CfRnHNYTGgNQqzKksgrGHIU8BTcNxRg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1657275619; x=1657362019; bh=GBJejr2F+dJa7IovKqdvtJvSyAoX RWNb/AfrJoEei9A=; b=VDHJ8kNCaamXp0lPqOviEcCX7lvZAU9ZQ0pWwTuh8Viq bdDAevfAvlvefCv1WP7sOeXpGnIuy55S2jVuL6Qcg4x9iFkSGNb8D+Yjs1DGIlUh njpM8JnksZ2ODTNWNyQ0hgWvuoKrmRrwVhK32+W19CAWsBP4xsODxAThuscgmU9u kbDAC07NfE6CFBio3zPqgh0h6i2HDbciKdlGHM+SypjPVQCTMmXxQUH8zFpuzcbG Y19OT7Z+89cPqvqXzlGXkjdjlXJe8lJ1v/o45syG7Lc+V/wYNBq8VAni22cb6lKy 7DpvD0WF7vqxMFspl+JqwPrYPU60HhS52pOGvOlM5g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeijedgvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucgfrhhlucfvnfffucdljedtmdenucfjughrpeffhf fvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfrrghq uhhivghruceomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvg hrnhepteelieefudffhffhtdetleeggeegfffhkeeuveetiefgudduvedutefggeeivdej necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitg hhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Jul 2022 06:20:17 -0400 (EDT) Date: Fri, 8 Jul 2022 19:20:14 +0900 From: Michael Paquier To: Kyotaro Horiguchi Cc: andrew@dunslane.net, pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Only allow returning string types or bytea from json_serialize Message-ID: References: <20220708.154135.2123613118233840495.horikyota.ntt@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="iVQJNitqIx8VJlx0" Content-Disposition: inline In-Reply-To: <20220708.154135.2123613118233840495.horikyota.ntt@gmail.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --iVQJNitqIx8VJlx0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 08, 2022 at 03:41:35PM +0900, Kyotaro Horiguchi wrote: > I noticed that this introcues the following error message. >=20 > + errmsg("cannot use RETURNING type %s in JSON_SERIALIZE" > + format_type_be(returning->typid)), >=20 > However, the same file has the following error message. >=20 > > errmsg("cannot use RETURNING type %s in %s", > > format_type_be(returning->typid), fname), >=20 > So, couldn't we share the format string to reduce translatable > messages? Yeah, I think that you are right, so let's fix this. If Andrew does not show up, I'll take care of it. -- Michael --iVQJNitqIx8VJlx0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmLIBN4ACgkQnvQgOdby QH1/HQ/9GxSltFMz9lx2YWrbdAMyRX/7MyOK6tqhI5kuqlx+JoQ3P6r4x00Xu9v/ jkMJvanyAQdfYBD85789e3kdZNLbOmvFnjE628KQYqDMzJOqiq28yZLpri0IWKi7 X087DI33RtRZlR+CAyrMLMmkJ7Fj9SRtc9HXOeazPqoPOns5vU1Mzlj3puPrpry3 0bLmsPLZ0HUmktPOil61O5vtDmnnOTMg6dMMsVlkhw8rH7wifZmE+IEj+pUaG0xD GGfL1zzctPllzcnVOIFRguESkc5G2sMGWMf7XjGcL1Jr48UgN7YM3n+9Oaxaw6MJ YNa3HKxGkFrD+iQQY7ipZDWhJnVfdlkSoQe/MyHjNv/mry9lT+GskBDzLE9BBE7Z 1fWbNWu5DMf3sZdWq0VQc+hGY9cu1yk/oSYe/J2dq2P7k6M00NAtdbV0sWWFchUe SuNCBO6344TpxchC+Vom6Z3mAFYOEO149fxgXnTMI/ieJb8dfRHeVOATfNIGrVCZ V5A+t0KOmEM/BOsRgvAHOEEev0BjFkHQ5mz4XbamitnE+QTGNSrslGjbOE8R2AG7 74lruusbihqALxnOTCongb356jePudwW0j9W+Ig2QLX3XNP8uvQ/fAUEs/oEzHvm SctHXzXJjH/TpzniD2e0izE7uW0malSWp2l0S0NSR00G28/GcQw= =nN2P -----END PGP SIGNATURE----- --iVQJNitqIx8VJlx0--