Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGYlF-0008V2-7U for pgsql-committers@arkaria.postgresql.org; Wed, 27 Jul 2022 04:35:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oGYlC-0007Fa-05 for pgsql-committers@arkaria.postgresql.org; Wed, 27 Jul 2022 04:35:02 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGYlA-0007FD-Ch for pgsql-committers@lists.postgresql.org; Wed, 27 Jul 2022 04:35:01 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGYl5-0006Ae-HI for pgsql-committers@lists.postgresql.org; Wed, 27 Jul 2022 04:34:59 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 9EF125C00D5; Wed, 27 Jul 2022 00:34:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 27 Jul 2022 00:34:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1658896492; x=1658982892; bh=7GSQ19hMOu qBCe8NRZBG9qwEbgLLDZlVENSrXlnUJwg=; b=p/WTe8akPrQaeUHxitIzix0SwP Nr6FY0XOk06/Rn1zhQfawc4wZUUcjXMwrKRmJeNJ+PI3MYgtFXhZ9CrkNCe6nHgR mc9VQmCCDxL+UmHccJ4AOJV9jGpKhaMrWzHtO8abgyev2pggeS25MNVa4Kg7Q4zj yR2lRuw6LCsPXWGqxxF0OYsxCPQcpI8KAV4muahydnxiFX4tE/Wc3IsCpvRhuyAm Gekz7Uu23PChp4TtyCPe2s31gVdWPxdngeM9NUmA/aWgiycOqCn62nYHsaSDRf4I 9JsmifufYpJd8dCqCyRGeSZLRT9NTcBs6+iN25SHUT7nv72sVyn7eUScQV9A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1658896492; x=1658982892; bh=7GSQ19hMOuqBCe8NRZBG9qwEbgLL DZlVENSrXlnUJwg=; b=FeJ46rF7VJ2efe+PFx1EpyD0It8F4gEm4r5cOGKMwNYI u9xIP1yKobw94Hyd4sBce7QE50IjLWYpYY/tlue21ohl9AQzdgwO+RfKm+qWgg1S khVrbVDCfFviRRWsDeyecA5EcBBRxlJ1RSUhFTT+TCZRmms8wQoz4sUPpM/SoyDE VU0Z5pto/fp0x8UrgmI0Wppklzr04Xvwwetx19Dnht13Y1mEqVbcit+geijP5BZq sC2TPerj9CgyTASiasn07osAWdoPu9TEtvBofEexVyqRzzJFsqoFEJr+0zjo6ucs 2VufMPJRhcIqKz6dnV9RaD0AbXHbao4ZsUR9RUj20w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdduuddgkeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdlvdefmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepieeuueefheduffeggfdtvefg feevhedtjeehudekhfekueetkeduteehgfduvedunecuffhomhgrihhnpehpohhsthhgrh drvghspdgtihhrrhhushdqtghirdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 27 Jul 2022 00:34:51 -0400 (EDT) Date: Wed, 27 Jul 2022 13:34:48 +0900 From: Michael Paquier To: Robert Haas Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Remove the restriction that the relmap must be 512 bytes. Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="M74UUgOFehHU5nvR" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --M74UUgOFehHU5nvR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Robert, On Tue, Jul 26, 2022 at 07:10:22PM +0000, Robert Haas wrote: > Remove the restriction that the relmap must be 512 bytes. >=20 > Instead of relying on the ability to atomically overwrite the > entire relmap file in one shot, write a new one and durably > rename it into place. Removing the struct padding and the > calculation showing why the map is exactly 512 bytes, and change > the maximum number of entries to a nearby round number. >=20 > Patch by me, reviewed by Andres Freund and Dilip Kumar. >=20 > Discussion: http://postgr.es/m/CA+TgmoZq5%3DLWDK7kHaUbmWXxcaTuw_QwafgG9dr= -BaPym_U8WQ%40mail.gmail.com > Discussion: http://postgr.es/m/CAFiTN-ttOXLX75k_WzRo9ar=3DVvxFhrHi+rJxns9= 97F+yvkm=3D=3DA@mail.gmail.com The CI on Windows is blowing up here and there after something that looks to come from this commit, as of this backtrace: 00000000`007fe300 00000001`405c62dd postgres!errfinish( char * filename =3D 0x00000001`40bf1513 "fd.c", int lineno =3D 0n756, char * funcname =3D 0x00000001`40bf14e0 "durable_rename")+0x41b [c:\cirrus\src\backend\utils\error\elog.c @ 683] 00000000`007fe360 00000001`4081647b postgres!durable_rename( char * oldfile =3D 0x00000000`007fe430 "base/16384/pg_filenode.map.tmp", char * newfile =3D 0x00000000`007fe830 "base/16384/pg_filenode.map", int elevel =3D 0n21)+0x22d [c:\cirrus\src\backend\storage\file\fd.c @ 753] 00000000`007fe3b0 00000001`408166c9 postgres!write_relmap_file( struct RelMapFile * newmap =3D 0x00000000`007fecb0, bool write_wal =3D true, bool send_sinval =3D true, bool preserve_files =3D true, unsigned int dbid =3D 0x4000, unsigned int tsid =3D 0x67f, char * dbpath =3D 0x00000000`0090b1c0 "base/16384")+0x38b [c:\cirrus\src\backend\utils\cache\relmapper.c @ 971] Here is one of them, kicked by the CF bot, but I have seen similar crashes with some of my own things (see the txt file in crashlog, in a manual VACUUM): https://cirrus-ci.com/task/5240408958566400 Thanks, -- Michael --M74UUgOFehHU5nvR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmLgwGgACgkQnvQgOdby QH3Odg//XcjK/XcnaPoM50z3t/kNZlMEJaeLP3G/WwlH9Ph9fdq5dikQfhFTrXlU nmNjt4FYJ47tLlwY5qJXiCFkoHyn2lgX398WeJPSYb9fBAy7qUbZCKKS7jKJS8jy x1AnOdxR7dlZrHlz+aygaLMDlt2L+z6HNu770JaDbKy/Ajf0RGUE5T64NbqJ6JiR acdvTOoyQ4c6wEdBXPFrY7AzZh4Va95E4ze6wwoUA3OI7kYMKPSfiICn21+8nGvf iyZF2OLbk3xRPcNXP6IjiJ7gahfSjMog67fG6g+zdoZ5vHPXTVowwdL0R89WLNlR rg2HSfuydt1ulsQqCKvtE3A6gYskDSrVNQVtIbeKVVjh3wxFZRCvACEbVdH13RRj lYSwfmPBGigs0D0LQOdOHBrQ+xFMKHkSdTch74t/Tq/+iW9avtYGGlWL0N+fs2/L szKxvAHJhiqTHplWloM+0AfxKazbkYiZGy39RjFRHm51kWiqjTBFRTNr1OxrsXy/ gDkWvFlP2xoJLzwOCLkD56wwANoOZ4TRUS+uJs5XSUXf9dOSucmyNjUbET/CEhw/ wlzdPpR2f5bE8MZwCk074RkCc0gve5p3BA5z492mSJPwZ3Ipr1qzY61BJGmrOQKb N+RIkNjOzP25RTaaIchuKo/2IvegLxXoO4kh744n23ZUOPFFxMk= =wPwd -----END PGP SIGNATURE----- --M74UUgOFehHU5nvR--