Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGeEs-0006j8-2a for pgsql-committers@arkaria.postgresql.org; Wed, 27 Jul 2022 10:26:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oGeEp-0003Zp-4S for pgsql-committers@arkaria.postgresql.org; Wed, 27 Jul 2022 10:25:59 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGeEo-0003SW-D2 for pgsql-committers@lists.postgresql.org; Wed, 27 Jul 2022 10:25:58 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGeEl-0007mU-IP for pgsql-committers@lists.postgresql.org; Wed, 27 Jul 2022 10:25:57 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 93F593200930; Wed, 27 Jul 2022 06:25:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 27 Jul 2022 06:25:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1658917553; x=1659003953; bh=8kkbTz5vor +5/Z4EiLo2KB4hVlS+PwmBJpEoC2FEZuM=; b=Q21Ta9GTdEGM09QLYzztZKY4Hi gMc2Lc4CRQp3dlNHEHHlUrQSNJISMnCgecEvpqLqJ04IDpfnL1GfdODdJq4UV6GS IUlfo1bLCI38lQFK/JSQZLmjLqxhHeNb6dP74WyxPMvr+r8TWRFQc8v1jvByxx4i otUmCUCC55oo42UHOVF3axpzNIVrupOtJiNjPjOU/mjXiCE43GPeLmPxI22m5C/z 4oxMKKsRqefvH1yMX0sPuacSOdq8xXbYou1+2pXjQvFy2TNf3uvTpFtx7X1AIaaI izOGMeNypFIGvHP8L1xJFhBH4VqC7nsJ+gj/JW0nN7oenKW4M1mo07MwModQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1658917553; x=1659003953; bh=8kkbTz5vor+5/Z4EiLo2KB4hVlS+ PwmBJpEoC2FEZuM=; b=kPbJuAh8F0jU/20Ary1GwMdBO3gAkm9x1o+I79E8kUYx Opajh9RQoWQA2HK/SeQ7rvsyPH/2qKdNq1JTcmSHE5mNmhGVLFAVxeVcBQTyZSZl 79j4cS+pN8OfobnQVo2sAf9uLQsdEEIXCkiEvu5+w+frD9uUkl0x5oNKU0rZhrE+ jBSHSN5b8LuoShPOB0Lq3rJgOQ9NW+u8KRox+rJGES/Ekww6rQwY7cQuUNBOekKO ZMHzAr7OmfH5pIni483Iu1toxR109/ui2sExmMWY4Oqws4NbCET0w3lHxnemuqHn 1o3RgOypaviA9YfqJMOiCY3zea65iufcg4pzhtg94A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdduvddgvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 27 Jul 2022 06:25:50 -0400 (EDT) Date: Wed, 27 Jul 2022 19:25:47 +0900 From: Michael Paquier To: Thomas Munro Cc: Robert Haas , pgsql-committers Subject: Re: pgsql: Remove the restriction that the relmap must be 512 bytes. Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="D6f7urN86/1jzmXp" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --D6f7urN86/1jzmXp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 27, 2022 at 06:21:07PM +1200, Thomas Munro wrote: > Erm, let me try that again, this time with the CloseTransientFile() > also under the lock, so that we never have a file handle without a > lock. Right. The whole write_relmap_file() already happens while taking RelationMappingLock, so that seems like a good idea for consistency at the end (even if I remember that there is a patch floating around to improve the concurrency of pgrename, which may become an easier move now that we require Windows 10). I have tested three runs and that was working here even if the issue is sporadic, so more runs may be better to have more confidence. -- Michael --D6f7urN86/1jzmXp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmLhEqsACgkQnvQgOdby QH3vMA//W2MbZi9CWs3LFQXEURhBO811bTCqMSINyL8/YfGyvfSgUSJOmYK3qMSY JpwbNm0Kktd4LlSXm2gjidXuwB3/v4+ZuURMgB8yG5zRxWQju44jY+Uy0N/bLNSs eQs+pYoB1sZ9ReiNEPU0YZkInCyRe6Ys9+ei0fkS8yYr8RkYOUR/LSg7axHYL/q1 /vLuORfkfTNDMKPhKnXmtgVS2lQONMRoCzR4V3yzkZmKKi835Vpo4HAB4zWgWlvx Tic9TiqubPtLq2QudNgW7lKFdLnQmXqdZARnKwuoc6E9SquX4gpbobBZECEC0xM3 bkJyzhg8tD+kK0KkbVkyXgLIJkINxVrWxNUFh83ZKhH7gQmRiUXokddaGXKmrjr3 EMgpGT/xOcpUt/mDy/mSaahIMcLtulOMQIbdMpi+XhgMkOPnJeJQLxT7Zh24TGCP NeItGb/SskFiDY+L4r2LB/lvapjQQCUoJI8ZzG2Mrjqb0IWS+i/WZjOKCIMneOmT kHCZhYLbH9OtNU9ZoJeaOuXXB49c0KVTKNS30/xPwEyxo8yViY7PQjuSTPttBSGX 9eWUV6UfKZrkQSdUAOx46ndxuEq4FX1XqEhNNVnRHgL7EP3bke9djm/6ji7MCqhO qN+g+Pfv+9B2YHVLp6SQqSB8w5MK88WI1JMTNc6iMcrrvfBj+lI= =9+4L -----END PGP SIGNATURE----- --D6f7urN86/1jzmXp--