Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVS4E-0002E3-5x for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Sep 2022 06:28:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oVS4D-0003yw-0F for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Sep 2022 06:28:13 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVS4B-0003yi-LO for pgsql-hackers@lists.postgresql.org; Tue, 06 Sep 2022 06:28:12 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVS49-0004KO-6Y for pgsql-hackers@postgresql.org; Tue, 06 Sep 2022 06:28:10 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id C87053200564; Tue, 6 Sep 2022 02:28:06 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 06 Sep 2022 02:28:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1662445686; x=1662532086; bh=5lBh9mC6Cf LgrTrSnauBUhXy6HS0LM1ouFTtKwu9i0E=; b=m3o64BxZSH+nO9yZD5vM20iCAs P0GVOJGmmyVN53Azl5thsE+g3lAxFa6eiWUcmSnpqBVS9vJjvdtWaxaJK+QgKxEu el2q1GAvhbog+567Wbp3ad1Xd23Zdr2I3qJG1p9eRQ/gGh6hGdQoNIRq0eYKvEPe 0Odt8R2VRrq1WVWyUW/FVj0pRm5INNeH8Ms49053UF1v/9DJybh73EjGLQ20Kjwu qz2EGs3Fm7c9QtMbzCnnjOF4sYcTssJa1L8I8+x3dl3RMHswv7X/5Lvv6Ri+60FR BTykwVhinLF2+M/N9gE3M2HMnsJWBOELnQsTAgyzPD3Vd8jVV0OzFOM4Bd+w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1662445686; x=1662532086; bh=5lBh9mC6CfLgrTrSnauBUhXy6HS0 LM1ouFTtKwu9i0E=; b=s/hR2CggJv3xKsUYs1CdIF7UBDleKAFyh+XCAyhSTJQl zvqWERwyu0mnjKx/nboA8pcdWQQkQkOX7ZPUvKjXaIz9qz8+YsY1tqzn0DnWPewk c8cHE6wZ3jQUHyeYTzvOP7XwgMgJ0WhqsXp/v7cecK89K0nK+xbOM+W5DQK4E/Ap yKSInVhXktOss3D438+Zw/Bj5vXwtwobx0Y+A4zyb9sYNMmAFe8bKSRRTNKKVvLC O/dH8+5SSefYi9nqw798MMUg3PDjgR42mu1XRcQYZDGGLnt65/tDnAOi4fUDoPI7 5SEKu2j9ifBUdhd0funI4mLhLXJKLJQtkawHAX2/8A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeljedguddtkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enfghrlhcuvffnffculdefhedmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreer tddtvdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlse hprghquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteel geeggeffhfekueevteeigfduudevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdig hiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 6 Sep 2022 02:28:03 -0400 (EDT) Date: Tue, 6 Sep 2022 15:27:58 +0900 From: Michael Paquier To: Tom Lane Cc: Peter Eisentraut , Justin Pryzby , Beena Emerson , Andres Freund , pgsql-hackers@postgresql.org Subject: Re: [PATCH] Renumber confusing value for GUC_UNIT_BYTE Message-ID: References: <20220720145220.GJ12702@telsasoft.com> <5a943ffe-b07d-d99c-b96b-f4ed59c6f3ee@enterprisedb.com> <3052113.1662443873@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1pQMHSuZcDZF33qj" Content-Disposition: inline In-Reply-To: <3052113.1662443873@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --1pQMHSuZcDZF33qj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 06, 2022 at 01:57:53AM -0400, Tom Lane wrote: > Peter Eisentraut writes: >> I think renumbering this makes sense. We could just leave the comment= =20 >> as is if we don't come up with a better wording. >=20 > +1, I see no need to change the comment. We just need to establish > the precedent that values within the GUC_UNIT_MEMORY field can be > chosen sequentially. +1. -- Michael --1pQMHSuZcDZF33qj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmMW6G4ACgkQnvQgOdby QH3ThhAAjqYNZ9e/Sm3Ahx1N8jQhLeBulbhMejbWDTvcmlj+eY7WcA68qc9zdfwR 1STnN4nBJF45EU4uS9Hy85COg/j63YeRf3p6DjWVGVprYtpplirHtmvJ1yelurT7 cEdacG1KOT2QMrzbe1QU3NOHj7fR6ywLPc91V96budoC4haukDe8/n8WeVA4Fnf1 7rGnJ3Y/7exIJWkInymbN4kQR+kVOTNPnclqCD9Y4ZK7FcMpzOOIs9lgGinb/zFF 3ouWe7QNGRdX/2kE+NwN5A7wH18RHtNKYohV/G0gf7QYtS+Pj/iXpj1rLT6JiNZX i+Q7ZuGoU5KQDHtCtnxuLT5351Q5P3TOQiFEKiTQsZdMU5B49+/QpU0si8a3H4x1 +EZjdK3N5W/W2eKdpQNQ3rP6pKhV5CzYLjPEGdqj3gxlzXYhqReigBZC5B4ubPvj ZMe3avD3qPQ/AXug8Kox85U39XYrZgOz9W6ONT4pP4e3TYGTKKRlAcOH9PSmOYOr 4yXJOhySNp8NGz1Q9N6LfiZ0StuqmErP+YUhV8KNoFai4NSfUJzphxEEpNLtDa8Z 7oz6hQVF5Xfj0if5QRBv8ELyXph4dsY9Gf7qWu8u7Ek2E9JJxk2PljF0BgDwuIn0 hRRW5xOpE1sVV8ZzMwItzfHu2NSVX8dAfrdp44gGb9nxBE1kMjE= =kcJY -----END PGP SIGNATURE----- --1pQMHSuZcDZF33qj--