pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
PostGIS and json_categorize_type (Re: pgsql: Revert SQL/JSON features)
4+ messages / 2 participants
[nested] [flat]

* PostGIS and json_categorize_type (Re: pgsql: Revert SQL/JSON features)
@ 2022-09-07 09:01  Christoph Berg <myon@debian.org>
  0 siblings, 1 reply; 4+ messages in thread

From: Christoph Berg @ 2022-09-07 09:01 UTC (permalink / raw)
  To: Andrew Dunstan <andrew@dunslane.net>; +Cc: pgsql-hackers@lists.postgresql.org, PostGIS Development Discussion <postgis-devel@lists.osgeo.org>

Re: Andrew Dunstan
> Revert SQL/JSON features
> 
> The reverts the following and makes some associated cleanups:

-void
+static void
 json_categorize_type(Oid typoid,
                     JsonTypeCategory *tcategory,
                     Oid *outfuncoid)

This chunk broke PostGIS 3.3.0 compiled with 15beta3, when used with
15beta4:

psql -Xc 'CREATE EXTENSION postgis'
ERROR:  could not load library "/usr/lib/postgresql/15/lib/postgis-3.so": /usr/lib/postgresql/15/lib/postgis-3.so: undefined symbol: json_categorize_type

The PostGIS source has this comment:

 * The following code was all cut and pasted directly from
 * json.c from the Postgres source tree as of 2019-03-28.
 * It would be far better if these were exported from the
 * backend so we could just use them here. Maybe someday.
 * Sequel: 2022-04-04 That some day finally came in PG15
...
#if POSTGIS_PGSQL_VERSION < 170
static void
json_categorize_type(Oid typoid,
                     JsonTypeCategory *tcategory,
                     Oid *outfuncoid)

The "< 17" part was added on 2022-09-03, probably because of this
breakage.

Recompiling the (unmodified) 3.3.0 against 15beta4 seems to fix the
problem.

So, there is probably no issue here, but I suggest this "static" might
be considered to be removed again so PostGIS can use it.

Christoph





^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: PostGIS and json_categorize_type (Re: pgsql: Revert SQL/JSON features)
@ 2022-09-07 09:07  Christoph Berg <myon@debian.org>
  parent: Christoph Berg <myon@debian.org>
  0 siblings, 1 reply; 4+ messages in thread

From: Christoph Berg @ 2022-09-07 09:07 UTC (permalink / raw)
  To: Andrew Dunstan <andrew@dunslane.net>; pgsql-hackers@lists.postgresql.org, PostGIS Development Discussion <postgis-devel@lists.osgeo.org>

Re: To Andrew Dunstan
> The "< 17" part was added on 2022-09-03, probably because of this
> breakage.
> 
> Recompiling the (unmodified) 3.3.0 against 15beta4 seems to fix the
> problem.

Err sorry, my local build environment was still on beta3.

PostGIS 3.3.0 is broken now with 15beta4:

10:52:29 lwgeom_out_geojson.c:54:35: error: unknown type name ‘JsonTypeCategory’
10:52:29    54 |                                   JsonTypeCategory tcategory, Oid outfuncoid,
10:52:29       |                                   ^~~~~~~~~~~~~~~~
...

> So, there is probably no issue here, but I suggest this "static" might
> be considered to be removed again so PostGIS can use it.

I guess either PostgreSQL or PostGIS need to make a new release to fix that.

Christoph





^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: [postgis-devel] PostGIS and json_categorize_type (Re: pgsql: Revert SQL/JSON features)
@ 2022-09-07 09:11  Justin Pryzby <pryzby@telsasoft.com>
  parent: Christoph Berg <myon@debian.org>
  0 siblings, 1 reply; 4+ messages in thread

From: Justin Pryzby @ 2022-09-07 09:11 UTC (permalink / raw)
  To: Christoph Berg <myon@debian.org>; Andrew Dunstan <andrew@dunslane.net>; pgsql-hackers@lists.postgresql.org; postgis-devel@lists.osgeo.org

On Wed, Sep 07, 2022 at 11:07:35AM +0200, Christoph Berg wrote:
> I guess either PostgreSQL or PostGIS need to make a new release to fix that.

Postgis is already planning on it.
https://lists.osgeo.org/pipermail/postgis-devel/2022-September/thread.html

-- 
Justin





^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: [postgis-devel] PostGIS and json_categorize_type (Re: pgsql: Revert SQL/JSON features)
@ 2022-09-07 09:15  Christoph Berg <myon@debian.org>
  parent: Justin Pryzby <pryzby@telsasoft.com>
  0 siblings, 0 replies; 4+ messages in thread

From: Christoph Berg @ 2022-09-07 09:15 UTC (permalink / raw)
  To: Justin Pryzby <pryzby@telsasoft.com>; +Cc: Andrew Dunstan <andrew@dunslane.net>; pgsql-hackers@lists.postgresql.org; postgis-devel@lists.osgeo.org

Re: Justin Pryzby
> > I guess either PostgreSQL or PostGIS need to make a new release to fix that.
> 
> Postgis is already planning on it.
> https://lists.osgeo.org/pipermail/postgis-devel/2022-September/thread.html

Thanks. I was skimming the postgis-devel list, but did not read the
subjects carefully enough to spot it.

Christoph





^ permalink  raw  reply  [nested|flat] 4+ messages in thread


end of thread, other threads:[~2022-09-07 09:15 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-09-07 09:01 PostGIS and json_categorize_type (Re: pgsql: Revert SQL/JSON features) Christoph Berg <myon@debian.org>
2022-09-07 09:07 ` Christoph Berg <myon@debian.org>
2022-09-07 09:11   ` Justin Pryzby <pryzby@telsasoft.com>
2022-09-07 09:15     ` Christoph Berg <myon@debian.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox