Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZUrg-0004OJ-3T for pgsql-committers@arkaria.postgresql.org; Sat, 17 Sep 2022 10:16:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oZUre-0000hs-9v for pgsql-committers@arkaria.postgresql.org; Sat, 17 Sep 2022 10:15:58 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZUre-0000hd-2q for pgsql-committers@lists.postgresql.org; Sat, 17 Sep 2022 10:15:58 +0000 Received: from feynman.df7cb.de ([195.49.152.168]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZUrV-000429-Gh for pgsql-committers@lists.postgresql.org; Sat, 17 Sep 2022 10:15:57 +0000 Received: from msg.df7cb.de (unknown [IPv6:2a02:908:1476:f1c0:2153:469e:71c8:de5b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) by feynman.df7cb.de (Postfix) with ESMTPSA id 4MV6K01cmsz3DyY; Sat, 17 Sep 2022 12:15:48 +0200 (CEST) Date: Sat, 17 Sep 2022 12:15:47 +0200 From: Christoph Berg To: Peter Eisentraut Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Fix createdb tests for C locale Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Re: Peter Eisentraut > Fix createdb tests for C locale > > If the createdb tests run under the C locale, the database cluster > will be initialized with encoding SQL_ASCII. With the checks added in > c7db01e325a530ec38ec7ba57cd3ed32e123e33c, this will cause several > ICU-related tests to fail because SQL_ASCII is not supported by ICU. > To work around that, use initdb option -E UTF8 for those tests to get > past that check. This seems to have broken 15 on apt.pg.o/Debian: 00:49:04 make[2]: Leaving directory '/<>/build/src/test/subscription' 00:49:04 make -C icu check 00:49:04 make[2]: Entering directory '/<>/build/src/test/icu' 00:49:04 echo "+++ tap check in src/test/icu +++" && rm -rf '/<>/build/src/test/icu'/tmp_check && /bin/mkdir -p '/<>/build/src/test/icu'/tmp_check && cd /<>/build/../src/test/icu && TESTDIR='/<>/build/src/test/icu' PATH="/<>/build/tmp_install/usr/lib/postgresql/15/bin:/<>/build/src/test/icu:$PATH" LD_LIBRARY_PATH="/<>/build/tmp_install/usr/lib/x86_64-linux-gnu" PGPORT='65432' PG_REGRESS='/<>/build/src/test/icu/../../../src/test/regress/pg_regress' /usr/bin/prove -I /<>/build/../src/test/perl/ -I /<>/build/../src/test/icu --verbose t/*.pl 00:49:04 +++ tap check in src/test/icu +++ 00:49:06 00:49:06 # Failed test 'ICU locale must be specified for ICU provider: error message' 00:49:06 # at t/010_database.pl line 60. 00:49:06 # 'psql::1: ERROR: encoding "SQL_ASCII" is not supported with ICU provider' 00:49:06 # doesn't match '(?^:ERROR: ICU locale must be specified)' 00:49:06 # Looks like you failed 1 test of 5. 00:49:06 t/010_database.pl .. 00:49:06 ok 1 - sort by database default locale 00:49:06 ok 2 - sort by explicit collation standard 00:49:06 ok 3 - sort by explicit collation upper first 00:49:06 ok 4 - ICU locale must be specified for ICU provider: exit code not 0 00:49:06 not ok 5 - ICU locale must be specified for ICU provider: error message 00:49:06 1..5 00:49:06 Dubious, test returned 1 (wstat 256, 0x100) 00:49:06 Failed 1/5 subtests 00:49:06 00:49:06 Test Summary Report 00:49:06 ------------------- 00:49:06 t/010_database.pl (Wstat: 256 Tests: 5 Failed: 1) 00:49:06 Failed test: 5 00:49:06 Non-zero exit status: 1 00:49:06 Files=1, Tests=5, 2 wallclock secs ( 0.02 usr 0.00 sys + 0.81 cusr 0.32 csys = 1.15 CPU) 00:49:06 Result: FAIL 00:49:06 make[2]: *** [Makefile:19: check] Error 1 00:49:06 make[2]: Leaving directory '/<>/build/src/test/icu' https://pgdgbuild.dus.dg-i.net/job/postgresql-15-binaries-snapshot/194/architecture=amd64,distribution=sid/console Christoph