Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 20 Sep 2022 10:25:41 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade test failure
Message-ID: <YykWlaJj3dphGBvR@paquier.xyz>
References: <E1oXuu7-0005bU-55@gemulon.postgresql.org>
 <20220919213217.ptqfdlcc5idk5xup@awork3.anarazel.de>
 <YykSmXbGi08agCRq@paquier.xyz>
 <20220920011317.24bbsihqwn5dg7fi@awork3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="IBTkSDw8TD/nqWME"
Content-Disposition: inline
In-Reply-To: <20220920011317.24bbsihqwn5dg7fi@awork3.anarazel.de>
Archived-At: 
 <https://www.postgresql.org/message-id/YykWlaJj3dphGBvR%40paquier.xyz>
Precedence: bulk


--IBTkSDw8TD/nqWME
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Sep 19, 2022 at 06:13:17PM -0700, Andres Freund wrote:
> I don't really see what'd race with what here? pg_upgrade has precise control
> over what's happening here, no?

A code path could have forgotten a fclose() for example, but this code
is rather old and close-proof as far as I know.  Most of the log files
are used with redirections for external calls, though  I don't see
how these could still be hold after pg_upgrade finishes, though :/
Could the use meson somewhat influence when running tests on Windows?

> I've only seen it once so far, but there haven't been many CI runs of the
> meson branch since rebasing ontop of the last changes to pg_upgrade.

Hmm, okay.  Is that a specific branch in one of your public repos?
--
Michael

--IBTkSDw8TD/nqWME
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmMpFpUACgkQnvQgOdby
QH1rrxAAgrCma5mKIG0DKiOV5FQpNycllpgD5KB29tNRiZk1qgD2qSRrvX+hLPZO
oHKCNLV+Fs6EyZvdL0kGI/woTQpnV1wkv0eD6ytC99rpI80u1sPAzrHc99yMg18i
TxVczz6mfvPLR+zoUfFo4Q+Eudktfuf4txhE2kULUVmPSd5GFi6lfXGV/tIsOnYS
Ra0RK+UIZ5f+nBFMJT9bwsLH7kpv3spPod1/APS10Cks8wNGP4eXTOZ7JhU+rXXN
/a0iVN4NryyU7nqG0IrB6Wb8JHuIjmJSgzSEv290+uuqsnbDz33xCds04VoqkU/w
UfZbsMasRLzoRl/xVJt5umHIs6VgA4S2x/uNUHnZEvUU9WfXXfVC+Gxv/OX9aIU1
UkeGG2EVz/z5zbXZ/xS7ROkThfdIOw+3RmZh6YjcmlsUlAEAyvelvMqjVd9wj16Q
7Qwd5RPzRUlPOziYW0ug8zZpp3z4au6zLI5MBjmkTvIsmBqoaVHr4VuEIkUIeX0Q
x5g4FhvhxnFX596KgxdBi+B7iQ8Kdn0ZiRDjTB/UwwNCOsj+Zq9Ke1pkAKpXw507
WEcoeycWGpn8g6Kii2d6aWcnWflM7BtiGLRreXVBwz8vd7syvkAlpThz1bQXXzKM
NEuQQ5mt2aXI1LbIw/81t0899elK1gbCBMLy6PRQgsHVNItovRY=
=s96L
-----END PGP SIGNATURE-----

--IBTkSDw8TD/nqWME--