public inbox for [email protected]  

help / color / mirror / Atom feed

From: Christoph Berg <[email protected]>
To: Daniel Gustafsson <[email protected]>
To: Jacob Champion <[email protected]>
To: Thomas Munro <[email protected]>
Cc: [email protected]
Subject: Re: pgsql: Add support for OAUTHBEARER SASL mechanism
Date: Mon, 31 Mar 2025 23:54:30 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

> Add support for OAUTHBEARER SASL mechanism

Debian still has this experimental port with a GNU userland and a
FreeBSD kernel called kfreebsd. I don't expect anyone to particularly
care about it, but it found an actual bug:

/build/reproducible-path/postgresql-18-18~~devel.20250331/build/../src/interfaces/libpq/fe-auth-oauth-curl.c: In function ‘register_socket’:
/build/reproducible-path/postgresql-18-18~~devel.20250331/build/../src/interfaces/libpq/fe-auth-oauth-curl.c:1317:20: error: ‘actx’ undeclared (first use in this function); did you mean ‘ctx’?
 1317 |         actx_error(actx, "libpq does not support multiplexer sockets on this platform");
      |                    ^~~~

This should not be a compile-time error; actx is not defined outside
the #ifdef blocks there:

/*
 * Adds and removes sockets from the multiplexer set, as directed by the
 * libcurl multi handle.
 */
static int
register_socket(CURL *curl, curl_socket_t socket, int what, void *ctx,
                void *socketp)
{
#ifdef HAVE_SYS_EPOLL_H
    struct async_ctx *actx = ctx;
...
#endif
#ifdef HAVE_SYS_EVENT_H
    struct async_ctx *actx = ctx;
...
#endif

    actx_error(actx, "libpq does not support multiplexer sockets on this platform");
    return -1;
}

https://buildd.debian.org/status/fetch.php?pkg=postgresql-18&arch=hurd-amd64&ver=18%7E%7Edev...

Christoph

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pgsql: Add support for OAUTHBEARER SASL mechanism
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox