Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pa4Au-0004lL-Gf for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Mar 2023 00:30:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pa4At-0002Lu-Cy for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Mar 2023 00:30:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pa4At-0002Le-3e for pgsql-hackers@lists.postgresql.org; Thu, 09 Mar 2023 00:30:27 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pa4Aq-0002hu-Ed for pgsql-hackers@lists.postgresql.org; Thu, 09 Mar 2023 00:30:26 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6ED0F5C017E; Wed, 8 Mar 2023 19:30:23 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 08 Mar 2023 19:30:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1678321823; x=1678408223; bh=LM hYkFtcWyAEArEhoWQHy2+cpt9Em9mEHcelMuXN3N4=; b=tv7kv3iY6NIPRO/3JG dMLYhmF+As1ViscQ+ZbIAjanJtjO4DaaEbBjW8I6zm2bv+vYNM4jmLxW6hbYsWuX h9YNzRRm4ygwvKV8WbtWa+pkTiEcFrsyqvXzx/kFp3rk7wypKdhce45529vM3Zsv X8S7FNYXyrnnU34h2+SOwp/6seF++xCdFRcdfCmq+T8A3pVJrZzOp4UMgr0NVMGH EkBJ2i6k1D3RkO69E+MhdUC28DKOrKKK/GYlHeOV2Au643w5/Rkby1MbHVFkWAAN SJKfcdgfwHpGFPDS5X+O+dOQO8s9ZMq//tIoMKIbrLmvdzogeM5awcNVXx1AgRc0 2xLw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1678321823; x=1678408223; bh=LMhYkFtcWyAEA rEhoWQHy2+cpt9Em9mEHcelMuXN3N4=; b=qC2Ll4FyVIRdoi6J8YDmWj9T0UFDg J58ojV1dIL246U7OKKFKiMHwc2NBpZ6/73DsoCH7RF8a8iXSY5h8PvgkrfA5RlQR 4Kk/swj/R6X7NAXZ39m88vgRYRt53Wqh2IsOuXgJLymNxItQdF/rE+NSIrdt79RP suF8ZEit0/5rVr0i786hJrD1bvSpUYxMoiATloaB3TKW6QYB2sDRnWVPGrCcmzzr WayAHqfVEHg7R+EyTOr8EfncY98n8dE03DWMQmqyjTnAWYQ2wBEgsKztWbS6DBAn +Vx9nRlejlOBOPNOWhrl8bdWJmj+frh3lwXGvKmjnvzrMCjzHbnf2D9Lw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddugedgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 Mar 2023 19:30:20 -0500 (EST) Date: Thu, 9 Mar 2023 09:30:15 +0900 From: Michael Paquier To: Tomas Vondra Cc: Daniel Gustafsson , Christoph Berg , Tomas Vondra , PostgreSQL Hackers Subject: Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump) Message-ID: References: <819f6883-f7cf-74fd-e918-4c06a9d76d0b@enterprisedb.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7q685ARh0DxSdaLN" Content-Disposition: inline In-Reply-To: <819f6883-f7cf-74fd-e918-4c06a9d76d0b@enterprisedb.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --7q685ARh0DxSdaLN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 09, 2023 at 12:39:08AM +0100, Tomas Vondra wrote: > IMO we should fix that. We have a bunch of buildfarm members running on > Ubuntu 18.04 (or older) - it's true none of them seems to be running TAP > tests. But considering how trivial the fix is ... >=20 > Barring objections, I'll push a fix early next week. +1, better to change that, thanks. Actually, would --rm be OK even on Windows? As far as I can see, the CI detects a LZ4 command for the VS2019 environment but not the liblz4 libraries that would be needed to trigger the set of tests. -- Michael --7q685ARh0DxSdaLN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmQJKJcACgkQnvQgOdby QH18pBAAlx7bJNSo5WTGorRNuHpUahxNDOeYnG5o1icXmcmU3H+30UmMt6TQ1OLb V7YeljPCMh/wx+FXteq/ZbGE1tIUpNAQU0VCWakxd6G0NxMQKZNws11cTEzI0gVG LLItYkUG1Iv3j4t2RcK1d2kbzJ5TJayCWiBJdLUc0ZE5yZG1B9AfHuRwSF0heuva eTaU+mdEutP4rBEJuzPyhsJ2Z8uqE/p8dDPNFgUijhpygZEbNwAfdMCBD5Z2+EY+ n2hM7gG+t7Zr0j4U4oLaYgEAVjRy1UhfrSuF7AYDQjfwn22SigSsJFNAEBli2LRY nUold4zcOOY0k3wqHStiu0L6PlkSn8nD4BXGDvvykad4L25+e+E05Kc/iNjXhPTW Ce6tMrIyrdfxwdOLNKz9DlRGdIUzkeZqy8d0sCfZOuC1O7HT/TYwDCwlx7Nv2wIl 9BsUJUA4e1iFTbc+o4eN/oqTQDKk4qrjxfbSd47e79rwtL0KaHhVczsHNaOtCr6C jRnZiaGlNnVX35liAa9ote//J/laYqtIbLViaCueblKZ2fOBJuW82qWy+0Tav9vk FWM4qtfIr+45NJt1Zr5JM610Hu5fCvqUM6bn7VO/V1bXO6yyqszgaiztqR/knaUv /7tdxu+Wn0i6bwK+7imQJYj8Z9tQdO7tl2maj42zUY4pTTxckuc= =cy28 -----END PGP SIGNATURE----- --7q685ARh0DxSdaLN--