Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pc1yv-0006KU-Sw for pgsql-hackers@arkaria.postgresql.org; Tue, 14 Mar 2023 10:34:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pc1yu-0002gs-No for pgsql-hackers@arkaria.postgresql.org; Tue, 14 Mar 2023 10:34:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pc1yu-0002gj-EE for pgsql-hackers@lists.postgresql.org; Tue, 14 Mar 2023 10:34:12 +0000 Received: from feynman.df7cb.de ([195.49.152.168]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pc1yr-0002sG-9W for pgsql-hackers@lists.postgresql.org; Tue, 14 Mar 2023 10:34:12 +0000 Received: from msg.df7cb.de (unknown [IPv6:2a02:908:1482:3660:2ae7:2867:64d8:87dc]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) by feynman.df7cb.de (Postfix) with ESMTPSA id 4PbVJ02LCfz3F5h; Tue, 14 Mar 2023 11:34:08 +0100 (CET) Date: Tue, 14 Mar 2023 11:34:08 +0100 From: Christoph Berg To: Tomas Vondra Cc: Michael Paquier , Daniel Gustafsson , Tomas Vondra , PostgreSQL Hackers Subject: Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump) Message-ID: References: <819f6883-f7cf-74fd-e918-4c06a9d76d0b@enterprisedb.com> <0e8e53fa-5087-2151-dcd6-a1d3ad3ed493@enterprisedb.com> <74f02417-d18a-71dd-a406-8af41cbeb6c4@enterprisedb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <74f02417-d18a-71dd-a406-8af41cbeb6c4@enterprisedb.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Re: Tomas Vondra > and I don't think there's a good place to inject the 'rm' so I ended up > adding a 'cleanup_cmd' right after 'compress_cmd'. But it seems a bit > strange / hacky. Maybe there's a better way? Does the file need to be removed at all? Could we leave it there and have "make clean" remove it? Christoph