Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1povyN-0007Gs-0r for pgsql-committers@arkaria.postgresql.org; Wed, 19 Apr 2023 00:46:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1povyK-0002Lo-Rr for pgsql-committers@arkaria.postgresql.org; Wed, 19 Apr 2023 00:46:56 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1povyK-0002Le-KI for pgsql-committers@lists.postgresql.org; Wed, 19 Apr 2023 00:46:56 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1povyH-000amI-T2 for pgsql-committers@lists.postgresql.org; Wed, 19 Apr 2023 00:46:55 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 61E1A320093F; Tue, 18 Apr 2023 20:46:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 18 Apr 2023 20:46:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1681865212; x=1681951612; bh=nc V0EL1szIXAO7VAhTk5f0fYurCylABGvcovRp8OfZs=; b=HaevFb2Wf7pyw4jZCM n5+o0RlutDMn04MyV0zdBXkNTXvmop8nE3UxQHwS0dzdwc8hujq8jUiNjfK504Np h0sxO3UiHbgXY7jgisL9aLIJ0yynGmzVYBQc5pTssjlpnhWq2KxVQUCc6qY0fNZ2 gbhwkM3g8mXQO8f8CW7SzrRph/EIpjHwr/oCA1BujavgQTt/P6DVacDvZv4xtNgH xki4bZgq5O/C3m4+8Z9wpsLDpqOMMRPt4Td7IvrLoes7KzRjg8XOv0oWFbHR2y1z DI65S84Cwu+Tx2iY+YSSuIUBOl2cvOp78+/1VZmdHvZBXJTbMX6uVQ3cr2oCPNZi yyLw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1681865212; x=1681951612; bh=ncV0EL1szIXAO 7VAhTk5f0fYurCylABGvcovRp8OfZs=; b=YO2JhCuE0ESbBPY4x4VkEviQPdDsX EQBZ+NsMF5TbjmYFnEbbaE4HPbh95y6c9ZrhidbXhJFGPqCns3XDGx7MraQR+Sq5 WIF2WlfiWmMD6Ca2sXUvn7ytJhBS0weHwZ9wC289iZPMb6dDTWDy5vedWL6gXjF0 hB4wln9WXdkE9ybb/cndQMDqXdzidMc6v0qxQ3ITGs6UOqB6c5jZ5gS/UduYTXoY vqfFUyTChMqnXVXH7XYReSKav//j+lL54BHdwjdtXehzkScG/h1yAKuXM5P4MQ2s tlTiFs++VJXAht2npQ4pm80VrEfSfSu6i0HCOFY7PFdIeH7EC3w44aF6w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdelledggedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdlfeehmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepgeffjeevgfevuddvjedtvddt ieejheduueelvddufedtgfefjedvkeevkeeivddvnecuffhomhgrihhnpehpohhsthhgrh gvshhqlhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 18 Apr 2023 20:46:49 -0400 (EDT) Date: Wed, 19 Apr 2023 09:46:44 +0900 From: Michael Paquier To: Jeff Davis Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Build ICU support by default. Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="TFUDcK5KF4jkEB8s" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --TFUDcK5KF4jkEB8s Content-Type: multipart/mixed; boundary="b1x1eLOYwGBbNg0n" Content-Disposition: inline --b1x1eLOYwGBbNg0n Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 18, 2023 at 08:36:45PM +0000, Jeff Davis wrote: > Build ICU support by default. As guaibasaurus is telling, this broke the generation of the distribution tarball: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dguaibasaurus&dt= =3D2023-04-19%2000%3A20%3A03 The problem is easy to reproduce: just run "make dist" from the top of the tree. The fix is a bit more tricky, straight-forward once you know that ./INSTALL is generated from the contents of installation.sgml (learnt that the hard way), and is similar to 45aa88f where you should add a few extra rules to standalone-profile.xsl to replace the links by some text. I guess=20 that you could just replace both references with "the documentation" in this case, as the terms are specified in the paragraphs generated in the ./INSTALL, like the attached. Do you mind if I apply the attached to fix the issue? -- Michael --b1x1eLOYwGBbNg0n Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="collation-fix-make-dist.patch" Content-Transfer-Encoding: quoted-printable diff --git a/doc/src/sgml/standalone-profile.xsl b/doc/src/sgml/standalone-= profile.xsl index ea8a8f1728..1b3938a638 100644 --- a/doc/src/sgml/standalone-profile.xsl +++ b/doc/src/sgml/standalone-profile.xsl @@ -40,6 +40,10 @@ variant without links and references to the main documen= tation. the documentation about client authentication and libpq =20 + + the documentation + + the main documentation's appendix on documentation @@ -60,6 +64,10 @@ variant without links and references to the main documen= tation. the documentation =20 + + the documentation + + the PL/Python = documentation --b1x1eLOYwGBbNg0n-- --TFUDcK5KF4jkEB8s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmQ/OfQACgkQnvQgOdby QH07ABAAlJ+cIl+kn9WFMOXMqNDgsQbUxicDAABSqFetdiCoy3ZuIJ4cjtKWM43p LDHLA1pGTWE+XTBFX4UDR8SfjSh1EJA/L1iSqhJHEAwHI9PDwIEbeEC2XdKrhA1n 84qWXMkmWYZGNrMdEyED1136eEDUrOSrV2nq/4ON6HnQKoGRFY8THuEJx//JXoLv OXTmtARpo8fRAF4zbDbQaLdTjomzbfea59lRVCOfVe0Zu1CN2c58yP/QL+NVQbzm ATLF4Tc1qMttcUoZanEODDEfwwIoJuDxwCg8F3pStf3lKhC3RYJzVMMIfpTt30vE 7YvFdSZjy/Mo7ZHxZ/dkIWYV0su1zVvIcyVS1TLIEYiKw2obliFS3AGLa3yvOlfP bzpS5Cf0OfkdAb0v3nBfmbyrjyQQS0GPqs/XTT37Wd0UjoTO1kuI694MC7rKYT59 iLisNcFzAo7E1tlFXUJtwwtpTgM/4L5LtJrTq9unuPZOnOynQEwqepksxk92HjBk iIvMQ7rbpUlYB2JaZVfoe1PlU9qCd1/TOYiODMklbtTm6E4hEGzF3nYbatknzpBy VlyH6KgC00jXQNUrFuXsy0Q80oJxfj1WJorz18dOUIcwhHYWZPJZJhNDlPiNVr2A W8Az8GnAipmOQOUzyVZCTBkpk8TyAz6TDVdoUBCnQf92M5/oNOY= =ZlJC -----END PGP SIGNATURE----- --TFUDcK5KF4jkEB8s--