Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJrQk-0005Ce-NX for pgsql-committers@arkaria.postgresql.org; Thu, 13 Jul 2023 08:12:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qJrQj-00081t-IK for pgsql-committers@arkaria.postgresql.org; Thu, 13 Jul 2023 08:12:05 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJrQj-00081k-BN for pgsql-committers@lists.postgresql.org; Thu, 13 Jul 2023 08:12:05 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qJrQg-000BnM-9a for pgsql-committers@lists.postgresql.org; Thu, 13 Jul 2023 08:12:04 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 72929320039A; Thu, 13 Jul 2023 04:12:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 13 Jul 2023 04:12:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1689235919; x=1689322319; bh=22 z35+tGvubWkAryhg5onzujVQXqiIIn5Zfmk6NUS58=; b=MqOJWmAvflq4ZK/yCl /pcHosXb5/DHtb+Q/Xr8OfU4lSN6pvrnwxtbXyqLuS53eECeXFLtQrJXxXvPIc7E RplS8jrpv6LtKFTPNryR4Zs0/jJ4pEIVbzB23MPAbANr5Zef1kh+1j6yfQELxZyJ cHEHIy/OjRtqRZs+D86xxznhvGSvGWTERlHRwlCSPgvRWRB7sAI2v6tNA9CAyAZQ 4c20/hUIBHhwqIjr+gyY4zRug/o3xsK3kIR6K59MjsFevFZAy4Wq4YQvy4N/LmU8 wVrsTHwSfPLaK/F8eGyUmRO6Aqq0aFAt6N7IVGHiOp1YYZj4WxKsjtopolZgw/yW uD3Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1689235919; x=1689322319; bh=22z35+tGvubWk Aryhg5onzujVQXqiIIn5Zfmk6NUS58=; b=eNZDqgNYsMJ1e7lRiwiWjHo3PKDzY qRSGmcwFXFkCKDyPXJnbz09sOGzsW+BBp0l8mRNFeJXgRsIZnQpzs2WgD+y3wAuY 6Y7UqkSuXKrUdLSwUD9Yv/CMnsJfwMi+cygYgdSvFAodAh+p/GTjCfhDjvgohqCz ig+HLS1zGeIA59NXNW+o16LXeo+Fo09sHiIKpk/SWoImkBURivFKxnIFm8xbQQbO 3/kKQnnuqWbXx9U/cLYJQDoEup5QTSbC2W74he8y9L6ZZ5OBPAAaULqBcdK2EWmX EJzdSaPH0/rRzMshRkBzZAAK8qKOGD6mR9mHRA5KrxUhwwR8SnCfosWSA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrfeeggddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdefhedmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeegffejvefgveduvdejtddvtdei jeehudeuledvudeftdfgfeejvdekveekiedvvdenucffohhmrghinhepphhoshhtghhrvg hsqhhlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Jul 2023 04:11:58 -0400 (EDT) Date: Thu, 13 Jul 2023 17:11:55 +0900 From: Michael Paquier To: Amit Langote Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Don't include CaseTestExpr in JsonValueExpr.formatted_expr Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="puAD8GE1WXLdaaLA" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --puAD8GE1WXLdaaLA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Amit, On Thu, Jul 13, 2023 at 03:33:07AM +0000, Amit Langote wrote: > Don't include CaseTestExpr in JsonValueExpr.formatted_expr >=20 > A CaseTestExpr is currently being put into > JsonValueExpr.formatted_expr as placeholder for the result of > evaluating JsonValueExpr.raw_expr, which in turn is evaluated > separately. Though, there's no need for this indirection if > raw_expr itself can be embedded into formatted_expr and evaluated > as part of evaluating the latter, especially as there is no > special reason to evaluate it separately. So this commit makes it > so. As a result, JsonValueExpr.raw_expr no longer needs to be > evaluated in ExecInterpExpr(), eval_const_exprs_mutator() etc. and > is now only used for displaying the original "unformatted" > expression in ruleutils.c. koel is unhappy after this commit: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dkoel&dt=3D2023-07= -13%2006%3A49%3A03 This code is not indented properly. -- Michael --puAD8GE1WXLdaaLA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmSvscsACgkQnvQgOdby QH1X7A//V8eYkC9I1VultoYt0wUh5b7//ZNJtduBHPtQiX1S3Cdh5Dg24cHAf/Pu hHFUVsYQz3lWJkjTsW0vIVDbAVMDmZbT/5lv8vGVT7ie94P0aIIlruCu02WxlhSD O7qkQJsQHrWLneWQwtMFXbmj2j1ltqdq6J3/sV2bjJ7/uOa4P+VSFYrc+ZOuIQ/H tbatzRdnJhA88bHJ0R1f6/jIHVmxzY5IyymWDVO1wVQT3bb+qPpDYFyo+TScrv0R /cVQXUF5YNF3HkXQ5jeJHwcpHbbPdJMXC06letbvgZsZRxyV7eKtBlEnj1EWpBFy Ii8d5kPLAI0IvqKs05mEci00y7wPThfqynU4DNQ+405fBxzmTqrJbUQ07cSktYDx b7YFpNQFh2xy/mycnAMQm3bAEJUqCW+mhZw+CGqoxn9Au/3pntXos0ItAmiTHZAk tejr9ZTgxoSfEBzhfPIZbhXUUtEOueZZHLp9x/xYd6ihB7bkR7QbOLoLTkCB8iaJ a5UUGSONUG7Pd+p2lovEs07KNX57ndPLM37880yLmMfJJxKSVHDO4RNeUZVtzj+0 EVSg4+rFFpOoGGi3DMDpLNDVT3rjDvca9ciDoYa6zPmZJX35Yty5CbzMR+ByQPQO whXnswLuOos35gMRfPtrdj4f3rMtP02jyOME0GFTHns7ig9VF94= =wp0u -----END PGP SIGNATURE----- --puAD8GE1WXLdaaLA--