Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qG7LX-0005aP-Pb for pgsql-committers@arkaria.postgresql.org; Mon, 03 Jul 2023 00:23:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qG7LW-0004eG-A3 for pgsql-committers@arkaria.postgresql.org; Mon, 03 Jul 2023 00:23:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qG7LU-0004e7-Uh for pgsql-committers@lists.postgresql.org; Mon, 03 Jul 2023 00:23:14 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qG7LQ-001qkp-5t for pgsql-committers@lists.postgresql.org; Mon, 03 Jul 2023 00:23:12 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6CB775C02FD; Sun, 2 Jul 2023 20:23:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 02 Jul 2023 20:23:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1688343784; x=1688430184; bh=bf dbKy0f/zCtP8THbzVr6G8tG6M2Y7gUX0IuQs9vDQU=; b=vpl51sSQKAtV320fkl hJkXWrrefpUjJ1azFg0S3n66iXMN8aZjRUml9OMy9KVc+0NpVG95qXpBp2tY8Wug qmv5AiXQQQku3uzZopTkHDn21APKC45DhtKkfPYegqI0Pt4yUPGiKH/+1E/dOTAo g4lw4FWRORJVMPew5fu1saf0ID7ZjUvZ8mX7rG/GsGd4qzMSZJBVvFyxQXFotIIq a9UMUXTL6BwUvQ2L0FsGEi7QKO5eexRIM5DgwMg5dCkIOD8qMflRbCtdoygVqeZT pnSEPcfKXzejsoGuZR9CX/I3zm4he3sIYTYeMaxf1HIVm+1P5pR3u86qkEIwB3as dsLg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1688343784; x=1688430184; bh=bfdbKy0f/zCtP 8THbzVr6G8tG6M2Y7gUX0IuQs9vDQU=; b=PuJd0i6hYkd1zXZBV+frKol9e1YWH vtYTUCTVGPpjHK0O8ykbvIXSEWPEMg/n/DqatlJd9FeBiSFxFVxtjkeHvH32USBH Sy2Vww+46QjSrQfB6BWaRLrcHbGUEVioiesBD+yY948F/ndtrQILO8ziLET/N4GK ttX92E9xj+tvwIsnF/yw37alW1/KjO0P/4v6Ge/Td0m6aJwXe+wmc+qmzBFd1oXj f03MSvFTXyoERk1NGvK2cNfGqyyoJiD7Y6zYwtHCWiu/gJP89Pn5txFAfgSrLMb5 TyrzHIwJDeog0PISu2u/ORiAI0ATbqbu24eMiq7khRXQY/14LuLfYzn3A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddugdeffecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdefhedmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetteegvddvveeuieduudevkeff veevtdduleehleelffdtvdegfeegtdejtedtkeenucffohhmrghinhepphhoshhtghhrrd gvshenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehm ihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 2 Jul 2023 20:23:02 -0400 (EDT) Date: Mon, 3 Jul 2023 09:22:58 +0900 From: Michael Paquier To: Tomas Vondra Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Introduce bloom_filter_size for BRIN bloom opclass Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9pWF0vo73dl38IzV" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --9pWF0vo73dl38IzV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 02, 2023 at 08:25:34AM +0000, Tomas Vondra wrote: > Introduce bloom_filter_size for BRIN bloom opclass >=20 > Move the calculation of Bloom filter parameters (for BRIN indexes) into > a separate function to make reuse easier. At the moment we only call it > from one place, but that may change and it's easier to read anyway. >=20 > Reviewed-by: Heikki Linnakangas > Discussion: https://postgr.es/m/0e1f3350-c9cf-ab62-43a5-5dae314de89c%40en= terprisedb.com koel has failed its indent step after these commits. I am unsure whether you need to fix this as it does not seem that we have a consensus to automate that, just FYI. -- Michael --9pWF0vo73dl38IzV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmSiFOIACgkQnvQgOdby QH2xLA//cMZ49NqzBtYJHgpUPDWAnsJL46jAgBdoVa6GWDPSABI9PVIatVSt4d1M ZWagUQlOgcgxvExsGkaV1T3cAAJaxoNm0PrbKxhdcPPLZipSzivFlSGEV2GCQ9TL rW6RSk9y250DiagNT52ilMGQu2s1trAWJI3V7jtxyZYCn7yARJyuCa9IfXmqLdmk TO/4KDVCqw74Mvi7CEa+HkpLCXN0X9eN5Ty9y/XSkG26ni5arkFlbNbtDpQOIfJh pUXqRIoHDMuHEyK9whF7lyAIItUahggEk6WylptSYj/5PCU7him3yHdADHRaM/yp 0/fBtX0Ip98+DsmhcnHoCG1h5UIw4zxSES5OYOU9oI/AjtaE/05ldNTkG9IFy7M+ OdsKud6O0Okry+9uTx1wdzRjtH4zqTELZIRmVBFuvLJ4nbsEeuc7CG7Qer1tqCOL iHthprxxDK9/w017lgB7loU4u25EGP/eF3HnLC0iDC5zLDw6YCJ7kB6MMtdAg9C1 wF93YzlWDT+kNMF3UvHaWAD90XN6PcPAAL4KICJh1QdAVUrxwwtt6P2+6ZvF72hL 4/+xCPYsPbI5SiO6rL7b+hck1v9nc4Cl+mMQaZxoodeQ1zZAUKqUqsgfKGAttvUQ nPKuQhgP0+oXfEi9woA2TCVK+hcwScIoK1yiwXyIJKBXJwoj2Xw= =F/Dn -----END PGP SIGNATURE----- --9pWF0vo73dl38IzV--