Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qOATq-0070jy-Bg for pgsql-committers@arkaria.postgresql.org; Tue, 25 Jul 2023 05:21:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qOATn-00EcB8-Ht for pgsql-committers@arkaria.postgresql.org; Tue, 25 Jul 2023 05:21:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qOATm-00EcAz-0n for pgsql-committers@lists.postgresql.org; Tue, 25 Jul 2023 05:21:03 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qOATg-000Bxy-DA for pgsql-committers@lists.postgresql.org; Tue, 25 Jul 2023 05:21:01 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 0B8B55C0083; Tue, 25 Jul 2023 01:20:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 25 Jul 2023 01:20:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1690262454; x=1690348854; bh=Mb It2wQZw/7qKGA/QHPkIfiP1zuvDpPy2l36u9WBQeo=; b=I3aRONWSpS8KPBqR2q /9MSI3kFvk0MQKEM8qYukO7xewr4t7HBbgS7+kYV/9It4QPngKwXDdQycydt2ZPY Wpt6THGxB6okg3bL5B9Y3mJGeRPOHNaERLCc/p9ZbgmyoU2v4lggZWQ4Mn0DBymH b6JNPwjlOcLD47yhXwt5OhczjCuRqoG56i+8feQysJxZMpBCj1I1lPYlWen9HFeM krIOMcNCulaZVp3gmZcW8t5sO90nNrqeXC6zTdAyWjkIlIoofazH5a6y2HJTQpq6 Wvctsa9A0FRAw/9ZTHSCmgj0+Usz68+6rVBZnQZo0tIxQPZck1RCxY+vdtE+PDha u0cA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1690262454; x=1690348854; bh=MbIt2wQZw/7qK GA/QHPkIfiP1zuvDpPy2l36u9WBQeo=; b=myG8N7IShRjyScokiXJvvQS17oXET YK1vT4/jvfMCCOivz+WP7izAgTEThPNBkovze3jIu93gCgZBuegGEm89N91g4ZsS EP/8ezEqYNeeJuFB4s9EcAK9QHzyDcWIZ2uYDlXTk7MKeLgpAQAeyzDOlaGu6xqV 8xbR0K7A9tcpkurIGfhoQ97CKUSggg4W2XRsxEhHWUu0KbSkUvTM5U4xmRRKLuHE ieDa4CKqUE/X5u++Y21gbYhEQc93C8AuQx0T5rbigNdA+TSTuw/V5zgvMRZun2B7 5FAUh7X6uNOnN1Balmm6Wl/+sE6Dqyc23nZdPbaiLgUJpCYuAHu0G0AYg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrheelgdelfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdefhedmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeegffejvefgveduvdejtddvtdei jeehudeuledvudeftdfgfeejvdekveekiedvvdenucffohhmrghinhepphhoshhtghhrvg hsqhhlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 25 Jul 2023 01:20:52 -0400 (EDT) Date: Tue, 25 Jul 2023 14:20:48 +0900 From: Michael Paquier To: Amit Kapila Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Fix the display of UNKNOWN message type in apply worker. Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="e8/8PdXyj2O+Nrq9" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --e8/8PdXyj2O+Nrq9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 25, 2023 at 03:52:32AM +0000, Amit Kapila wrote: > Fix the display of UNKNOWN message type in apply worker. >=20 > We include the message type while displaying an error context in the > apply worker. Now, while retrieving the message type string if the > message type is unknown we throw an error that will hide the original > error. So, instead, we need to simply return the string indicating an > unknown message type. koel is complaining after this commit: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dkoel&dt=3D2023-07= -25%2004%3A49%3A03 -- Michael --e8/8PdXyj2O+Nrq9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmS/W7AACgkQnvQgOdby QH3ZsQ/+PnvNz89V7BYyAo7Gh3tT4IgnRJIQY0WrvkXOoFgWqMSfzZhn6KyssQyI hoy9GUYJEqbJLHfllY+2xv/MlXIsYx0nAlwAm4m/6cQ3GuIPs/6xFcgFbwTqVDpk 5USf/dHXhnrTbE+PmV18F0uegrL+jRq499SXhRBdQ2DW+SLzSna5KpSI9MAh6hMg Aq/3CoVqV5zbI68E2qx3n6az5ftR2Tbndd4H0qOE2yJ8sWgwYAlzJS476FigNbCJ BdzCJrekHQQlGefldM2iYwH+bmon1KUQ8grvnAmsqNAodBuhpxFkxq2hwQKcvkXh LbbqZow+N4HoMfKofjD0Fqqt0txz9NYqR0G2ap0w3IorCToxhw/w9Q4qiBZBkWsP GzRwqwx/sdKlSq7FhOY4SnhBFIw/XtA6QQeB63u6ChcQc5eA2CfPEnnhmIEuwRYF ufgtAvfzcbUNff4ePk4fwKE5NtEnnQY8bqUjyS2ep4bfnC1BOo4w0i+d6m2IiENe bh/Vr1TJKctIW6llHIjLPcCKyvhLFR6pnCuR1mtz3kvIKNuaOUhMzCWVrWgcH9Yn 9XDFCbN2bbYMbk8cEFfbbMjnH9BMMeYQ2Cwd0m1sDekY7YxIPHiOyf215XTzsBHt OVa1YedCvAs45ZcUTrUfnL/ZN6nC64Xj5KsCAf9h+hb0hd2sqEE= =2K5Y -----END PGP SIGNATURE----- --e8/8PdXyj2O+Nrq9--