Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qaQFJ-009BIh-Hb for pgsql-committers@arkaria.postgresql.org; Mon, 28 Aug 2023 00:36:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qaQFG-005E90-Qd for pgsql-committers@arkaria.postgresql.org; Mon, 28 Aug 2023 00:36:42 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qaQFG-005E8f-IN for pgsql-committers@lists.postgresql.org; Mon, 28 Aug 2023 00:36:42 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qaQFC-001QWz-UE for pgsql-committers@lists.postgresql.org; Mon, 28 Aug 2023 00:36:41 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id EEC415C0049; Sun, 27 Aug 2023 20:36:34 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 27 Aug 2023 20:36:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1693182994; x=1693269394; bh=bG dD53JLuTxiZP92/pXwbJfr/Zy5mdPzMBhRhKNaR+w=; b=mezkTSd4I0IxSdzUQg SASVF0URF2AtjZ/Q4PuUKmWJ7puAqCk39ck91I/kcCWXH9bHfVH2VHbRYdWnJJMb f7fPnhjBkc968tMxiqcsOws+yFB5Kj8P4Nn4HWH5eD2UtKNSjZRKA5kV4E/nQXPW oP4A8W2+/r3+RnOLdETWPPzihjscAa5X5PCKRSDgDBs1uBPMmH0oUqFf8ZvJuCd+ Xkrnjv8KHcNmfj24x9K8q+qTuw6UH9Ai0gi3WqOnDcLgupTLKqmoWZs2/G91O9Ra /I9q78hv9GkxNcn/7CdL2OnedmKnt2GDVts8y+a0kum/qVeFMq17w0elagvh+joi RC0w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1693182994; x=1693269394; bh=bGdD53JLuTxiZ P92/pXwbJfr/Zy5mdPzMBhRhKNaR+w=; b=1NdMoz0Ftl4n7nQsuLp5qTQJGc2BN yOAMONWulfrsSbjGrMVzEEW1K6eonJq/wXm02NYwQQsBprRGcYKmV4vkzASLDrTC LbovYyG1i+9O/BMBO+Qw5Ib7QkIe4FIhlQ7GgzxoBVhi7oJBddpPgrLRFryJd4g+ 67+7zjwe9UEytzyUlEsMk8WZdO0wRn08ug/xoHVNVWJrG78FKI3N2qgMdrENytIa fvJ6rVMmm+rWKwaB3TbjBDlkwlmWLRGtl0TkuzcY87YgCmSBlSjizlUViBRXK7dI CnVGlfoBSzjckOKZ5aXqzB3kacr5Ec4QXbTILLmcKHRo+CTiNfAUY3zoA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudeffedgfeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 27 Aug 2023 20:36:32 -0400 (EDT) Date: Mon, 28 Aug 2023 09:36:29 +0900 From: Michael Paquier To: Andres Freund Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Use "template" data directory in tests Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HPa8S4rfQa27rNTk" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --HPa8S4rfQa27rNTk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Andres, On Thu, Aug 24, 2023 at 10:09:20PM +0000, Andres Freund wrote: > Use "template" data directory in tests >=20 > When running all (or just many) of our tests, a significant portion of bo= th > CPU time and IO is spent running initdb. Most of those initdb runs don't > specify any options influencing properties of the created data directory. >=20 > Avoid most of that overhead by creating a "template" data directory, alon= gside > the temporary installation. Instead of running initdb, pg_regress and tap > tests can copy that data directory. When a tap test specifies options to > initdb, the template data directory is not used. That could be relaxed for > some options, but it's not clear it's worth the effort. This commit is saving a lot of cycles here. Thanks for doing that! -- Michael --HPa8S4rfQa27rNTk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmTr7A0ACgkQnvQgOdby QH2TjxAAlYZbG3zNBP20CbrgzHDb8W5a7LYNZtvqOQNDBcXeRC6Dv45iziaxFQkW A6yiT5G/QNX4txCWjvAq9dOESagx8fcJF/j5s1AVxbQM31vkcFiIGakJuoYXnMAn TN8Ofn2fzyCyV3oeaWM8OCbZpg3dzqB8nx6EQNceLLxBaYB8enRGscL77ZHt1RpY Cf/sPBZwp5OOrGCCxX/B+qvvOX4B95a8u62GpOWWp5LORf2qLnSZpvMDVDmDMzBA +llooAwQvbgMpIg9+347qs2AxUQ3YSLzxJ355vsptXOaBDjhj5h6B7xmPOY7oNGX tlnktn3CK6UDGDHyD7tUyqtnPXj6WlTxz1B3hJ5gHYl/ilXEwGiK3CQw+XbG3KZ0 dsO3KAlHF/akf5a3yIonKFjb6HWIiPKvMtZKZWE0cOfjTA8c9orRfzby+zoP8VFV oZXGiMh6XIPmltzqWtjFDn34po4JlmgsX8fYFL3aenk7VIEf3oMnDN31jsUkJ3UC X9nzANqevsoakZKgNCrbPpwz9fGit+Y0rzsjEVS3gLfaGg9VhmJ/yQdu4mYdet2/ P2ryKlsAXlr/8rJcgVJ9x82X+Fuo2jIoXyM9eoGkTaU1k543Sm1NpjEIdin0iwbn VWtBFtkqTjqnza0KeaZuouoWYtpfG7TSoQI3cpIgGR5Xqqe98+g= =Yg/V -----END PGP SIGNATURE----- --HPa8S4rfQa27rNTk--