Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qxMXC-000LAx-Fd for pgsql-committers@arkaria.postgresql.org; Mon, 30 Oct 2023 07:18:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qxMXB-00BjTR-5y for pgsql-committers@arkaria.postgresql.org; Mon, 30 Oct 2023 07:18:01 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qxMXA-00BjTJ-VF for pgsql-committers@lists.postgresql.org; Mon, 30 Oct 2023 07:18:00 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qxMX8-003mpP-8e for pgsql-committers@lists.postgresql.org; Mon, 30 Oct 2023 07:18:00 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 369855C00EF; Mon, 30 Oct 2023 03:17:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 30 Oct 2023 03:17:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1698650277; x=1698736677; bh=wi O7lPvbf+lSZe2Idbdv5umU3j03dA3hJlX9lMp8d+U=; b=eD5doZjRvUlQYpt1hp VyZV5bULMOQzPqoqZLUvo8d6l1wbIGvO7u8/9BSpvMlIvj7a5uLsY8JhRc8v1p7S PFdxzvr2B/LjZedTzz7poUvFbCieehkLXb7uAqXGK9sB9Nu6Se+87CnoZuRE4adT F4c+Yw5TWeumeAToWsnXDf3RMrtZwbR9YE2GGYuJYhilXYscFeaCPyEGlOd2xEtC iXq89b6ZwAYfY9qI8WePg4J829155ERspN/ffbIOgo7bji7RaI6l35cDslKxWhO8 8A7R/Yyp4SfzZuzEEU0qRh8An5SIdIxlzlcpjIw4+e2bp2ewIqc3QR2/fT1OjwZ7 RHfQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1698650277; x=1698736677; bh=wiO7lPvbf+lSZ e2Idbdv5umU3j03dA3hJlX9lMp8d+U=; b=qH6ahoPgvOALbsdLmIoGFRd6XndBX OqFajUcgn2a3sr3U0N7qgHQDIXKL99TQn65Mu4VOiHvrsK5UGjtEnN+n4E1o+V6p Dzg85EI3fO/KoKuKJPcL0Uc7yO/T9yxibfxPDkMCFlFENPqC1MynyLh4o5qu/ZLR 5QGwD+eXG/mZ6VPNAmMV4f4nwI0dFrkXSh03/lPZy52APT5VQ2fK7QaO6BzItU4u 8FQAZgbbMN28ZfUZ8c8Iiv9Cjkx+HNf2cJteVTEY6LbAiNN8GaG2pEHs9UiAEB1v rlGm3mTQIpnY2p8Z3MjTZ7SafE+ZXBQSPx1zX55vMWjEYNtTG2bmWB7Ww== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrleelgddutdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdlfeehmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepgeffjeevgfevuddvjedtvddt ieejheduueelvddufedtgfefjedvkeevkeeivddvnecuffhomhgrihhnpehpohhsthhgrh gvshhqlhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 30 Oct 2023 03:17:55 -0400 (EDT) Date: Mon, 30 Oct 2023 16:17:52 +0900 From: Michael Paquier To: Alexander Korotkov Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Teach contrib/amcheck to check the unique constraint violation Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="c+dDb2eAeDTbcRpA" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --c+dDb2eAeDTbcRpA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Alexander, On Fri, Oct 27, 2023 at 09:21:50PM +0000, Alexander Korotkov wrote: > Teach contrib/amcheck to check the unique constraint violation >=20 > Add the 'checkunique' argument to bt_index_check() and bt_index_parent_ch= eck(). > When the flag is specified the procedures will check the unique constraint > violation for unique indexes. Only one heap entry for all equal keys in > the index should be visible (including posting list entries). Report an = error > otherwise. >=20 > pg_amcheck called with the --checkunique option will do the same check fo= r all > the indexes it checks. koel is unhappy with the indentation done in this commit. See the parts about verify_nbtree.c and pg_amcheck.c: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dkoel&dt=3D2023-10= -30%2007%3A04%3A04 -- Michael --c+dDb2eAeDTbcRpA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmU/WKAACgkQnvQgOdby QH0l3g/6AmixpH55rZtlcWQ2VoX5N1YTbNRjkcJCcALAH2R/xDA6cr2pXh4xF+dk LVzpfwhUg7eWD9SdogmE4wp6m3npGCkwtl3eWvzpDJC2kRhGdk4YoXwhdntYoqGU 08FfF6A5lss6v3WV/v872yeOQOuJRcqeCOi4CyxVwPsnORpyRxHx8j1FER2FOmpn 4QuVTwa36GUoap4CCvWRJmrp3+IOfles9ypnyXj9jTZ7WFb/pE15LziAlAY7Abln ukserXKvzsEjmjbY5/n4KldUbFc8nYYCZh2Y5XcsxODkLoPUBl8AUCOoWuf4zl4k zxIpzeHEJrK8Ua/GZ++rbQBOxC9JJHzAT4lya1t6tRBLwI+bgYM38La8z3jDsIOL zkXoavDuJdcm3GOEZhJo78cveglPagNFuBEZM4s2T4XSqQkMuC+QAKibvGzC818x jCiue3NDfKtZsot2eT6DfTw+Jd2hJ0Ba0GVhNXDRxxXBQCMoNeTZ0EysE5LThWas d9rjuJIusmX1LCWSblihHmFBEqK8PfX7wopPFsh8orZUTJbNFOckABVljUcnBav/ 8DqUWXJMFB6nVZdJCpBVOjgH3+5QX+k9H21lQ+19RLyF4BTklxQsR9ZWOE4FS/0u FzhcHtzXz2fg76FFXyFTb/cHN5X5q3wG+frOW4n3QYAcLOBa+NI= =CKUw -----END PGP SIGNATURE----- --c+dDb2eAeDTbcRpA--