Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 19 Oct 2023 08:45:18 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Christoph Berg <myon@debian.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Generate automatically code and documentation related to
 wait ev
Message-ID: <ZTBuDsHd4NEhbowc@paquier.xyz>
References: <E1qGrjy-001xEm-TF@gemulon.postgresql.org>
 <ZTAA11u7CtX6NqlK@msg.df7cb.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="OHFxu7UHTD/4xrjR"
Content-Disposition: inline
In-Reply-To: <ZTAA11u7CtX6NqlK@msg.df7cb.de>
Archived-At: 
 <https://www.postgresql.org/message-id/ZTBuDsHd4NEhbowc%40paquier.xyz>
Precedence: bulk


--OHFxu7UHTD/4xrjR
Content-Type: multipart/mixed; boundary="B2Fp1kClZnUKLZyq"
Content-Disposition: inline


--B2Fp1kClZnUKLZyq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Oct 18, 2023 at 05:59:19PM +0200, Christoph Berg wrote:
> I'm not entirely sure this is the commit to blame, but it's certainly
> close:

That would be in this area, thanks for the report.

> A Debian user is complaining that in PG17, the installed
> /usr/include/postgresql/17/server/utils/wait_event.h file is
> referencing utils/wait_event_types.h, but that file doesn't get
> installed by the (autoconf) build sytem.

On a fresh install of HEAD (3f9b1f26ca), I get:
$ cd $(pg_config --includedir-server)
$ find . -name wait_event.h
./utils/wait_event.h
$ find . -name wait_event_types.h
./utils/wait_event_types.h

But I have missed a piece related to VPATH builds for
wait_event_types.h in src/include/Makefile (see around probes.h).
Will fix as per the attached.  Thanks for the report.
--
Michael

--B2Fp1kClZnUKLZyq
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="waitevent-include.patch"

diff --git a/src/include/Makefile b/src/include/Makefile
index 2d5242561c..a7ca277803 100644
--- a/src/include/Makefile
+++ b/src/include/Makefile
@@ -54,7 +54,7 @@ install: all installdirs
 	  $(INSTALL_DATA) $(srcdir)/$$dir/*.h '$(DESTDIR)$(includedir_server)'/$$dir || exit; \
 	done
 ifeq ($(vpath_build),yes)
-	for file in catalog/schemapg.h catalog/system_fk_info.h catalog/pg_*_d.h storage/lwlocknames.h utils/probes.h; do \
+	for file in catalog/schemapg.h catalog/system_fk_info.h catalog/pg_*_d.h storage/lwlocknames.h utils/probes.h utils/wait_event_types.h; do \
 	  $(INSTALL_DATA) $$file '$(DESTDIR)$(includedir_server)'/$$file || exit; \
 	done
 endif

--B2Fp1kClZnUKLZyq--

--OHFxu7UHTD/4xrjR
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmUwbg4ACgkQnvQgOdby
QH3skQ//S7+R42HKYNuyImZB/4UoFlVr/tW9cO/Kw5pB7rMkZTqnKXY5qgVp0k6C
1SK9uHv+sypmPm5EWajhbP6osclBczW6dWtVg87HIYn3hevhLuULTtF7HUdglHJP
e8VcXLlmF6Pi7VCK3myeFU+3ElPPytuJ3bUJ97mhXDH6G8SDWDg/MbjaWVJXScQe
vnRVYjy6BHyaqyPyqDoOerI3bu2FECCH6RNnMovg8muxbu9KApaLYlPfCIoCiH41
dUJV6FM9ct3gxDNmor4uAHa80I2XJNbEOvU/pfXBU8sYesbzcUXQ1bWk9mdk72qc
T6jGaAf5zUSTECLn0p2A/hK78n7qwX9TW7mo/ZkoxhA2ojqRvId/6OUHBhWoI7fo
kRz8mT7MEn3hcLgEKcCebGnGUb+/cet5YsDBvM1Zwj4r9qp8lZ37mITQr1/FzCrz
QlCD/S2VfkEcbe6BxnCQ8nfHie6C6OeDxLzuqVqmMAPvXvITeWAFVhLKSQMFANY7
5L38At2Y+rcbQyDDwW03K5Coto6cv+/3FZhUjNxzkjl8LPLIibwl4azUsSTwmmXD
5xH3N6RJqqvgs7tnN/iRuGaf1/ncZQClQ+sg67TsJw8nMgOa4OJsaEq8FmHZpbZp
4o37J/7vFvnq7aaBOxfe06UqGUmQh1r9flJbmQqcD99hxZbtxdU=
=f0ov
-----END PGP SIGNATURE-----

--OHFxu7UHTD/4xrjR--