Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qxXNl-001YV4-8V for pgsql-committers@arkaria.postgresql.org; Mon, 30 Oct 2023 18:53:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qxXNj-00GBiY-Jx for pgsql-committers@arkaria.postgresql.org; Mon, 30 Oct 2023 18:52:59 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qxXNj-00GBiE-8D for pgsql-committers@lists.postgresql.org; Mon, 30 Oct 2023 18:52:59 +0000 Received: from momjian.us ([72.94.173.45]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qxXNg-0035f2-JH; Mon, 30 Oct 2023 18:52:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=momjian.us; s=2023062407; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description; bh=t7pbweM79R+OfEFKVI/j81f5zsIwflr2NfKzRkFVwKI=; b=NqH9T n0GMrj5DCQSk/6t8UBoi6ohniLpeiTGITQmA3QYevjq3McK5dcYVZ3ryFMImqYzTDYqSJuUC5VN79 cVG63O28iSad9CY24Xri5RQVon3bAbJVcUjYo4UZPY1Hv2PeEgyrHdJOS8B4x6b+lpxH6gi1RTlFM PXcIU4lJPno8mrPtTXLzA2paa/T03NcHDAuoNtaehU+80Jwn6bSXDidQL9n87a7rIVSG8raCQAvlJ 8wuj6Gx8Z9L0/8aYPo3r4gJ5+PQfaj75xD4Txy0UuGOJVOmgxADjoktjpYTyfbaJMcLbnetYo55r8 3EmiYR77Gvr8ritrdKT/ZMpMduNwg==; Received: from bruce by momjian.us with local (Exim 4.96) (envelope-from ) id 1qxXNf-00GcFW-1S; Mon, 30 Oct 2023 14:52:55 -0400 Date: Mon, 30 Oct 2023 14:52:55 -0400 From: Bruce Momjian To: Michael Paquier Cc: Alexander Korotkov , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Teach contrib/amcheck to check the unique constraint violation Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Oct 30, 2023 at 04:17:52PM +0900, Michael Paquier wrote: > Hi Alexander, > > On Fri, Oct 27, 2023 at 09:21:50PM +0000, Alexander Korotkov wrote: > > Teach contrib/amcheck to check the unique constraint violation > > > > Add the 'checkunique' argument to bt_index_check() and bt_index_parent_check(). > > When the flag is specified the procedures will check the unique constraint > > violation for unique indexes. Only one heap entry for all equal keys in > > the index should be visible (including posting list entries). Report an error > > otherwise. > > > > pg_amcheck called with the --checkunique option will do the same check for all > > the indexes it checks. > > koel is unhappy with the indentation done in this commit. See the > parts about verify_nbtree.c and pg_amcheck.c: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=koel&dt=2023-10-30%2007%3A04%3A04 Thanks, ran pgindent fix commits de64268561 and 5ae2087202a. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.