Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6v9t-0039Xq-9X for pgsql-committers@arkaria.postgresql.org; Sat, 25 Nov 2023 16:05:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1r6v9r-003GJ1-TE for pgsql-committers@arkaria.postgresql.org; Sat, 25 Nov 2023 16:05:27 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6v9r-003GIp-Lp for pgsql-committers@lists.postgresql.org; Sat, 25 Nov 2023 16:05:27 +0000 Received: from momjian.us ([72.94.173.45]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6v9p-007Jf9-2i for pgsql-committers@postgresql.org; Sat, 25 Nov 2023 16:05:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=momjian.us; s=2023062407; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description; bh=O+Vlp4lqzI89jNMvTFwy0Rg08+gOZUi6DmRS4HBC/WE=; b=KtqWP hbdBkVEEiKUiVJZc5j/mLurL82dBhQks7D9cVHZES+aY3i6BpUol1AlMcckB9ZnB1zG9Ita+Ugekp 3sKj6MmHweuKvrjWonASFmClWMmIkLppfpx5BwgkuXBBHA3dI5aAhecjFsIv+/WsVA97eT0I3tsLI n1mWxAidFs8JQLW3GLdzq7s2LnOvqruzBBfPXkN/SfwKyRqSkOAZc/VxWK+VYAAVL8kUO8uaXAYEt YYUp10Gq02PNlTmbQGBFAHMspaRj3m9UhPv9KqJFDzBYsOy4sstWZGHpj8nmSFlsw0FBVlZI7O2Hx Jas4K0AjsNiLbE+zXRqT/rVTbdqUw==; Received: from bruce by momjian.us with local (Exim 4.96) (envelope-from ) id 1r6v9n-0098Uk-1c; Sat, 25 Nov 2023 11:05:23 -0500 Date: Sat, 25 Nov 2023 11:05:23 -0500 From: Bruce Momjian To: Michael Paquier Cc: Peter Eisentraut , pgsql-committers@postgresql.org Subject: Re: [COMMITTERS] pgsql: Move pg_test_fsync from contrib/ to src/bin/ Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Apr 20, 2015 at 02:51:10PM +0900, Michael Paquier wrote: > On Mon, Apr 20, 2015 at 11:39 AM, Peter Eisentraut wrote: > > Move pg_test_fsync from contrib/ to src/bin/ > > Point of detail that I just noticed: wouldn't it be better to have a > header in pg_test_fsync.c of a shape similar to the other files. Now > there is only that: > /* > * pg_test_fsync.c > * tests all supported fsync() methods > */ > An idea what this gives as a patch is attached. This patch is old but the header is still missing, so patch applied to master. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.