pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Doc: un-break PDF build.
10+ messages / 3 participants
[nested] [flat]
* pgsql: Doc: un-break PDF build.
@ 2023-11-25 01:03 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 10+ messages in thread
From: Tom Lane @ 2023-11-25 01:03 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Doc: un-break PDF build.
Oversight in 5c4c7efad: gotta adjust the cell height for removal of
an entry. Per buildfarm.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/798394c6ccdada517c3508047a865d9994bfe25f
Modified Files
--------------
doc/src/sgml/gin.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: pgsql: Doc: un-break PDF build.
@ 2023-11-25 01:16 Bruce Momjian <bruce@momjian.us>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 10+ messages in thread
From: Bruce Momjian @ 2023-11-25 01:16 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org
Thanks, I missed that issue.
---------------------------------------------------------------------------
On Sat, Nov 25, 2023 at 01:03:11AM +0000, Tom Lane wrote:
> Doc: un-break PDF build.
>
> Oversight in 5c4c7efad: gotta adjust the cell height for removal of
> an entry. Per buildfarm.
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/798394c6ccdada517c3508047a865d9994bfe25f
>
> Modified Files
> --------------
> doc/src/sgml/gin.sgml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: pgsql: Doc: un-break PDF build.
@ 2023-11-25 14:57 Bruce Momjian <bruce@momjian.us>
parent: Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 10+ messages in thread
From: Bruce Momjian @ 2023-11-25 14:57 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org
On Fri, Nov 24, 2023 at 08:16:12PM -0500, Bruce Momjian wrote:
>
> Thanks, I missed that issue.
Can someone tell me how you saw that warning in the build farm? I don't
see it in with a make check or a build of the docs.
Attached is the patch that fixed it.
---------------------------------------------------------------------------
>
> On Sat, Nov 25, 2023 at 01:03:11AM +0000, Tom Lane wrote:
> > Doc: un-break PDF build.
> >
> > Oversight in 5c4c7efad: gotta adjust the cell height for removal of
> > an entry. Per buildfarm.
> >
> > Branch
> > ------
> > master
> >
> > Details
> > -------
> > https://git.postgresql.org/pg/commitdiff/798394c6ccdada517c3508047a865d9994bfe25f
> >
> > Modified Files
> > --------------
> > doc/src/sgml/gin.sgml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
>
> --
> Bruce Momjian <bruce@momjian.us> https://momjian.us
> EDB https://enterprisedb.com
>
> Only you can decide what is important to you.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
Attachments:
morerows.diff (text/x-diff, 731B) download
commit 798394c6cc
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: Fri Nov 24 20:02:53 2023 -0500
Doc: un-break PDF build.
Oversight in 5c4c7efad: gotta adjust the cell height for removal of
an entry. Per buildfarm.
diff --git a/doc/src/sgml/gin.sgml b/doc/src/sgml/gin.sgml
index be02966e77..5bd1efae92 100644
--- a/doc/src/sgml/gin.sgml
+++ b/doc/src/sgml/gin.sgml
@@ -126,7 +126,7 @@
<entry><literal>@@ (jsonb,jsonpath)</literal></entry>
</row>
<row>
- <entry morerows="1" valign="middle"><literal>tsvector_ops</literal></entry>
+ <entry valign="middle"><literal>tsvector_ops</literal></entry>
<entry><literal>@@ (tsvector,tsquery)</literal></entry>
</row>
</tbody>
* Re: pgsql: Doc: un-break PDF build.
@ 2023-11-25 15:50 Tom Lane <tgl@sss.pgh.pa.us>
parent: Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 10+ messages in thread
From: Tom Lane @ 2023-11-25 15:50 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: pgsql-committers@lists.postgresql.org
Bruce Momjian <bruce@momjian.us> writes:
> Can someone tell me how you saw that warning in the build farm? I don't
> see it in with a make check or a build of the docs.
Yeah, for some reason it only shows up when building PDFs.
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=alabio&dt=2023-11-25%2000%3A02%3A10
regards, tom lane
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: pgsql: Doc: un-break PDF build.
@ 2023-11-25 16:22 Bruce Momjian <bruce@momjian.us>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 10+ messages in thread
From: Bruce Momjian @ 2023-11-25 16:22 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org
On Sat, Nov 25, 2023 at 10:50:10AM -0500, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Can someone tell me how you saw that warning in the build farm? I don't
> > see it in with a make check or a build of the docs.
>
> Yeah, for some reason it only shows up when building PDFs.
>
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=alabio&dt=2023-11-25%2000%3A02%3A10
Odd, I don't see that here. Maybe I need an upgraded toolchain:
$ make postgres-A4.pdf 2>&1 | grep -v INFO
/usr/bin/xsltproc --nonet --path . --path . --stringparam pg.version '17devel' --stringparam img.src.path './' --stringparam paper.type A4 -o postgres-A4.fo stylesheet-fo.xsl postgres-full.xml
Making portrait pages on A4 paper (210mmx297mm)
/usr/bin/fop -fo postgres-A4.fo -pdf postgres-A4.pdf
[warning] /usr/bin/fop: JVM flavor 'sun' not understood
[WARN] FOUserAgent - Font "Symbol,normal,700" not found. Substituting with "Symbol,normal,400".
[WARN] FOUserAgent - Font "ZapfDingbats,normal,700" not found. Substituting with "ZapfDingbats,normal,400".
[WARN] PropertyMaker - span="inherit" on fo:block, but no explicit value found on the parent FO.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: pgsql: Doc: un-break PDF build.
@ 2023-11-25 16:26 Tom Lane <tgl@sss.pgh.pa.us>
parent: Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 10+ messages in thread
From: Tom Lane @ 2023-11-25 16:26 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: pgsql-committers@lists.postgresql.org
Bruce Momjian <bruce@momjian.us> writes:
> On Sat, Nov 25, 2023 at 10:50:10AM -0500, Tom Lane wrote:
>> Yeah, for some reason it only shows up when building PDFs.
>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=alabio&dt=2023-11-25%2000%3A02%3A10
> Odd, I don't see that here. Maybe I need an upgraded toolchain:
Hmm, I did see it here, using fop 2.5 and docbook 1.79.
regards, tom lane
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: pgsql: Doc: un-break PDF build.
@ 2023-11-25 16:34 Bruce Momjian <bruce@momjian.us>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 10+ messages in thread
From: Bruce Momjian @ 2023-11-25 16:34 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers
On Sat, Nov 25, 2023 at 11:26:16AM -0500, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > On Sat, Nov 25, 2023 at 10:50:10AM -0500, Tom Lane wrote:
> >> Yeah, for some reason it only shows up when building PDFs.
> >> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=alabio&dt=2023-11-25%2000%3A02%3A10
>
> > Odd, I don't see that here. Maybe I need an upgraded toolchain:
>
> Hmm, I did see it here, using fop 2.5 and docbook 1.79.
Uh, I have on Debian 12 (bookworm):
fop is 2.8
ii fop 1:2.8-2 all XML formatter driven by XSL Formatting Objects (XSL-FO.) - app
ii libfop-java 1:2.8-2 all XML formatter driven by XSL Formatting Objects (XSL-FO.) - libs
docbook is 1.79
ii docbook 4.5-10 all standard SGML representation system for technical documents
ii docbook-dsssl 1.79-10 all modular DocBook DSSSL stylesheets, for print and HTML
ii docbook-xml 4.5-12 all standard XML documentation system for software and systems
ii docbook-xsl 1.79.2+dfsg-2 all stylesheets for processing DocBook XML to various output formats
ii docbook-xsl-doc-html 1.79.1-1 all stylesheets for processing DocBook XML files (HTML documentation)
Kind of odd I don't see it the error.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: pgsql: Doc: un-break PDF build.
@ 2023-11-25 19:14 Andrew Dunstan <andrew@dunslane.net>
parent: Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 10+ messages in thread
From: Andrew Dunstan @ 2023-11-25 19:14 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers
On 2023-11-25 Sa 11:34, Bruce Momjian wrote:
> On Sat, Nov 25, 2023 at 11:26:16AM -0500, Tom Lane wrote:
>> Bruce Momjian <bruce@momjian.us> writes:
>>> On Sat, Nov 25, 2023 at 10:50:10AM -0500, Tom Lane wrote:
>>>> Yeah, for some reason it only shows up when building PDFs.
>>>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=alabio&dt=2023-11-25%2000%3A02%3A10
>>> Odd, I don't see that here. Maybe I need an upgraded toolchain:
>> Hmm, I did see it here, using fop 2.5 and docbook 1.79.
> Uh, I have on Debian 12 (bookworm):
>
> fop is 2.8
> ii fop 1:2.8-2 all XML formatter driven by XSL Formatting Objects (XSL-FO.) - app
> ii libfop-java 1:2.8-2 all XML formatter driven by XSL Formatting Objects (XSL-FO.) - libs
>
> docbook is 1.79
> ii docbook 4.5-10 all standard SGML representation system for technical documents
> ii docbook-dsssl 1.79-10 all modular DocBook DSSSL stylesheets, for print and HTML
> ii docbook-xml 4.5-12 all standard XML documentation system for software and systems
> ii docbook-xsl 1.79.2+dfsg-2 all stylesheets for processing DocBook XML to various output formats
> ii docbook-xsl-doc-html 1.79.1-1 all stylesheets for processing DocBook XML files (HTML documentation)
>
> Kind of odd I don't see it the error.
>
What command are you invoking to build the docs? The default docs make
target doesn't build the PDFs - you have to build those explicitly.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: pgsql: Doc: un-break PDF build.
@ 2023-11-25 19:18 Bruce Momjian <bruce@momjian.us>
parent: Andrew Dunstan <andrew@dunslane.net>
0 siblings, 1 reply; 10+ messages in thread
From: Bruce Momjian @ 2023-11-25 19:18 UTC (permalink / raw)
To: Andrew Dunstan <andrew@dunslane.net>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; pgsql-committers
On Sat, Nov 25, 2023 at 02:14:11PM -0500, Andrew Dunstan wrote:
>
> On 2023-11-25 Sa 11:34, Bruce Momjian wrote:
> > On Sat, Nov 25, 2023 at 11:26:16AM -0500, Tom Lane wrote:
> > > Bruce Momjian <bruce@momjian.us> writes:
> > > > On Sat, Nov 25, 2023 at 10:50:10AM -0500, Tom Lane wrote:
> > > > > Yeah, for some reason it only shows up when building PDFs.
> > > > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=alabio&dt=2023-11-25%2000%3A02%3A10
> > > > Odd, I don't see that here. Maybe I need an upgraded toolchain:
> > > Hmm, I did see it here, using fop 2.5 and docbook 1.79.
> > Uh, I have on Debian 12 (bookworm):
> >
> > fop is 2.8
> > ii fop 1:2.8-2 all XML formatter driven by XSL Formatting Objects (XSL-FO.) - app
> > ii libfop-java 1:2.8-2 all XML formatter driven by XSL Formatting Objects (XSL-FO.) - libs
> >
> > docbook is 1.79
> > ii docbook 4.5-10 all standard SGML representation system for technical documents
> > ii docbook-dsssl 1.79-10 all modular DocBook DSSSL stylesheets, for print and HTML
> > ii docbook-xml 4.5-12 all standard XML documentation system for software and systems
> > ii docbook-xsl 1.79.2+dfsg-2 all stylesheets for processing DocBook XML to various output formats
> > ii docbook-xsl-doc-html 1.79.1-1 all stylesheets for processing DocBook XML files (HTML documentation)
> >
> > Kind of odd I don't see it the error.
> >
>
> What command are you invoking to build the docs? The default docs make
> target doesn't build the PDFs - you have to build those explicitly.
I showed it previously in this thread:
$ make postgres-A4.pdf 2>&1 | grep -v INFO
/usr/bin/xsltproc --nonet --path . --path . --stringparam pg.version '17devel' --stringparam img.src.path './' --stringparam paper.type A4 -o postgres-A4.fo
+stylesheet-fo.xsl postgres-full.xml
Making portrait pages on A4 paper (210mmx297mm)
/usr/bin/fop -fo postgres-A4.fo -pdf postgres-A4.pdf
[warning] /usr/bin/fop: JVM flavor 'sun' not understood
[WARN] FOUserAgent - Font "Symbol,normal,700" not found. Substituting with "Symbol,normal,400".
[WARN] FOUserAgent - Font "ZapfDingbats,normal,700" not found. Substituting with "ZapfDingbats,normal,400".
[WARN] PropertyMaker - span="inherit" on fo:block, but no explicit value found on the parent FO.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: pgsql: Doc: un-break PDF build.
@ 2023-11-25 20:12 Bruce Momjian <bruce@momjian.us>
parent: Bruce Momjian <bruce@momjian.us>
0 siblings, 0 replies; 10+ messages in thread
From: Bruce Momjian @ 2023-11-25 20:12 UTC (permalink / raw)
To: Andrew Dunstan <andrew@dunslane.net>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; pgsql-committers
On Sat, Nov 25, 2023 at 02:18:43PM -0500, Bruce Momjian wrote:
> I showed it previously in this thread:
>
> $ make postgres-A4.pdf 2>&1 | grep -v INFO
> /usr/bin/xsltproc --nonet --path . --path . --stringparam pg.version '17devel' --stringparam img.src.path './' --stringparam paper.type A4 -o postgres-A4.fo
> +stylesheet-fo.xsl postgres-full.xml
> Making portrait pages on A4 paper (210mmx297mm)
> /usr/bin/fop -fo postgres-A4.fo -pdf postgres-A4.pdf
> [warning] /usr/bin/fop: JVM flavor 'sun' not understood
> [WARN] FOUserAgent - Font "Symbol,normal,700" not found. Substituting with "Symbol,normal,400".
> [WARN] FOUserAgent - Font "ZapfDingbats,normal,700" not found. Substituting with "ZapfDingbats,normal,400".
> [WARN] PropertyMaker - span="inherit" on fo:block, but no explicit value found on the parent FO.
Oops, please disregard my report. I was able to reproduce the failure
just now. I must have incorrectly applied the patch in testing.
Mystery solved.
I am not sure if I am going to build the PDF for every doc patch, but at
least I can do it when I am concerned, and know how to reproduce it if
the buildfarm fails.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
^ permalink raw reply [nested|flat] 10+ messages in thread
end of thread, other threads:[~2023-11-25 20:12 UTC | newest]
Thread overview: 10+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-11-25 01:03 pgsql: Doc: un-break PDF build. Tom Lane <tgl@sss.pgh.pa.us>
2023-11-25 01:16 ` Bruce Momjian <bruce@momjian.us>
2023-11-25 14:57 ` Bruce Momjian <bruce@momjian.us>
2023-11-25 15:50 ` Tom Lane <tgl@sss.pgh.pa.us>
2023-11-25 16:22 ` Bruce Momjian <bruce@momjian.us>
2023-11-25 16:26 ` Tom Lane <tgl@sss.pgh.pa.us>
2023-11-25 16:34 ` Bruce Momjian <bruce@momjian.us>
2023-11-25 19:14 ` Andrew Dunstan <andrew@dunslane.net>
2023-11-25 19:18 ` Bruce Momjian <bruce@momjian.us>
2023-11-25 20:12 ` Bruce Momjian <bruce@momjian.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox