Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 30 Nov 2023 14:43:03 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <dgustafsson@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Read include/exclude commands for dump/restore from file
Message-ID: <ZWgg5xim2CXQcfmh@paquier.xyz>
References: <E1r8LRQ-007oSu-3G@gemulon.postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="3T+P3ftEIXHZFMCZ"
Content-Disposition: inline
In-Reply-To: <E1r8LRQ-007oSu-3G@gemulon.postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/ZWgg5xim2CXQcfmh%40paquier.xyz>
Precedence: bulk


--3T+P3ftEIXHZFMCZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Daniel,

On Wed, Nov 29, 2023 at 02:21:28PM +0000, Daniel Gustafsson wrote:
> Read include/exclude commands for dump/restore from file
>=20
> When there is a need to filter multiple tables with include and/or exclude
> options it's quite possible to run into the limitations of the commandlin=
e.
> This adds a --filter=3DFILENAME feature to pg_dump, pg_dumpall and pg_res=
tore
> which is used to supply a file containing object exclude/include commands
> which work just like their commandline counterparts. The format of the fi=
le
> is one command per row like:
>=20
>     <command> <object> <objectpattern>
>=20
> <command> can be "include" or "exclude", <object> can be table_data, index
> table_data_and_children, database, extension, foreign_data, function, tab=
le
> schema, table_and_children or trigger.
>=20
> This patch has gone through many revisions and design changes over a long
> period of time, the list of reviewers reflect reviewers of some version of
> the patch, not necessarily the final version.

mamba is unhappy with the new filter.c:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dmamba&dt=3D2023-1=
1-30%2002%3A53%3A25

For instance:
filter.c: In function 'filter_get_keyword':
filter.c:188:17: error: array subscript has type 'char' [-Werror=3Dchar-sub=
scripts]
188 |  while (isspace(*ptr))
    |                 ^
--
Michael

--3T+P3ftEIXHZFMCZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmVoIOcACgkQnvQgOdby
QH01Dg//TLUJpb5ws8JcD6+rIxGqFrSfbnFNaxnxrMuXrOy4sU1lvOj8KAFp5Tjt
FNg9HZGhuWgpVZeuXguxDDXISD8Q7nw5e1xI5ZKFlnF8T4/ztwXtxnS8qukPqqu7
hLJ8QHMcNz/G9qTZxln6+5bhGtbR3ls43nUNNinxUjiWJ4hsVQGZw1/anWHPn2eL
EqFPa2uY1KWZO3WW/QO7scA0qWqZF2wTVnIaNkF4Ef0Pp0vr/8j2emI2LA90P9le
dpZQLJr7No3c5FbdfqGgwTuxCDjvfklAG23juZMMEY4p4ouf/M614UVrjJsvZUA0
kLS3RhBTjGTtOmWOvLITVTx//hzwdX0xOrS5gKOuuT8bNg55jIUzAlNoB5a7cvcK
w4xSEvwovipoVhlZkkVfK7MxG/pKYuvWA24m+GIjKwWUIRwcWNIpmGczF+qLpaNf
AYS6ElWQ4wzPBBn6C+LxMEbZVr41eqelZko6J74DwgQV8iajpSRdJmdvL6tBGVtb
5DiJLxa3xOLFNjCNEIB4vrSOhmcxTopQcbPDymZC3Na/L9R+86w3nvlULM4+eawF
fsTIlpNKo9Ou9MyK1G6ziBk9n8RiUmjsSY5reCmzbRU3pekwcALIUiKf6l/zId0O
2XhEvc8I7+MifqMPbGTzBRcZ7Q1ca0N1OndaAkrxUJ1jlMsejoc=
=BvJm
-----END PGP SIGNATURE-----

--3T+P3ftEIXHZFMCZ--