Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rFkxs-00Brpw-Fj for pgsql-committers@arkaria.postgresql.org; Wed, 20 Dec 2023 01:01:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rFkxq-006uYm-Pa for pgsql-committers@arkaria.postgresql.org; Wed, 20 Dec 2023 01:01:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rFkxq-006uYd-I1 for pgsql-committers@lists.postgresql.org; Wed, 20 Dec 2023 01:01:34 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rFkxo-00CsfX-Al for pgsql-committers@lists.postgresql.org; Wed, 20 Dec 2023 01:01:33 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id ED3A4320047A; Tue, 19 Dec 2023 20:01:29 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 19 Dec 2023 20:01:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1703034089; x=1703120489; bh=Uin4MHcZkl +E/o7eYOC1Ns9YGFLMTiFiVQ9qkzICDj0=; b=qwzVaVYWDEm6+r8e4ZXHp3bYV2 7t5MPy4+dMtzN8stoxCAdZE1UbksWk4kesVzKGY2oNURiFskJZv9kJyqq16IDUcD BXGJumQbup9E14FWeWBMzhZIXLoVR/4NgYWTEBp3CncsiiaNpq1hROVQhTnZHUHg NoK8LMyxy1QgxoWeus2KpaiSa2tEs8AbCnuQm6HIq3H27SOxR5Ijz5np3ztox59+ CCVAdCxLvMdcCkp7weB5nIsNTb1iL/Nc9tfeRIiDgM0/j31whVumJbIWonSLQHjQ kbn/2cX06mJEJT/6adM6+6Jo8qMK4RSiJkSjvt40QFfHNyQqfv/1Nx+4y7UQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1703034089; x=1703120489; bh=Uin4MHcZkl+E/o7eYOC1Ns9YGFLM TiFiVQ9qkzICDj0=; b=oDYPukEC/I+oyVFfZLhsN/NQ1xb7a6TMxs3De69NOIZN fmTdxeeeK6iJZSruhp0Qkvo67Jj4jkVV8adBtQdyzsfUvQRKGHq/i6dDjI4ZCjWW ky4NtT+5klrLOVXhajXSWAe8ZQPwNdzbELLA7zNDORKdXArLUSBtnQskSnRKhoMi NbFpglq8r2MJo/cKW4Lr/8zCixK4cUNnzhzF1VeNs2Oikea7rLjtFQK0a/0hR4i5 RaNmjMSzsoikPxH/FKitHi02z3NOaxjb/g6BRkjJSihByGuw9I9IFHhVYVytWkhz 2frQ5VLjeTTgLOmEGc94tFdE+etKPevB+XmjEAXuKg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdduuddgvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddunecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepgfehhefgudefudfgfeelgeei ffegfefhkeefffdvheefuddtheetgeelteevkeetnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 19 Dec 2023 20:01:27 -0500 (EST) Date: Wed, 20 Dec 2023 10:01:16 +0900 From: Michael Paquier To: Robert Haas Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Move src/bin/pg_verifybackup/parse_manifest.c into src/common. Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lnGPxrmpMX+QflU0" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --lnGPxrmpMX+QflU0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 19, 2023 at 08:29:18PM +0000, Robert Haas wrote: > Move src/bin/pg_verifybackup/parse_manifest.c into src/common. >=20 > This makes it possible for the code to be easily reused by other > client-side tools, and/or by the server. >=20 > Patch by me. Review of this patch in particular by at least Peter > Eisentraut; reviewers for the patch series in general include Dilip > Kumar, Andres Fruend, David Steele, =C1lvaro Herrera, and Jakub Wartak. Worth noting that this has forgotten to update @pgcommonallfiles in Mkvcbuild.pm so this would have failed a build with src/build/msvc/. Or you counted on me here, relying on the scripts to be gone? ;p -- Michael --lnGPxrmpMX+QflU0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmWCPNwACgkQnvQgOdby QH0Sow//atqYYK5TMcxAD9qeqtlktFSr3OKZnaEg4Qtnxc2gAW9bwN/uODi2ie41 pNuHa+4I6n2Lf3kajBWLNMS22XiYkZb7FUYXpbLzIaGMsg1CEQ32Sd4q9LrZXUav ZL9UroAYGd1TmE5RORU2UEuaBGSbHmvYq8/GDomV9M7zFpdMKXKSD6OKGI+P4aZY yO+La+x/UP7O38+3cp7DoY1WjLXpeh3L349u1raOLxRhCpv20loQ8TvTBIf8GG+A 6TOEoL49cwGsT0guEXBCyG9LjWw3vWP+1JyVAxQh1YBXP7OX2GJ7NFdak4AKFBDU pPYNQvDXYjTrMykKHFrdNf4ShGqs7Vosd5QpBA+n8USH9TEhupXWHsg5yc/FhOgO 76Sjva6WHHIgZM/LvqmqDPf2TYsjuqZ4lAR0b302PkorRHG+Z56GpPylARgOhpdq vFUhtK04ZJ+IbI3d38m1GL9B5dc1NjDo8DwyMDweCDqOwZB47wd6cobfFSvNzZaL cLxaEEVnqwJI2vwtZRNJzNhX/WCWngHd58203OfKLVzu2Ug8F4VbDsdEymwUODmp RdDPZ1bIL1402iiawlvXSynVc8ziPz1gNWshdXj+fABTqSbGyerIgzGrraYi1FMH u1LPVllgLB+GgLNK/X6uqyBLwbyRrbIB6artvsXQqfkA3WX5hzQ= =KP+v -----END PGP SIGNATURE----- --lnGPxrmpMX+QflU0--