Feedback-ID: i0fe9450f:Fastmail
Date: Sat, 5 Apr 2025 17:24:41 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Jeff Davis <pgsql@j-davis.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pg_upgrade: Fix inconsistency in memory freeing
Message-ID: <Z_DoyQRKsq6XnS_F@paquier.xyz>
References: <E1tnozS-000424-2y@gemulon.postgresql.org>
 <e852442da35b4f31acc600ed98bbee0f12e65e0c.camel@j-davis.com>
 <Z-huFcVLtZVp2q51@paquier.xyz>
 <8e540416ec3f0a5850264505bf4c72844d32176a.camel@j-davis.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="9nJibBiq3WRq2N5l"
Content-Disposition: inline
In-Reply-To: <8e540416ec3f0a5850264505bf4c72844d32176a.camel@j-davis.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Z_DoyQRKsq6XnS_F%40paquier.xyz>
Precedence: bulk


--9nJibBiq3WRq2N5l
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Mar 30, 2025 at 11:12:20AM -0700, Jeff Davis wrote:
> Why pg_strdup() the "NULL" at all in that case? Usually I see that done
> so that there doesn't need to be a conditional when freeing, but here
> there's a conditional anyway.
>=20
> Perhaps something like the attached?

I am back to a laptop, and just noticed that you have applied
f4e51eab4eb0 into the tree to take care of this issue, affecting only
HEAD.  Why didn't you do a backpatch of this commit down to v16?
That's down to where 2a083ab807db has been applied.
--
Michael

--9nJibBiq3WRq2N5l
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmfw6MkACgkQnvQgOdby
QH1iMg/+KL0s3FgjDMjKdjEiw+3g2Td1UQ7C5i2H01vro2Hk5CadKiOkurF3Y+rr
5xWxBSp1WtO9fgdEOqPPxZuYJxUoBNIHxel3fsfMF5MKbjxG5HJj8YCpOJVohOjE
yvmBml/VJcgHAnkRG6JAJK7fQVwhX5Rl/+jLG2HvvQbnqmWd4fFoAuyw+f23ACB8
nguxXX/zKNdlT+np5FsefvU5x9ql7XnBAl8uZnrath05hhg+wIixFm/W46Ln4j/L
fSqA2bxQk81/0o7mYclZQYwnwgnvmn/XFrsDxGcfg5kpIr1OoFsBEm4PQsg0yhr/
N2v3cGuMfTqYaEDXkRo8ZRWSsqE9Sb88RnstrXWg5xgmVsYDl1F+Ax1IynAwvoWb
olZFatIpeUyaSrwUegitwpzi9rA5U1sQd+LKhiavmqPUVtDZXuC7KATM0uXOAz3J
jqd/TaJF72ZmtMeFUk2fM2s2pHTWpl5Y+FgUGVJCmh/Gd8Mrobw7ef1QGiZDk+7w
g3GzYqw9a+EEYlyDjva0iq4e0ZBPIYA72OOrlc5bUnr0QREEJGgFiqtoR5zD9MVT
JPecXrESLdgpL1I64lzNpY3yAWx0wUuYdT0j+o22OPS+apg+cw/WBlo0a2EpipOB
YW7GGTdivyX0s0VzSTklFbvak2S2BLPA4RGNND6ONlRAKeh0lYg=
=yAiK
-----END PGP SIGNATURE-----

--9nJibBiq3WRq2N5l--