Date: Sat, 5 Apr 2025 08:13:12 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: =?iso-8859-1?Q?=C1lvaro?= Herrera <alvherre@alvh.no-ip.org>,
	Nathan Bossart <nathan@postgresql.org>,
	pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Prevent redeclaration of typedef TocEntry.
Message-ID: <Z_EsaH5Mt4BYINTQ@nathan>
References: <202504042140.qo66ggw6wzsz@alvherre.pgsql>
 <2408468.1743833410@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2408468.1743833410@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/Z_EsaH5Mt4BYINTQ%40nathan>
Precedence: bulk

Sorry, I missed this one last night.

On Sat, Apr 05, 2025 at 02:10:10AM -0400, Tom Lane wrote:
> =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org> writes:
>> ... AFAICS we could move both DefnDumperPtr and
>> DataDumperPtr typedefs to pg_backup_archiver.h, together with struct
>> _tocEntry (the only place where they are used), and we'd have less of a
>> mess here.  Then we don't need struct TocEntry in pg_backup.h anymore.
> 
> +1 for this simplification.

This is a better fix.  Thanks for taking care of it.

-- 
nathan