pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Rename argument in pg_get_process_memory_contexts().
4+ messages / 4 participants
[nested] [flat]
Commits from this thread:
2025-04-09 ef366b7d7e Perform missed catversion bump
* pgsql: Rename argument in pg_get_process_memory_contexts().
@ 2025-04-08 21:22 Daniel Gustafsson <dgustafsson@postgresql.org>
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Gustafsson @ 2025-04-08 21:22 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Rename argument in pg_get_process_memory_contexts().
During development the third argument to pg_get_process_memory_contexts
was a retry count, but it was changed to a timeout instead. The param
name was accidentally left in pg_proc.dat though. Fix by renaming to
the correct parameter name.
Author: Fujii Masao <masao.fujii@oss.nttdata.com>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discussion: https://postgr.es/m/3eb40b3e-45c7-426a-b7f8-81f7d05a9b53@oss.nttdata.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/c57971034e69ca5705ac2be893a80ea82aca978b
Modified Files
--------------
src/include/catalog/pg_proc.dat | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: Rename argument in pg_get_process_memory_contexts().
@ 2025-04-09 00:49 David Rowley <dgrowleyml@gmail.com>
parent: Daniel Gustafsson <dgustafsson@postgresql.org>
0 siblings, 1 reply; 4+ messages in thread
From: David Rowley @ 2025-04-09 00:49 UTC (permalink / raw)
To: Daniel Gustafsson <dgustafsson@postgresql.org>; +Cc: pgsql-committers@lists.postgresql.org
On Wed, 9 Apr 2025 at 09:22, Daniel Gustafsson
<dgustafsson@postgresql.org> wrote:
> Rename argument in pg_get_process_memory_contexts().
> src/include/catalog/pg_proc.dat | 2 +-
I think this should have done a catversion bump.
I suspect we'll get one soon enough, but you never know...
David
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: Rename argument in pg_get_process_memory_contexts().
@ 2025-04-09 04:02 Michael Paquier <michael@paquier.xyz>
parent: David Rowley <dgrowleyml@gmail.com>
0 siblings, 1 reply; 4+ messages in thread
From: Michael Paquier @ 2025-04-09 04:02 UTC (permalink / raw)
To: David Rowley <dgrowleyml@gmail.com>; +Cc: Daniel Gustafsson <dgustafsson@postgresql.org>; pgsql-committers@lists.postgresql.org
On Wed, Apr 09, 2025 at 12:49:52PM +1200, David Rowley wrote:
> On Wed, 9 Apr 2025 at 09:22, Daniel Gustafsson
> <dgustafsson@postgresql.org> wrote:
> > Rename argument in pg_get_process_memory_contexts().
>
> > src/include/catalog/pg_proc.dat | 2 +-
>
> I think this should have done a catversion bump.
Yes, the catversion should be bumped for an attribute rename in a
function.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: Rename argument in pg_get_process_memory_contexts().
@ 2025-04-09 06:41 Daniel Gustafsson <daniel@yesql.se>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Gustafsson @ 2025-04-09 06:41 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: David Rowley <dgrowleyml@gmail.com>; pgsql-committers@lists.postgresql.org
> On 9 Apr 2025, at 06:02, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Wed, Apr 09, 2025 at 12:49:52PM +1200, David Rowley wrote:
>> On Wed, 9 Apr 2025 at 09:22, Daniel Gustafsson
>> <dgustafsson@postgresql.org> wrote:
>>> Rename argument in pg_get_process_memory_contexts().
>>
>>> src/include/catalog/pg_proc.dat | 2 +-
>>
>> I think this should have done a catversion bump.
>
> Yes, the catversion should be bumped for an attribute rename in a
> function.
Agreed, sorry about that, will fix.
--
Daniel Gustafsson
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2025-04-09 06:41 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-04-08 21:22 pgsql: Rename argument in pg_get_process_memory_contexts(). Daniel Gustafsson <dgustafsson@postgresql.org>
2025-04-09 00:49 ` David Rowley <dgrowleyml@gmail.com>
2025-04-09 04:02 ` Michael Paquier <michael@paquier.xyz>
2025-04-09 06:41 ` Daniel Gustafsson <daniel@yesql.se>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox