Date: Wed, 17 Apr 2024 15:42:28 +0200
From: Christoph Berg <myon@debian.org>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: meson: Add initial version of meson based build system
Message-ID: <Zh_RxBKH86OEsccE@msg.df7cb.de>
References: <E1obF3v-001S9d-UD@gemulon.postgresql.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1obF3v-001S9d-UD@gemulon.postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/Zh_RxBKH86OEsccE%40msg.df7cb.de>
Precedence: bulk

Re: Andres Freund
> https://git.postgresql.org/pg/commitdiff/e6927270cd18d535b77cbe79c55c6584351524be

This commit broke VPATH builds when the original source directory
contains symlinks.

The $PWD is /home/myon/postgresql/pg/master, but the actual directory
is /home/myon/projects/postgresql/pg/postgresql. When I
  mkdir build; cd build && ../configure
there, I get a build directory missing a lot of files/directories:

$ ls build/
config.log  config.status*  GNUmakefile  meson.build  src/
$ ls build/src/
backend/  include/  interfaces/  Makefile.global  Makefile.port@
$ ls build/src/backend/
port/

Given there are no other changes I think this bit is at fault:

> Modified Files
> --------------
> configure.ac                                       |    6 +

+# Ensure that any meson build directories would reconfigure and see that
+# there's a conflicting in-tree build and can error out.
+if test "$vpath_build"="no"; then
+  touch meson.build
+fi

Christoph