Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rup1q-007qnN-BW for pgsql-committers@arkaria.postgresql.org; Thu, 11 Apr 2024 07:39:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rup1o-00Eb3k-55 for pgsql-committers@arkaria.postgresql.org; Thu, 11 Apr 2024 07:39:24 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rup1m-00Eb2I-Hm for pgsql-committers@lists.postgresql.org; Thu, 11 Apr 2024 07:39:23 +0000 Received: from fhigh8-smtp.messagingengine.com ([103.168.172.159]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rup1j-002JV3-Fk for pgsql-committers@lists.postgresql.org; Thu, 11 Apr 2024 07:39:21 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfhigh.nyi.internal (Postfix) with ESMTP id C0D6011400D0; Thu, 11 Apr 2024 03:39:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 11 Apr 2024 03:39:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1712821157; x=1712907557; bh=STXoW4NVws LDBRciGXTFH4VdcZBalm/wcXyEOTdA4d0=; b=Ld6q3/6Tn3Yf5+Qqm1oxYA/GNj 0Ie5giQv9R6JLGb2NrWDw3Kz/tslCjwZQSFd0y2nYv6LwA7RuDT1rLXE+FBzb987 ntvpXaf2USsHxQzS4DaNO+JcpIBszlT62doOm7lPdoSjSDVd3rnS9dMUynZd+w+9 h11le4JDKTONvPHAx+tiXlJOFKz5dl6gWWj3SAdRhhzGNvkUkzjqmybGDGegJ0y6 oh4OzOOZ58/UA+EJUKHn3gPP/MoPJPtSx63vmmtTxI0SLrLFAOkhNFD0hVOMuxWA DD7HQXJGLC5n+Klhk0pxyoeAsr6EvaIzaT6Rc2TfbnHRWQt75PSxGt6eHD/A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1712821157; x=1712907557; bh=STXoW4NVwsLDBRciGXTFH4VdcZBa lm/wcXyEOTdA4d0=; b=BNfxYDIuzHfs+ylGcI//C+D154jE1yZEFLJrQqO7z5/G VIT7eToTxBw9uWjWRrk7O+Vxa7RejBx72DPdJAe3kWkosyu8dVMOKzfmCv1ZjeaK e1OQOk/zL8w8Jbqz/+aAW22gbY+yUkdzd6Mv63Jg9nVq1tEfF+eygkQaYwq41oXo 66I/FFV7gR4LIzkJ5+4cr3ic7qddmgoz1aCNseEe/kCgOuOdJmN3CUxgF7xC+wMN bVzr70On41aeJKsQyM2tl+gQCBpK5fT5NHgDwi3yynSXq2PfDreV2VNEc6lGiieV WEXQBerBKA+wPpdgQ1DdY85Fd/LJIJgxZHDYySIvoA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudehjedguddukecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecufghrlhcuvffnffculdejtddmnecujfgurhepff fhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcurfgr qhhuihgvrhcuoehmihgthhgrvghlsehprghquhhivghrrdighiiiqeenucggtffrrghtth gvrhhnpeetleeifedufffhhfdtteelgeeggeffhfekueevteeigfduudevudetgfegiedv jeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmih gthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 11 Apr 2024 03:39:15 -0400 (EDT) Date: Thu, 11 Apr 2024 16:39:01 +0900 From: Michael Paquier To: Bharath Rupireddy Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Fix race leading to incorrect conflict cause in InvalidatePossib Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xI3fa7GLhos6hsXa" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --xI3fa7GLhos6hsXa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 11, 2024 at 12:38:06PM +0530, Bharath Rupireddy wrote: > I found a typo with the code added by this commit - we've used > XLogRecPtr/InvalidXLogRecPtr for xmins in place of > TransactionId/InvalidTransactionId. Attached a patch to fix this. Thanks for the report. Will fix. -- Michael --xI3fa7GLhos6hsXa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmYXk5UACgkQnvQgOdby QH2hyg/+I6aTMYTFyyqXOYn4D7+HPbY8HUMrvUDdjYmFhEfaPeNwkWmgNGtMrEng F5y/beMgdvBWPMEzL1nH6ivYVUZidHApBvrAkwd9jY5mEzdURcdbmTrSdUf3drzb J08lLTdC0XuoAdg76uej33Doo4VXTZJXKnq/E0HPHqb3K3Sgsf3cuY1SrrMTh5+r +4xrXejTY+4KA9aMkoUtrwc7pWRzvqooOaBEVGCi57pOjn1MKeCYWGxS++tdTjJs 4iZ5R/CDWcGF3exFtwxXcOQWESqm3XWWSGZh6ZDM4rwX7U/lwi8ketfVC5xYlj38 EjltVhZMdH5oDDmvtpHdd1MkFqNpyQ7a2StXnRxrmwuFO/BNsr43MiqHIXVHudbA WxnnIK1jvWaXiIJkBz65Y+On+lqYvmIEj2olVmiPcaSdgUD6BJw64sCn0pwXbmzX lZUT24xgOjO/092/s3orRu/kOFvUjYnK8/b+PChLTFqZX1YqT0K1e8P++Sj51psr DhUeAcH4/l+4wz1uM+yRfRM61cPRXxW169L7NHj6J7ewC9BD9GT/UEqIpac6Q4WM p3HCJ2PpgpR5GD9oJYdyA+Ubx4jCLEQUG9L8uks9qIgqxa3dHEd6w9kXFPu4AXRB PemYneeeep0fnwodgRNMkfGCLTya0Ywwjefi5sF8foEiy28DShM= =nRa3 -----END PGP SIGNATURE----- --xI3fa7GLhos6hsXa--