Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 15 Apr 2024 17:24:39 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Cc: pgsql-committers@lists.postgresql.org, peter@eisentraut.org
Subject: Re: pgsql: Move code for backend startup to separate file
Message-ID: <ZhzkRzrkKhbeQMRm@paquier.xyz>
References: <E1rm9Tv-004QMq-W9@gemulon.postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="DGy10/SJYjKyEMWQ"
Content-Disposition: inline
In-Reply-To: <E1rm9Tv-004QMq-W9@gemulon.postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/ZhzkRzrkKhbeQMRm%40paquier.xyz>
Precedence: bulk


--DGy10/SJYjKyEMWQ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Heikki,
(Peter E. in CC.)

On Mon, Mar 18, 2024 at 09:40:36AM +0000, Heikki Linnakangas wrote:
> Move code for backend startup to separate file
>=20
> This is code that runs in the backend process after forking, rather
> than postmaster. Move it out of postmaster.c for clarity.
>=20
> Reviewed-by: Tristan Partin, Andres Freund
> Discussion: https://www.postgresql.org/message-id/7a59b073-5b5b-151e-7ed3=
-8b01ff7ce9ef@iki.fi

--- a/src/include/postmaster/postmaster.h
+++ b/src/include/postmaster/postmaster.h
@@ -52,6 +52,8 @@ extern PGDLLIMPORT int postmaster_alive_fds[2];

 extern PGDLLIMPORT const char *progname;

+extern bool LoadedSSL;

This variable is missing a PGDLLIMPORT, it seems.

aafc05de1bf5 has missed a second one with MyClientSocket.  Both are
declared in postmaster.h.

The credit goes to Peter Eisentraunt for noticing these two who has
mentioned that to me on mastodon, while I am not able to parse
correctly a set of diffs.  This stuff can be spotted with a command
like this one:
src/tools/mark_pgdllimport.pl $(git ls-files *.h)

Thanks,
--
Michael

--DGy10/SJYjKyEMWQ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmYc5EcACgkQnvQgOdby
QH3/eA//RKPaXom0uYFr4aW3ZvYXjE+8CjSKFKqSc2RKlL1nE6mzi0Q0MsG66/fh
Y8IYtEw5OYhMfjo3ua+4y0NBBWF4rIGus01R4T1G+1Hxm8YnBJEltAC9/rLBkCsc
lpc+pZ7mlKstuJFAhB73BObbrPtMz2zLWgkbBzsAgio9lJoa1h3BsTcViuI1ZTts
ly95G1qtnRgX7Jx2EcJ8eVtp4JPC5LMvn1kokH6PquYr8HjsFmVEkpmRM7reIr8V
9oV60LuzoKlQsKM/VKpQulxdFKvDaRsOxXOqS+8h+8Tfr0iYjpYADfH7qXIoAB8Z
BKblKhr7QyuvjeBYVpYTqWGvktOkANDIKssJQTc9qm7NEwNz+RZh6ayhxehH2t5G
lNAbjiWNCJ2Jt+w3vIAMml0hAWabx0jw/mpn1J6+mpMDDtL0tAUaaFERvrz7hAjV
WDW6ztaM3JY+etf7d/ENOtF2ON/IarKmzpb4X4IY/uKOt/f0h+VyvzG1NaQBvaQ+
75gRdA7qv4cmVSIEhJ+bEExqrJN8/X8ReVVIA3dz+LLDf0EHy+lpdz/0w1z7BEEN
x+TKL34pRAgVw4qEyIZ0A5hvxc0YBurUTi6R7OOAgj1LDOQLmkGEQLlEX9NYCkYn
tSlLJR23NHe5a1V/lA/C4ELv9ZuBSqgaDcEOzhaSxiBEk9p4Pqo=
=b8vK
-----END PGP SIGNATURE-----

--DGy10/SJYjKyEMWQ--