Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 9 Jul 2024 08:52:25 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Joel Jacobson <joel@compiler.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Add pg_get_acl() to get the ACL for a database object
Message-ID: <Zox7ucEfBV0LJGW3@paquier.xyz>
References: <E1sPHWu-000GPc-0z@gemulon.postgresql.org>
 <3408967.1720107891@sss.pgh.pa.us>
 <f2688fb7-add6-43da-b1df-97312a451893@app.fastmail.com>
 <ZoctyZzE3UlUSer_@paquier.xyz>
 <f2539bff-64be-47f0-9f0b-df85d3cc0432@app.fastmail.com>
 <ZoukijRBef4m-VMO@paquier.xyz>
 <aa46ce00-17ad-4a87-938f-c66196800129@app.fastmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="deRP2W7QoP0Eqwvx"
Content-Disposition: inline
In-Reply-To: <aa46ce00-17ad-4a87-938f-c66196800129@app.fastmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Zox7ucEfBV0LJGW3%40paquier.xyz>
Precedence: bulk


--deRP2W7QoP0Eqwvx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jul 08, 2024 at 11:55:28AM +0200, Joel Jacobson wrote:
> Patch didn't apply to HEAD nor on top of any of the previous commits eith=
er,
> but I couldn't figure out why based on the .rej files, strange.
> I copy/pasted the parts from the patch to test it. Let me know if you nee=
d a
> rebased version of it, in case you will need to do the same, to save some=
 work.

Strange.  I have just downloaded v2 again.  `patch -p1` and `git am`
are both working here.

> Also noted the below in your last commit:
>=20
>     a6417078c414 has introduced as project policy that new features
>     committed during the development cycle should use new OIDs in the
>     [8000,9999] range.
>=20
>     4564f1cebd43 did not respect that rule, so let's renumber pg_get_acl()
>     to use an OID in the correct range.
>=20
> Thanks for the info!
> Will make sure to use the `src/include/catalog/renumber_oids.pl` tool
> for future patches.

No problem.  This is the kind of tweaks that are really easy to
forget.
--
Michael

--deRP2W7QoP0Eqwvx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmaMe7kACgkQnvQgOdby
QH0enw//f0R9+6tj73IqVtf7DDq+uFYZuqQe5BVSs7tBexELRsk4pvyJQVXdeWY7
+mPA+4rnr+fyXCsaMUjyyBTKRzecwBhSFAD8RYpUkkduT2LjkNnULKnrVkch6HVD
mAI7LN5RVA4Hohgz2pWa7fm/iZqqsm0CEKmpE6U2lx1YtYbb36zW4i93MA0gKvWc
lG8I4aTxNs1Uvrn6yUw0Xg9WCKdIOp97zWlie4DKSe1MI1XPPmYgGPa/bwiqXyiO
xSZJ628p8ZaLEe1EFndhbJJbfl8TIPhd9244AifgwOSBpj6emiz268BRa0l8+m3B
qt9BoXpC1l0RrJ7Aw3WTR/wr6/SFv6dLTBpVvuMfY1cTof+iSGezgX+TottpNymv
GJhzZcfj9KVK2rDvlg12QBwfeZAHBnmSG1eXRVPyUei0KKXc0b18uzV5NVxAcY7r
LJHAuw967+2bJiohuZU9ZuGen/mU2w9VGm7X9YwwpkAhQasMdY4XUJ4eGFmF5jGh
MIdmwGygca9ETPH3eFYJaSk43Mo5YORiFUG65ZfwTEo/bYApiC8J37v7ygod+LWB
fKgqiTIMESSzEE98ocfpZKrRlOna1XOA8sYWDYFDS3Zx2zyFwWgthBOU5GjPxxvN
Om6RngNQIZvOGb3WFk+Xflm4T1Tmb29bd7mXBSjt8jBYwSZS/gY=
=nrD5
-----END PGP SIGNATURE-----

--deRP2W7QoP0Eqwvx--