Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sbkG0-0016h9-DL for pgsql-hackers@arkaria.postgresql.org; Wed, 07 Aug 2024 17:15:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sbkFy-008kr8-Tf for pgsql-hackers@arkaria.postgresql.org; Wed, 07 Aug 2024 17:15:26 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sbkFy-008kqz-JT for pgsql-hackers@lists.postgresql.org; Wed, 07 Aug 2024 17:15:26 +0000 Received: from mail-io1-xd2d.google.com ([2607:f8b0:4864:20::d2d]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1sbkFw-003fGS-10 for pgsql-hackers@lists.postgresql.org; Wed, 07 Aug 2024 17:15:26 +0000 Received: by mail-io1-xd2d.google.com with SMTP id ca18e2360f4ac-81f8d644fe0so403339f.1 for ; Wed, 07 Aug 2024 10:15:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723050922; x=1723655722; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Y5vnRxcCtmzMP5qOk+TiPvy67YLl4Ql4DSlaeTAPYNs=; b=ZHXI4y1noAI0kptJ+ZnyHCmZG74OkSVDdjAmAdwG65rvhKsHCrpcCqvtRZuSPVvkIG LY0WmQh3kW40oY+/FZvEMYiR1QvXg22ANItSUgbvDjd5xVsXXdrMzXC7ei7tB3KFtGIm hzsdStzcf7lUBSDOAyDXVNAeaQdEw1imABFZLuwZLgY7Kktrms/dvbOHwx2+3fllRjtk NGqDz5cNtfDLka1Ek3pyzJdd6OYxaFtyy/2anQcNFPgpwC7znLSaJwg+CWTjdB1AAHCg 0FhOMo1+x4zG09YMC9oTqL74lMYtyHxtV7tYJTRnv4BxYfT9WUUYjm6f4zhHu7jy8BiL xFpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723050922; x=1723655722; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Y5vnRxcCtmzMP5qOk+TiPvy67YLl4Ql4DSlaeTAPYNs=; b=N0xBtPysLoyGR0fKi/G898PHbd7okCRFOd8jLio+hqbh1GjxjuoevJRqfgsJe79ZaI H2uHUoK8dLEB0mLdm01NvrRcdkZpmzZ/qcNPo5c9YbeDtK+vLr4bbyMQ3wdJ8wv4Xip9 +ubx4CG71vnUGR34wmSQHVT882Il/lPUO8g0IDu6dvW6IT7qJt5KOpjuL9oBQ84mLAWa LsynbWGFiSF9Ji1L95smSEJFmGHAKlrJQJA+gCicflrTwhsFBmfKGhNSEkXP2An+6BHi SrGo12BJC1zPN2mKZ3YsnUj3BotDpuHC6pxRI0DzImDtdcx6Emw2l07rMp5aTxVWoiT5 euVQ== X-Forwarded-Encrypted: i=1; AJvYcCXCmE5VHFOXUL52tXm4Zy4j2Ai6Bz4Y2OgZFi2DT7HdISWbwjR4ethirxIsRJTT4mZf+XRRaPSqmn9zLtIs@lists.postgresql.org X-Gm-Message-State: AOJu0YyVdejHyVS2Kq9tzrXpq4YOpvYfHX2+XPDZd3XGzSQTZ1+dgBa0 ggFtp/FTC27u3EhMEwpt+bAPWiwWZHQj2nYTHrYj4YBoz+y950bG X-Google-Smtp-Source: AGHT+IGlawJN/3UUxyukilLpw12Jt81SBkIn77JlQjraJjrtrEDv3BGIS+9HrTQkmUj0hxKVkT9rjg== X-Received: by 2002:a05:6602:6303:b0:81f:a3c3:abb2 with SMTP id ca18e2360f4ac-81fd43fe7e0mr2068986939f.15.1723050921871; Wed, 07 Aug 2024 10:15:21 -0700 (PDT) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4c8d6a34dd3sm2853383173.120.2024.08.07.10.15.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Aug 2024 10:15:21 -0700 (PDT) Date: Wed, 7 Aug 2024 12:15:19 -0500 From: Nathan Bossart To: Alvaro Herrera Cc: Robert Haas , Alexander Korotkov , pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: Introduce hash_search_with_hash_value() function Message-ID: References: <202408071708.x3p2fbmwyb2u@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202408071708.x3p2fbmwyb2u@alvherre.pgsql> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Aug 07, 2024 at 01:08:35PM -0400, Alvaro Herrera wrote: > On 2024-Aug-07, Robert Haas wrote: >> I really wish there was some way to fix commit messages. I had a typo >> in mine today, too. > > We could use git notes. The UI is a bit inconvenient (they have to be > pushed and pulled separately from commits), but they seem useful enough. Yeah, I spend a lot of time on commit messages because they're pretty much written in stone once pushed. I'd definitely use git notes to add errata, follow-up commits that fixed/reverted things, etc. -- nathan