Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sktzW-003erF-Dy for pgsql-committers@arkaria.postgresql.org; Sun, 01 Sep 2024 23:28:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sktzV-003oPS-Fw for pgsql-committers@arkaria.postgresql.org; Sun, 01 Sep 2024 23:28:17 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sktzU-003oPK-A4 for pgsql-committers@lists.postgresql.org; Sun, 01 Sep 2024 23:28:17 +0000 Received: from fhigh1-smtp.messagingengine.com ([103.168.172.152]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sktzR-000CR2-Gr for pgsql-committers@lists.postgresql.org; Sun, 01 Sep 2024 23:28:15 +0000 Received: from phl-compute-01.internal (phl-compute-01.nyi.internal [10.202.2.41]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 19B4211401C0; Sun, 1 Sep 2024 19:28:12 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-01.internal (MEProxy); Sun, 01 Sep 2024 19:28:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1725233292; x=1725319692; bh=X9mqXneelr wgIkX8rnBZnwamGQ+fJY/lFI51wA1rhUk=; b=HaxEb85SEaweYl++L8c+LtYGY2 p/82k6F3/6DyLSWKNG5ormHLsdPGNfG0/kbbtrrfq3OXZ7gBJCMgP5VS9Mzr72Kp aadvS/9YfrGB9w+qvMy6dco4bJsdFFgza+WqzhSaQtBKqCb1yjKIdErwcMqJv0ep wRh6pugRxWKU+551jG7f516lcymkBdfdBQnPedcsO1cdGRh0jH9Hj/hFgiKQEkYC ITHPpZX7oMBNmuz2sioyZ+KN8zRjhSyuhjrM6kd1FR3+Og1P4FcjrAAHMTThiB2I twJum8UXALesNWHYn82JGtu2QxTYcAj3tkgZXwvMGFLFW2RcvRNFCABObUhQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1725233292; x=1725319692; bh=X9mqXneelrwgIkX8rnBZnwamGQ+f JY/lFI51wA1rhUk=; b=i1nh693gZ4h7L4VDgMhgSas7ydsSzDD8AP/unkFIR3eF iBDsMGq1+G3OVT9FW0e2MV70COoFbl4XctENUcqbxyLTXIe+LWqlgaVjzJukbBCR kFTXLgKYqmVQX22nUBXe/vza25TwgdQdoAJBkmM/DeBtKRZMP9STbOxYU6lj8m1a pO1D2C4pS+EDOdNyOvvG5UF6UQqrDyTBgWYXo+Clcdzt2xp3+pFaKtQxh1VoK1I5 HjfMQYB4cvGABBMezaZs1MFZBnXO8omvp1TddB8btToyZ3wOOaL0Ja9ddHOxwdWF Wr/vQVJAIc8zN3QJ9aK6z73+mWEh9gTSzrKNsIxHAA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudegledgvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnegfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhf gggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruc eomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteel ieefudffhffhtdetleeggeegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhes phgrqhhuihgvrhdrgiihiidpnhgspghrtghpthhtohepgedpmhhouggvpehsmhhtphhouh htpdhrtghpthhtoheprggvkhhorhhothhkohhvsehgmhgrihhlrdgtohhmpdhrtghpthht ohepphgvthgvrhesvghishgvnhhtrhgruhhtrdhorhhgpdhrtghpthhtoheprghkohhroh htkhhovhesphhoshhtghhrvghsqhhlrdhorhhgpdhrtghpthhtohepphhgshhqlhdqtgho mhhmihhtthgvrhhssehlihhsthhsrdhpohhsthhgrhgvshhqlhdrohhrgh X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 1 Sep 2024 19:28:09 -0400 (EDT) Date: Mon, 2 Sep 2024 08:27:50 +0900 From: Michael Paquier To: Alexander Korotkov Cc: Peter Eisentraut , Alexander Korotkov , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Implement pg_wal_replay_wait() stored procedure Message-ID: References: <18c0fa64-0475-415e-a1bd-665d922c5201@eisentraut.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="t97pAVvGvbOoLWBa" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --t97pAVvGvbOoLWBa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Sep 01, 2024 at 10:35:27PM +0300, Alexander Korotkov wrote: > This path hasn't changes since the patch revision when it was a > utility command. I agree that this doesn't look like proper path for > stored procedure. But I don't think src/backend/utils/adt is > appropriate path either, because it's not really about data type. > pg_wal_replay_wait() looks a good neighbor for > pg_wal_replay_pause()/pg_wal_replay_resume() and other WAL-related > functions. So, what about moving it to src/backend/access/transam? Moving the new function to xlogfuncs.c while publishing WaitForLSNReplay() makes sense to me. -- Michael --t97pAVvGvbOoLWBa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmbU+HYACgkQnvQgOdby QH02SRAAg775exnd94vF5Ks5aZRtkNPStZm9GaMA8jsi/FUcSHMFk0Rw3+hf/eOR hnaPpVjppcYA3zltMJgENSGJhB9EEwe1ncBCwLlrU3lOsFuUIGv+TM36F4VREA4U AGG1BYchk76aRGnEYrBUvhOMrGZlmLpvQfWpOIOqkuvCk4kkw2FdTZP/76KO9Djf OpTAiY3VCHpnskgAvlaiFu5b+Yhosz/z7qq6cr+wHN6r4k/qccM3E4RewzoJBgxe mtOM0/TpUJMQo0m8tghHQiB+XbM7UGqiDEnlDXepfz9ANdw9OWcB+/QF167uKVgX zZ6mIeFCq0fXMUA3FufaScOooqDNGeMoKPub9cwLIlYyWZKemswiRcC8sgJA6UaA NqKdPZlatUsOKIhx0lhwO69vJuwTxdMj2Rm86KPA0Dn8vVlTZgq9uYNvx0jSxtgT D0AvjNb3Cr0RbbjnOVmtjkiEEgkOgqY7pr6Q7fSCoLKnNcJh1XbosOPBFB2i1GFI bDsO0bENyfdo7E9vIvzYUNfKTDWnGg3PREQnD1IG6gu/uajBRvS5xgWcvaUzN7dR jGiRiA48URyQXEa3ISljcgV1DDkS6TW2n8lnFa6LXC4wi3Aem1zHf9iGxjoI7DOR m90UFf+6CRBujXZ1wuzftZRtJAfOcRdyJrYW7DSeyskSFxO4K3M= =hNUA -----END PGP SIGNATURE----- --t97pAVvGvbOoLWBa--