Date: Sun, 15 Sep 2024 16:36:56 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Perl scripts: eliminate "Useless interpolation" warnings
Message-ID: <ZudFaDhhXHg3AAlv@momjian.us>
References: <E1spqfS-001Ehn-Cx@gemulon.postgresql.org>
 <66b5b1d6-3f2a-4944-91a3-7e40a565ccac@dunslane.net>
 <ZudAtNRQOkveAa91@momjian.us>
 <e51357f4-4ac5-4b64-b01a-15931485702f@dunslane.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e51357f4-4ac5-4b64-b01a-15931485702f@dunslane.net>
Archived-At: 
 <https://www.postgresql.org/message-id/ZudFaDhhXHg3AAlv%40momjian.us>
Precedence: bulk

On Sun, Sep 15, 2024 at 04:33:49PM -0400, Andrew Dunstan wrote:
> I understand perfectly what the warning is about.
> 
> But the project's perlcritic policy is expressed at src/tools/perlcheck/
> perlcriticrc. It's basically severity 5 plus some additions and one exception.
> We shouldn't be imposing our personal perlcritic policies on the project.
> 
> The change isn't bad in itself, but there shouldn't be any expectation that we
> will keep to this policy, as it's not required by project policy.
> 
> There is a huge mass of perlcritic issues in our perl code at severity 1 (over
> 13000 by my count). If we're going to clean them up (which I would oppose) we
> should do it in a systematic way. It's hard to see why this one is special.

I guess it is special only because my policy is more strict so I wanted
my new code to match.  Should I revert it?  Is the very tiny improvement
not worth the churn in the code?

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  When a patient asks the doctor, "Am I going to die?", he means 
  "Am I going to die soon?"