Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1srGYi-000AZ5-83 for pgsql-committers@arkaria.postgresql.org; Thu, 19 Sep 2024 12:46:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1srGXh-000Nd5-ID for pgsql-committers@arkaria.postgresql.org; Thu, 19 Sep 2024 12:45:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1srGXh-000Ncv-90 for pgsql-committers@lists.postgresql.org; Thu, 19 Sep 2024 12:45:54 +0000 Received: from momjian.us ([72.94.173.45]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1srGXe-0000zM-FF for pgsql-committers@lists.postgresql.org; Thu, 19 Sep 2024 12:45:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=momjian.us; s=2024011501; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description; bh=qfcVYAFGIXzpbho0nuv/CK8ZYsihymeRoxov7MpeHrM=; b=k2yy4 7Ey9B4JdOxMRn0oPO6X275opEkdOtgDxE7+uQq+S0ArfLyTBtq/Xx1RIHCB6FXWyY3ZSigaSZymUK oV0riF/3GhG021mYJ5aJkX3X2CYKfywMu2l1oRMKdloIlrmoQDzTt/p78357sNt50slQV5sReslS2 EWNdKv1lBquWJHcPc0jCKCWrVUp2IEMk9XO5/U22mZ0WW91hbQnzu/eVqc8zC3AwNOseS6kLqw92k ebetHhQEKxsugoOCL6eDriibx6OzR+bZlMK+/n4HjqUA7UVa1D0smVEsE357wXfNKkaFRXJ8URJMo Wb6IoKdnJ96B7iHuw9ZbJDDyS/zQg==; Received: from bruce by momjian.us with local (Exim 4.96) (envelope-from ) id 1srGXd-004YF4-0t; Thu, 19 Sep 2024 08:45:49 -0400 Date: Thu, 19 Sep 2024 08:45:49 -0400 From: Bruce Momjian To: Andrew Dunstan Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: scripts: add Perl script to add links to release notes Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Sep 17, 2024 at 09:47:57AM -0400, Andrew Dunstan wrote: > > On 2024-09-16 Mo 1:27 PM, Bruce Momjian wrote: > > scripts: add Perl script to add links to release notes > > Reported-by: jian he > > Discussion: https://postgr.es/m/ZuYsS5XdA7hVcV9l@momjian.us > > > I realize I'm late to the party on this, but here's a review patch for this > script. It's mostly stylistic changes (simpler use of print, use of POSIX > xdigit class for hex digits), but it does correct one actual error: AFAIK "die" > doesn't do printf style substitutions. Patch applied. Sorry for the delay. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com When a patient asks the doctor, "Am I going to die?", he means "Am I going to die soon?"