Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sv8wd-00Ck71-U1 for pgsql-committers@arkaria.postgresql.org; Mon, 30 Sep 2024 05:27:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sv8wc-00CgHf-Vm for pgsql-committers@arkaria.postgresql.org; Mon, 30 Sep 2024 05:27:38 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sv8wb-00CgHN-L0 for pgsql-committers@lists.postgresql.org; Mon, 30 Sep 2024 05:27:38 +0000 Received: from fhigh-a6-smtp.messagingengine.com ([103.168.172.157]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sv8wY-001k73-1l for pgsql-committers@lists.postgresql.org; Mon, 30 Sep 2024 05:27:36 +0000 Received: from phl-compute-09.internal (phl-compute-09.phl.internal [10.202.2.49]) by mailfhigh.phl.internal (Postfix) with ESMTP id 6049B11401EF; Mon, 30 Sep 2024 01:27:32 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-09.internal (MEProxy); Mon, 30 Sep 2024 01:27:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1727674052; x=1727760452; bh=647BINe/Ir uSLAylk79n5NM9Pqc7pNRoVa/quBIsimQ=; b=p1fb1mG3A6b7+wirZx2aZ95I2K nONBs+hdQkvbwEhAesB7I7Jq6yC3HXVhx9GLaKWzXS8xnT/Zflt5BzBxUbGadlQo XLJopB8JPtRAngx8HjgwcrPICj9JIUcpdc1xB5pdeBOhqFyYbjOWROxjRwqiYHy4 2pkRWuYn8C2f+/YdQeXmAgI4ZUIx6o8eoRiLGderpr8/dDNofBSJjaohvT92S6Os zclg0qorBYAsM9FwP+QoVWiECSLQLlHaZV0qdlpQjGJzuj9uKBTjaszgYmllsDYy iYvG0AqxWa1hcXJ1pKGllQ06191D73IdqjP0r4Bv5nYkkyWFINWM843F4gFg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1727674052; x=1727760452; bh=647BINe/IruSLAylk79n5NM9Pqc7 pNRoVa/quBIsimQ=; b=QOAUS8xc5oK5wYj0b3BwD7FqijhdwhG3QbDQ0KOYFxDa TiQ+/Hk8xLrBHZ6MHD6jXbCWVI1Raw3nGQykocmsYHA/2e06sDO0i5tB+nWcNgIh c6Jc0jxrv3MRa+kNiOhxzD0A7OL7bJ2iQ9MpY7mEoriVv3BiHrXN5e+kjC9BXo1u 2i4l50Hx08zhM3NZucZUttb7+8SThF445qy293gttFFAsFnYU2zmNZmFgGXeWJ04 8CPhjDrNDQVB0Cy9KGaPVVZZDObmO/6+dnPARZ4uYrhtxnl2A9pUL9cs0HyRomMT 9458s8L1Efgv6XagLdS9hQ54KjeEPJmezy4sVOrY8g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvddugedgleehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucgfrhhlucfvnfffucdlje dtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefo ihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqhhuihgvrhdrgiihii eqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeggeegfffhkeeuveetiefg udduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihiidpnhgspghrtghpthht ohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepthhglhesshhsshdrphhghh drphgrrdhushdprhgtphhtthhopehpghhsqhhlqdgtohhmmhhithhtvghrsheslhhishht shdrphhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 30 Sep 2024 01:27:30 -0400 (EDT) Date: Mon, 30 Sep 2024 14:27:13 +0900 From: Michael Paquier To: Tom Lane Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Show values of SET statements as constants in pg_stat_statements Message-ID: References: <1364409.1727673407@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cO3hufTP78iG/1Nn" Content-Disposition: inline In-Reply-To: <1364409.1727673407@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --cO3hufTP78iG/1Nn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Sep 30, 2024 at 01:16:47AM -0400, Tom Lane wrote: > Shouldn't this have included a catversion bump? The parsenodes.h > change would for example break new-style SQL functions that include > a SET command. Probably a narrow use-case, but still. Hmm, yeah. I was wondering if I needed a bump, but forgot about that. Thanks. -- Michael --cO3hufTP78iG/1Nn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmb6NrEACgkQnvQgOdby QH0kuw//WPTYNzAvxizFkRCAzIhqIzxXf4DSXZitR8ohuCWUUjk2465hptTjmpI3 56VHBCFJrDPJ2Zl0AMPKEKFLBWolzzEd47daFcjb6O3Erk8IoLRAsWt3XnFR79zX v6zIpEBRqIAw7iy41ANR1QbYv+6y44EsA9tsT0ovgmoc/ZK7FQyJBLtm7VZOvCbH dn0/FhieaoDBoMss8TTG3HiK7SYuURT/SYN4zzm6seyc9942KN5VGBl3hwq05sjx K/Xqmna/vUav9XI82Y98VB9bRCW7l5PNRIpolvQT2RxHoHU3qUWkG0XztfzqPYF2 qrtQJGPiKX92fGo6Kix+98EbGIK0PnlbaS/4q5I4J4FIVrTJzAwNHoEHz9gPu/ke usbgXl0e6zj7K6TlNgJucgcAEIjcHW3jNonnTek2+I49lNovrvoWsu3R8FhQ1Uit 8jMlLvya5XnwMmmXnrMzSeUUS989Mu0TJPKgqMHgSsvITV5ewKChXAKVX+ZdZjz2 k9dMiiGVeh8k+SsjthcBHG4wsk9qaCdZ197Nj7qruqcsDm5fuYEN9elPq7qcd9xp mszbdZS4cn5YuUJOPyJwykacWzy0fiCFKeUhA8+i1Z2QCnOEXKwlL8o7j9ZE0JmF pDJZdd573rG5yzz9WI4xD+NvfHZ9b5JY860rKsi1YJGhH3FNGAs= =hsiG -----END PGP SIGNATURE----- --cO3hufTP78iG/1Nn--