Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 1 Nov 2024 10:56:50 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make all ereport() calls within gram.y provide error
 locations.
Message-ID: <ZyQ1YgvaQw85F-Jm@paquier.xyz>
References: <E1t6bUA-003L1a-OS@gemulon.postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="KZcY2Bips7snRWCO"
Content-Disposition: inline
In-Reply-To: <E1t6bUA-003L1a-OS@gemulon.postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/ZyQ1YgvaQw85F-Jm%40paquier.xyz>
Precedence: bulk


--KZcY2Bips7snRWCO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Tom,

On Thu, Oct 31, 2024 at 08:09:38PM +0000, Tom Lane wrote:
> Make all ereport() calls within gram.y provide error locations.
>=20
> This patch responds to a comment that I (tgl) made in the
> discussion leading up to 774171c4f, that really all errors
> occurring during raw parsing should provide error cursors.
> Syntax errors reported by Bison will have one, and most of
> the handwritten ereport's in gram.y already provide one,
> but there were a few stragglers.
>=20
> (It is not claimed that this handles every failure reachable
> during raw parsing --- out-of-memory is an obvious exception.
> But this makes a good start on cases that are likely to occur.)
>=20
> While we're at it, clean up the reported positions for errors
> associated with LIMIT/OFFSET clauses.  Previously we were
> relying on applying exprLocation() to the contained expressions,
> but that leads to slightly odd cursor placement, e.g.

The tests of sepgsql need a refresh:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Drhinoceros&dt=3D2=
024-10-31%2020%3A52%3A13

Thanks,
--
Michael

--KZcY2Bips7snRWCO
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmckNWIACgkQnvQgOdby
QH08Wg//YueywV3sAs9hBg5Zqu7S8I50paTTyreIzF+LMBHBjatDiKUAr8xt3t/9
4JCknKgKPIDqdEA/7FYMGKVCopJCNrKlgN21T9KmkR3oS8fYOD993VoArrj7fGxl
M3QNqHDsWizCmoTM2ZxcqJ0mTyiAFa0ZFSFrQ2psormHVnFg+OAYvF+UNClkITnp
R1sRcUNd8Yw4xDyCwieOwpXIl+mgX9Sx4qlX+N1dADAgRQathadTGaaOOGdaq5Vw
gOvs+wZTePJJU6nfScy22RsGNgY44Y0Y3E0Ca1RZ+Dj4UrXkypenbq1wvfJoZ7m1
3j7oyjNLs3NL1Vrl+/cxLc4T1geK8wD1hvM4a9KRF3Oz4ton7bNrA8oGlIGkwhRB
qiYAfVz7dbRqBJ3qp2qecKi/iVWr9qcjnL7Fd70GwWKVtpyvJh/d4qMP54t4nPU/
+CG6hr3eZSiJrS7pQOD8I88Ybu8IrRTrZbzxsNhdyA+TWmFtLpQIFtv/Tl5IJrrt
6qKofi57S/LYK9EKdh+gTAtSHjGtRe42Sz4i7XQulQbDnGQm8DZZEq+1zxQl1vfn
ARw5/Y4Fvw0WpMYQROJMCdV+mRAhBfgoy4uuqaCm7DoRg6+gKAdhYg4gCzUcsoJk
ftjS/htmbgwfcN6YloVubb4p7E/p5nDAOkWJGXDRI6hwBiI0kuY=
=uyQv
-----END PGP SIGNATURE-----

--KZcY2Bips7snRWCO--