pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Handle equality operator in contrib/pg_trgm
2+ messages / 2 participants
[nested] [flat]

* pgsql: Handle equality operator in contrib/pg_trgm
@ 2020-11-15 05:53 Alexander Korotkov <akorotkov@postgresql.org>
  2024-09-20 20:19 ` Re: pgsql: Handle equality operator in contrib/pg_trgm Laurenz Albe <laurenz.albe@cybertec.at>
  0 siblings, 1 reply; 2+ messages in thread

From: Alexander Korotkov @ 2020-11-15 05:53 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Handle equality operator in contrib/pg_trgm

Obviously, in order to equality operator be satisfiable, target string must
contain all the trigrams of the search string.  On this base, we implement
equality operator in GiST/GIN indexes with recheck.

Discussion: https://postgr.es/m/CAOBaU_YWwtT7tdggtROacjdOdeYHCz-tmSwuC-j-TOG-g97J0w%40mail.gmail.com
Author: Julien Rouhaud
Reviewed-by: Tom Lane, Alexander Korotkov, Georgios Kokolatos, Erik Rijkers

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/935f6666502250abde8615bc7805a6e5aa05a066

Modified Files
--------------
contrib/pg_trgm/Makefile              |   2 +-
contrib/pg_trgm/expected/pg_trgm.out  | 204 +++++++++++++++++++++++++++++++++-
contrib/pg_trgm/pg_trgm--1.5--1.6.sql |  10 ++
contrib/pg_trgm/pg_trgm.control       |   2 +-
contrib/pg_trgm/sql/pg_trgm.sql       |  40 +++++++
contrib/pg_trgm/trgm.h                |   1 +
contrib/pg_trgm/trgm_gin.c            |   3 +
contrib/pg_trgm/trgm_gist.c           |   4 +-
doc/src/sgml/pgtrgm.sgml              |   8 +-
9 files changed, 264 insertions(+), 10 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: pgsql: Handle equality operator in contrib/pg_trgm
  2020-11-15 05:53 pgsql: Handle equality operator in contrib/pg_trgm Alexander Korotkov <akorotkov@postgresql.org>
@ 2024-09-20 20:19 ` Laurenz Albe <laurenz.albe@cybertec.at>
  0 siblings, 0 replies; 2+ messages in thread

From: Laurenz Albe @ 2024-09-20 20:19 UTC (permalink / raw)
  To: Alexander Korotkov <akorotkov@postgresql.org>; pgsql-committers@lists.postgresql.org

On Sun, 2020-11-15 at 05:53 +0000, Alexander Korotkov wrote:
> Handle equality operator in contrib/pg_trgm
> 
> Obviously, in order to equality operator be satisfiable, target string must
> contain all the trigrams of the search string.  On this base, we implement
> equality operator in GiST/GIN indexes with recheck.
> 
> Discussion: https://postgr.es/m/CAOBaU_YWwtT7tdggtROacjdOdeYHCz-tmSwuC-j-TOG-g97J0w%40mail.gmail.com
> Author: Julien Rouhaud
> Reviewed-by: Tom Lane, Alexander Korotkov, Georgios Kokolatos, Erik Rijkers
> 
> Branch
> ------
> master
> 
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/935f6666502250abde8615bc7805a6e5aa05a066

This causes bad query results with non-deterministic collations, see
https://postgr.es/m/8ef4899c4acfebca45cc6c042a6dc611d25ffab1.camel@cybertec.at

Yours,
Laurenz Albe





^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2024-09-20 20:19 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-11-15 05:53 pgsql: Handle equality operator in contrib/pg_trgm Alexander Korotkov <akorotkov@postgresql.org>
2024-09-20 20:19 ` Laurenz Albe <laurenz.albe@cybertec.at>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox