Message-ID: <a3bce10f-0e9b-4d3b-29c7-a150fc44037e@dunslane.net>
Date: Fri, 22 Apr 2022 10:24:27 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: pgsql: Allow db.schema.table patterns, but complain about random
 garbag
Content-Language: en-US
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <rhaas@postgresql.org>, pgsql-committers@lists.postgresql.org
References: <E1nhCcm-000HvW-AT@gemulon.postgresql.org>
 <3a190754-b2b0-d02b-dcfd-4ec1610ffbcb@dunslane.net>
 <3687648.1650636245@sss.pgh.pa.us>
From: Andrew Dunstan <andrew@dunslane.net>
In-Reply-To: <3687648.1650636245@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/a3bce10f-0e9b-4d3b-29c7-a150fc44037e%40dunslane.net>
Precedence: bulk


On 2022-04-22 Fr 10:04, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> This has upset the buildfarm's msys2 animals. There appears to be some
>> wildcard expansion going on that causes the problem. I don't know why it
>> should here when it's not causing trouble elsewhere. I have tried
>> changing the way the tests are quoted, without success. Likewise,
>> setting SHELLOPTS=noglob didn't work.
>> At this stage I'm fresh out of ideas to fix it. It's also quite possible
>> that my diagnosis is wrong.
> When I was looking at this patch, I thought the number of test cases
> was very substantially out of line anyway.  I suggest that rather
> than investing a bunch of brain cells trying to work around this,
> we just remove the failing test cases.

WFM.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com