Message-ID: <a3f43549-1d1d-44a5-b7ab-33327b899ee1@dunslane.net>
Date: Wed, 2 Apr 2025 08:34:11 -0400
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: TEMP_CONFIG vs test_aio
To: Andres Freund <andres@anarazel.de>
Cc: Todd Cook <cookt@blackduck.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
 Noah Misch <noah@leadboat.com>
References: <E1tzglG-0029Xu-0h@gemulon.postgresql.org>
 <zh5u22wbpcyfw2ddl3lsvmsxf4yvsrvgxqwwmfjddc4c2khsgp@gfysyjsaelr5>
 <EF3AA62E-A317-4A6B-BA98-C03E7238A671@blackduck.com>
 <4fi62oxjougycbzfuynokg2gajxx3j4ue6velmbzgtski5jlpz@72ri5hvlntac>
 <7dc78fd9-0afc-484e-bcba-c6f58567ab81@dunslane.net>
 <lon4dng6lffn4hamo3n654lo5w2zjadap3e437cdfr5lxdklll@vemlvmfgnbox>
From: Andrew Dunstan <andrew@dunslane.net>
Content-Language: en-US
Autocrypt: addr=andrew@dunslane.net; keydata=
 xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI
 gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq
 Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C
 eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys
 SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB
 AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAmwQTAQgARQIbAwIX
 gAIZAQULCQgHAgMiAgEGFQoJCAsCBBYCAwECHgcWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUC
 ZFlxxwUJGVGAbgAKCRCZ+n/LWfw7gXikB/9ZdcUy6CTBFIIuL/bVsc1eLEW/gJBjJBF6HxNY
 xgEkAgXAp4Lg4A5U+QB9GouFr7+GYxF0BU4hzoGhNPUWltxnHdMWP8nC/38LAqgMi8L/bbsm
 HW5YPBdWYaAZAPJQVfOAgjTbRUb26KSprpyrrJKW0ZmrZfjhNPcQ72jpWzoPLQqx2X6B0fru
 1jq+cBh8lb6r1mJTim1T3JIn+F/v5VpdQS+EL8xqsHkfzKjIPsW3CIXpkypSk6saA55Rkkbl
 26AW8ftPVB0Q6Lnn6FLt9CP0MGNixBQ55yq8r1K+nCBvCCjvQjM8RDm0UUum0WNl+ifQgTLO
 E8TWEnwVtkBf+3QWzsBNBE7KWFkBCADRnOM0FCzsYW6jtncg+dWIagjUZpvaClmqn/sJluLa
 Q3v1VXMQJzYs3eC1gh386W+XBwLRpDj3jzH81lX+p73Re3d3oJW7X+ffsxuzu5ZVdMUkqBYo
 nkAbKxr6gyJ12F/+JkUVzLcoTN+d/7YsQvUVi7NaKH8mJgjz112O4fUe3p9wfAaFa0RXHc5S
 GPzRTYRRlv/XZBIho4J2tkZOnteZJZ+GbxQVlINt6fd8P6al3MWOvpP/ExJPguEfjOsO6Njy
 xjo3WfpD4lHMOR/Oc3/8mScEF84rF2jXbsFgelWnbPWAvXY+pD0dXOFRkagGmC/viwBDqq5b
 5tk76kKmUbZxABEBAAHCwHwEGAEIACYCGwwWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUCZFlx
 5wUJGVGAjgAKCRCZ+n/LWfw7gf+iB/4g8CPY5jihf5r/8EsoIGe2H+dpVmpPF8YGBzTIvCz/
 fQoOq8AX/pE76QEuFnFZWfjw+wgBXgCVmkox2Eflkk6z4ND3pcwGZ6CfCxTQCDk/dij+2DQ4
 6bmDCy/sBgcbz9mTpoLC11HLoPae6YN9nBNQRZDcEFEu54OaVOqlIdbA6m+POIBCXZdHOFc0
 WoDTgxHRzC1jgQNidyd6tKqcsVJs0dzF0oKTmFFmUAqTdJO12LBuNA1rlqrR3EtpYk8B/wtS
 5dIMD7Q8hwQpL+4C6GNpb6ZKnPkLi47pDOLhz2qBrqN+rqUEsT3YnExYpzj5yOBi+FlmV1Hw
 49QYe1sn2ZPs
In-Reply-To: <lon4dng6lffn4hamo3n654lo5w2zjadap3e437cdfr5lxdklll@vemlvmfgnbox>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/a3f43549-1d1d-44a5-b7ab-33327b899ee1%40dunslane.net>
Precedence: bulk


On 2025-04-01 Tu 5:34 PM, Andres Freund wrote:
> Hi,
>
> On 2025-04-01 17:08:49 -0400, Andrew Dunstan wrote:
>> On 2025-04-01 Tu 4:17 PM, Andres Freund wrote:
>>> For one using PG_TEST_INITDB_EXTRA_OPTS would probably require changing the
>>> buildfarm code, because the buildfarm code filters out environment variables
>>> that aren't on an allowlist (I really dislike that).
>>
>> Uh, not quite. Anything in the config's build_env is not filtered out. That
>> change was made a year ago.
> Huh. Just recently I tried to configure PG_TEST_TIMEOUT_DEFAULT in build_env
> and did not take effect until I explicitly added it to the @safe_set.
>


Correction: the code changed was a year ago, bit it was in release 18, 
which was in November. If it didn't work after that I want to know.


This is the commit: 
https://github.com/PGBuildFarm/client-code/commit/e2dd43915b4aa97447a5e8118f733b444896db81


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com