Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owWq0-0000sp-GN for pgsql-hackers@arkaria.postgresql.org; Sat, 19 Nov 2022 23:01:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1owWpz-0006sK-C0 for pgsql-hackers@arkaria.postgresql.org; Sat, 19 Nov 2022 23:01:27 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owWpz-0006sB-0w for pgsql-hackers@lists.postgresql.org; Sat, 19 Nov 2022 23:01:27 +0000 Received: from mail-qv1-xf35.google.com ([2607:f8b0:4864:20::f35]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1owWps-0002qx-If for pgsql-hackers@postgresql.org; Sat, 19 Nov 2022 23:01:26 +0000 Received: by mail-qv1-xf35.google.com with SMTP id c8so5771096qvn.10 for ; Sat, 19 Nov 2022 15:01:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joeconway.com; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CnYXILFAEuZojs04kNpSF4e0GS6nanqhKsNHQ+HJWvU=; b=Z5gRtW2KTkOfNjZTr8bSui1A14//oIvq356cQv0vIlCiRdrQoj1LxtfTovqzO+o8Lu YTWy2+SqhrpKGOXm1v4SpjHHoRo0bGuThXFJHuBbdgUkAsyPA5PQf/yUB6/7qTrhtsyp bSsx/PmufG5TyL7kMck5YhBoJ6edhNZdcxtuSnQdYAwsOHE+GkZbnMtpNSbvHTDged18 vdTkOGE59thdSPjVum2Au71ch8Z9fovIFAJwhg6wDPdpefhJzVpwq+uR1RHlvzZ05awj dhRYRMjKxE9ZBsTGkpgTdaxLbbJCs8uj91Cgpy5OXLyUjLfQp3j+al7909yKm6WGh6zk bPuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CnYXILFAEuZojs04kNpSF4e0GS6nanqhKsNHQ+HJWvU=; b=4hI+us4El8pIB7l5/bmYA0vtb5uyPre+Avuk77dQHArWnokEulVQCorSUslY+6cme2 LJEmd4a/BFd4Pjux7xhqjOgY4uaixd3KQSpEZggR2YoXhsRVvTyl9dAdAyZc58PxFRq6 u9+pWCT8KvwwNci2kkm2jo1jE0WUgtWIAk27NO24rujYGHWPmUGvw9LtqjaYJ+8h0egX iTo8EXg58oCwwoVPaZifV9T3fW2PhVfXVWAF/ZwfeHgMKkA/1BQKiyGDaMwnPLl7q5t7 HlLNPYcBBRkZkBqTX1EgtYjz0WOHrCZpT/DrvLJTttPcVNMAFe0q9u6JePF0nIl32CfC XJog== X-Gm-Message-State: ANoB5pmmkj43JGSRv2dWpNdLcuCQezS6QLH13K5q+uVF/6Px8BdsU/ST FCl8b4RkM0wPwIy1zFsOoZj2xA== X-Google-Smtp-Source: AA0mqf4u8lIkGpp+hSRnyJZG9e6BZcd3Y2J/dv3Hfn4in/ageJSEm0hP2tfdrjKyK4jU2esVcZlK+w== X-Received: by 2002:a0c:8045:0:b0:4ad:68f8:1183 with SMTP id 63-20020a0c8045000000b004ad68f81183mr12372650qva.49.1668898879568; Sat, 19 Nov 2022 15:01:19 -0800 (PST) Received: from [192.168.4.41] (162-239-31-113.lightspeed.dybhfl.sbcglobal.net. [162.239.31.113]) by smtp.gmail.com with ESMTPSA id ga17-20020a05622a591100b003a6328ee7acsm2697177qtb.87.2022.11.19.15.01.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Nov 2022 15:01:19 -0800 (PST) Message-ID: Date: Sat, 19 Nov 2022 18:01:18 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: pgsql: Fix typos and bump catversion. Content-Language: en-US To: Tom Lane , Andres Freund Cc: Robert Haas , PostgreSQL-development References: <1e37f7d5-08a7-fbfb-da2e-b4aa5f409e01@joeconway.com> <20221119221618.ukkzaj3lilrrt52o@awork3.anarazel.de> <2655402.1668896690@sss.pgh.pa.us> From: Joe Conway In-Reply-To: <2655402.1668896690@sss.pgh.pa.us> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 11/19/22 17:24, Tom Lane wrote: > Andres Freund writes: >> On 2022-11-19 17:10:57 -0500, Joe Conway wrote: >>> Rishu Bagga pointed out to me offlist that this catversion bump seems >>> flawed: >>> /* yyyymmddN */ >>> -#define CATALOG_VERSION_NO 202211121 >>> +#define CATALOG_VERSION_NO 202211821 > >>> I think that should be 202211181, no? I am not clear on the desirable way to >>> fix though :-/ > >> I think it's fine to just update to a "normal" catversion. > > Yeah, just fix it --- and the sooner the better, to avoid the risk > that this becomes a value that someone needs to care about. WFM, done -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com