Feedback-ID: id4a34324:Fastmail
Date: Wed, 19 Mar 2025 10:29:19 -0400
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: aio: Add core asynchronous I/O infrastructure
Message-ID: <a54pqocps46awa4b2tlwmrjz5k3b3jastg5py6thtnqtlr2ksy@notafhjwiuec>
References: <E1tuJo6-0030Bd-0C@gemulon.postgresql.org>
 <93029.1742310216@sss.pgh.pa.us>
 <ecqk4e772iqtwuwfu56yr3cv5wnzug6fpqvmwjcwlduqlom5xr@2fzz3cdycdyb>
 <95354.1742311575@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <95354.1742311575@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/a54pqocps46awa4b2tlwmrjz5k3b3jastg5py6thtnqtlr2ksy%40notafhjwiuec>
Precedence: bulk

Hi,

On 2025-03-18 11:26:15 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > I wonder if we should instead either ask those buildfarm animals to be
> > disabled or have the warning manually disabled. I don't think it's a good
> > investment on our part to work towards warning cleanliness on clang 4 and 5,
> > on distros from 2017 and and 2018 respectively.
> 
> Well, if we don't want to fix it I can just adjust my warning-scraping
> script to ignore these.  Let's wait a bit and see if any newer
> compilers warn similarly before deciding.

FWIW, adding a few casts does silence the warnings, at least on clang-3.9,
which I had around.

But there also are other warnings on that compiler, mainly stuff like:

../../home/andres/src/postgresql/src/interfaces/libpq/fe-auth-oauth-curl.c:1437:28: warning: suggest braces around initialization of subobject [-Wmissing-braces]
        struct itimerspec spec = {0};


I lean towards not fixing this stuff, but if you would like me to, I can.

Greetings,

Andres Freund