Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyiYF-0007CM-TZ for pgsql-committers@arkaria.postgresql.org; Fri, 25 Nov 2022 23:56:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oyiYE-0000hB-QO for pgsql-committers@arkaria.postgresql.org; Fri, 25 Nov 2022 23:56:10 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyiYE-0000h1-Iy for pgsql-committers@lists.postgresql.org; Fri, 25 Nov 2022 23:56:10 +0000 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyiYB-0001Zj-Ts for pgsql-committers@lists.postgresql.org; Fri, 25 Nov 2022 23:56:09 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id 646571C0003; Fri, 25 Nov 2022 23:56:03 +0000 (UTC) Message-ID: Date: Fri, 25 Nov 2022 18:56:02 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: pgsql: Allow building with MSVC and Strawberry perl Content-Language: en-US To: Andres Freund Cc: pgsql-committers@lists.postgresql.org References: <02b5e6c8-a062-94f0-1add-db1fd1db5f0b@dunslane.net> <20221125233331.dh4yrd76a3mnwj4s@awork3.anarazel.de> <20221125234813.25iiq5snxejebdak@awork3.anarazel.de> From: Andrew Dunstan In-Reply-To: <20221125234813.25iiq5snxejebdak@awork3.anarazel.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-11-25 Fr 18:48, Andres Freund wrote: > Hi, > > On 2022-11-25 15:33:31 -0800, Andres Freund wrote: >> FWIW a meson build with msvc 2019 and strawberry perl 5.32 builds fine with >> #define __builtin_expect(expr, val) (expr) > And it does so with src/tools/msvc as well. I think we might need a > preprocessed plperl.c from drongo to analyze this further. > > There might be some unrelated under-specified build issues, I get weird errors > if I start by building plperl.vcxproj, without first having built > postgres.vcxproj. But ... > Yeah, drongo builds fine too. It's the handshake thing that's the current issue. I'll see if forcing -DNO_THREAD_SAFE_LOCALE works. Thanks cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com