Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cHWRT-0008DJ-C7 for pgsql-committers@arkaria.postgresql.org; Thu, 15 Dec 2016 13:51:27 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cHWRS-0003gK-QT for pgsql-committers@arkaria.postgresql.org; Thu, 15 Dec 2016 13:51:26 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cHWRE-0003RO-W8 for pgsql-committers@postgresql.org; Thu, 15 Dec 2016 13:51:13 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cHWR8-00066e-CO for pgsql-committers@postgresql.org; Thu, 15 Dec 2016 13:51:11 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 2485820983; Thu, 15 Dec 2016 08:51:05 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute7.internal (MEProxy); Thu, 15 Dec 2016 08:51:05 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= smtpout; bh=i+FkpylMFgOV01X83n+AjmF8BG8=; b=DDtymkqL3RTRzAkUqKyb BU5bFrWc/Vf2F2F1vl36jxofmHeqAYXQfHlMefvbCf81PV3CXUtJWDZu32DIPfjN Y+44eoFtNOOpHp6LnrveuIYnS8I19PcwRd75wBQvmrN/AHzG3w4KkNy/b5ABrWS7 QnuaMCuowYHXa5DOSl/EwaE= X-ME-Sender: X-Sasl-enc: II1i0xCpMQ7Ibf7EFyuTkAON7jCr1KsDqygCnNtZJCOf 1481809864 Received: from april.local (c-73-13-66-39.hsd1.pa.comcast.net [73.13.66.39]) by mail.messagingengine.com (Postfix) with ESMTPA id B10A07EBF7; Thu, 15 Dec 2016 08:51:04 -0500 (EST) Subject: Re: pgsql: Add support for temporary replication slots To: Petr Jelinek , Andres Freund References: <27274.1481557380@sss.pgh.pa.us> <27833.1481558144@sss.pgh.pa.us> <62935e6f-4f1b-c433-e0fa-7f936a38b3e5@2ndquadrant.com> <22907.1481571177@sss.pgh.pa.us> <15713.1481585953@sss.pgh.pa.us> <314cae39-2e7d-f5a3-d226-cfb80cf80481@2ndquadrant.com> <18684.1481589637@sss.pgh.pa.us> <48b2c017-695d-b5ac-2ff4-89b939b3e8f9@2ndquadrant.com> <20161213004903.iito2pefdrrjgny5@alap3.anarazel.de> <6886c56a-f6c8-3c44-53a1-dae6c24afb76@2ndquadrant.com> <20161213010059.dn64rrb3u7zxnnwk@alap3.anarazel.de> <3c8c413d-b476-93d2-652f-011a589a2d74@2ndquadrant.com> <309c14fa-e043-a353-366e-3ce0aab527c8@2ndquadrant.com> Cc: Tom Lane , pgsql-committers@postgresql.org From: Peter Eisentraut Organization: 2ndQuadrant Message-ID: Date: Thu, 15 Dec 2016 08:51:04 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <309c14fa-e043-a353-366e-3ce0aab527c8@2ndquadrant.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-committers Precedence: bulk Sender: pgsql-committers-owner@postgresql.org On 12/15/16 3:46 AM, Petr Jelinek wrote: >>> Okay in case we decide it's the right way to go attached patch does >>> that. I also added some more tests based on your feedback while I am at it. >> >> This looks mostly reasonable to me, but the location and xid output from >> pg_logical_slot_get_changes() is not portable/repeatable, so it should >> be omitted from the output. >> > > Sigh, yes you are right. committed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers