Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1u7aog-002ClF-QL
	for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Apr 2025 14:11:11 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1u7aod-006jgH-PQ
	for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Apr 2025 14:11:08 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <cb@df7cb.de>)
	id 1u7aod-006jg8-Fg
	for pgsql-hackers@lists.postgresql.org; Wed, 23 Apr 2025 14:11:08 +0000
Received: from mout-p-103.mailbox.org ([2001:67c:2050:0:465::103])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <cb@df7cb.de>)
	id 1u7aoc-001XoC-03
	for pgsql-hackers@lists.postgresql.org;
	Wed, 23 Apr 2025 14:11:07 +0000
Received: from smtp2.mailbox.org (smtp2.mailbox.org
 [IPv6:2001:67c:2050:b231:465::2])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest
 SHA256)
	(No client certificate requested)
	by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4ZjLcL42LNz9tKY;
	Wed, 23 Apr 2025 16:10:58 +0200 (CEST)
Date: Wed, 23 Apr 2025 16:10:56 +0200
From: Christoph Berg <myon@debian.org>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Corey Huinker <corey.huinker@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Update guidance for running vacuumdb after pg_upgrade.
Message-ID: <aAj08PiW0CX7OWY9@msg.df7cb.de>
References: <E1tueZC-0039rk-2P@gemulon.postgresql.org>
 <aAfxfKC82B9NvJDj@msg.df7cb.de>
 <aAgCBgIh3BxkvceM@nathan>
 <aAgEIXZ9zlqThJCZ@msg.df7cb.de>
 <aAgKMavWTlgjWkar@nathan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <aAgKMavWTlgjWkar@nathan>
X-Rspamd-Queue-Id: 4ZjLcL42LNz9tKY
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/aAj08PiW0CX7OWY9%40msg.df7cb.de>
Precedence: bulk

Re: Nathan Bossart
>  	pg_log(PG_REPORT,
> +		   "Some statistics are not transferred by pg_upgrade.\n"
>  		   "Once you start the new server, consider running:\n"
> +		   "    %s/vacuumdb %s--all --analyze-in-stages --missing-stats-only\n"
> +		   "    %s/vacuumdb %s--all --analyze-only",

I would make it "Once you start the new server, run these two commands:"
to make it explicit that both should be run, not alternatively either.

This patch addresses my concern, thanks.

Christoph