Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u7bF3-002JtK-6P for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Apr 2025 14:38:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1u7bF1-006twj-EN for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Apr 2025 14:38:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u7bF1-006twb-4j for pgsql-hackers@lists.postgresql.org; Wed, 23 Apr 2025 14:38:23 +0000 Received: from mout-p-202.mailbox.org ([80.241.56.172]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u7bEy-001c7b-2M for pgsql-hackers@lists.postgresql.org; Wed, 23 Apr 2025 14:38:23 +0000 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4ZjMCs14Sxz9tPX; Wed, 23 Apr 2025 16:38:17 +0200 (CEST) Date: Wed, 23 Apr 2025 16:38:16 +0200 From: Christoph Berg To: Nathan Bossart Cc: Nathan Bossart , Corey Huinker , pgsql-hackers@lists.postgresql.org Subject: Re: vacuumdb --missing-stats-only and pg_upgrade from PG13 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4ZjMCs14Sxz9tPX List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Re: Nathan Bossart > My first reaction is that we should just remove the reltuples != 0 check. > That means vacuumdb might analyze some empty tables, but that doesn't seem > too terrible. Or some tables that aren't empty but were never analyzed when they should have been. Sounds like a good thing. Thanks! Christoph