Date: Wed, 23 Apr 2025 16:01:33 +0200
From: Christoph Berg <myon@debian.org>
To: Nathan Bossart <nathan@postgresql.org>,
	Corey Huinker <corey.huinker@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: vacuumdb --missing-stats-only and pg_upgrade from PG13
Message-ID: <aAjyvW5_fRGNr7yF@msg.df7cb.de>
References: <E1tueZC-0039rk-2P@gemulon.postgresql.org>
 <aAfxfKC82B9NvJDj@msg.df7cb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <aAfxfKC82B9NvJDj@msg.df7cb.de>
Archived-At: 
 <https://www.postgresql.org/message-id/aAjyvW5_fRGNr7yF%40msg.df7cb.de>
Precedence: bulk

Re: To Nathan Bossart
> > Update guidance for running vacuumdb after pg_upgrade.
> > 
> > Now that pg_upgrade can carry over most optimizer statistics, we
> > should recommend using vacuumdb's new --missing-stats-only option
> > to only analyze relations that are missing statistics.
> 
> I've been looking at vacuumdb --missing-stats-only because Debian's
> pg_upgradecluster is using that now.

The reason I was looking closely yesterday is because Debian's
regression tests were tripping over it, but I only figured out the
problem today:

If I create a table in a PG13-or-earlier cluster, never ANALYZE it,
and then pg_upgrade to 18 and run vacuumdb --analyze-only
--missing-stats-only, the table will not get analyzed. The only table
visited there is pg_largeobject.

Upgrades from 14..17 are fine.

Christoph