Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 9 Jul 2025 08:32:20 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix up misuse of "volatile" in contrib/xml2.
Message-ID: <aG2qhGodemZfrxcn@paquier.xyz>
References: <E1uZFQd-005Je7-1t@gemulon.postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="d8oeWdaS3p7Zgvw9"
Content-Disposition: inline
In-Reply-To: <E1uZFQd-005Je7-1t@gemulon.postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/aG2qhGodemZfrxcn%40paquier.xyz>
Precedence: bulk


--d8oeWdaS3p7Zgvw9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 08, 2025 at 09:00:39PM +0000, Tom Lane wrote:
> Fix up misuse of "volatile" in contrib/xml2.
>=20
> Also fix a number of places where variables that are assigned to
> within a PG_TRY and then used after it were not initialized or
> not marked as volatile.  (A few buildfarm members were issuing
> "may be used uninitialized" warnings about some of these variables,
> which is what drew my attention to this area.)  In most cases
> these variables were being set as the last step within the PG_TRY
> block, which might mean that we could get away without the "volatile"
> marking.  But doing that seems unsafe and is definitely not per our
> coding conventions.
>=20
> These problems seem to have come in with 732061150, so no need
> for back-patch.

Oops, thanks.  I was not aware of these reports, and the buildfarm was
not showing any red, the CI looked fine and my machine did not
complain with a rather new gcc.  What were the buildfarm members
impacted?  Did these use a switch and/or a specific compiler that
helped in detecting these problems?
--
Michael

--d8oeWdaS3p7Zgvw9
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmhtqoQACgkQnvQgOdby
QH0eqw//Rwwx7hkPMK6jrbV2ZkqpLIRyebX+JeEIjfolagZ/1w98krGJ+Ayukgo4
yusg93Uh+4xA9PLADe3Y0j9nxiBJ5zjB07Y1/CxG1wnbeq2J2uYOTNuRRHR5jtkV
rEcCqyJ0U45gmVacJL5IulqTGuF1rf/63KZpiMiCX8jfzVREd1LVCEZ645V0xrO3
A3FQIMfwZABFxzjSvRUXKiNHDzxW9Vnnl0KDNFagdbK4qllrT19+8xV5VlQKNVmg
9U+jhqnnHpQNIHPi2J4DGsaAkfBmpU3AnXCmfZ0MXGZ+kyVv+5SZ1VPYWfLMwUSB
amo76L2np/wcW1DP1wnQesB3PYbEIhMu08NBwaVCBx0Y6frVb3eTL3+tEXdC0vO4
UblHeqs39/49CpqNLp9PxueF3xdSYzQBlDij3m0I1GpllAidO3wkEAlxloOEgasC
p1C8QKbjhTBC6PY7wvEQjOLkwYw1b64KOTQ9cBm55OZbfPQZ6wOPpure5FIIAWku
+L6aZ9sWiBjLqilXN5Yx8NR1sFvUPEcDQKoZSEkf9EbT9nBOMQcdlH4lxTB5XrLs
VqkifxHCQoF0tX9n9xVDhkfdFQORpbZdtEUTHJR7mA5Fb7oyNElC2PfGerFBxsJX
kHZ7uPYyb4DlRDHi1VWdx5bPkQ7RUbKQJ1k0ydR3zjasfTwZ2Pw=
=xjnz
-----END PGP SIGNATURE-----

--d8oeWdaS3p7Zgvw9--