Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 10 Jul 2025 12:55:25 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix up misuse of "volatile" in contrib/xml2.
Message-ID: <aG85rYItyT0PGr3j@paquier.xyz>
References: <E1uZFQd-005Je7-1t@gemulon.postgresql.org>
 <aG2qhGodemZfrxcn@paquier.xyz>
 <1141878.1752076195@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="KHOH8mh7VuNscweI"
Content-Disposition: inline
In-Reply-To: <1141878.1752076195@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/aG85rYItyT0PGr3j%40paquier.xyz>
Precedence: bulk


--KHOH8mh7VuNscweI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 09, 2025 at 11:49:55AM -0400, Tom Lane wrote:
> Not sure.  Yesterday I saw such warnings from arowana,
> boa, dhole, rhinoceros, and shelduck, eg
>=20
>  arowana       | 2025-07-08 04:54:18 | xpath.c:274:6: warning: 'workspace=
' may be used uninitialized in this function [-Wmaybe-uninitialized]
>  arowana       | 2025-07-08 04:54:18 | xpath.c:319:6: warning: 'workspace=
' may be used uninitialized in this function [-Wmaybe-uninitialized]
>  arowana       | 2025-07-08 04:54:18 | xpath.c:374:6: warning: 'workspace=
' may be used uninitialized in this function [-Wmaybe-uninitialized]
>  arowana       | 2025-07-08 04:54:18 | ../../src/include/postgres.h:329:2=
: warning: 'result' may be used uninitialized in this function [-Wmaybe-uni=
nitialized]
>=20
> Didn't look to try to figure out what the common factor
> among these machines is, but I think all of them are somewhat
> dated, which is depressing.  You'd hope that newer compilers
> are more likely to find such issues, not less likely.

They are all using some gcc 4.X flavor, most with -O2 but not all.

And -Wmaybe-uninitialized is included in my default switches with a
gcc 14, and there is nothing with several levels of optimizations
applied, up to -O3.  :(
--
Michael

--KHOH8mh7VuNscweI
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmhvOa0ACgkQnvQgOdby
QH0EbBAAgWv5Z7XHxPctNMgWUz/dpL0WXjI2rh5hjs5xdCKN71MBKV7YmV5/OxX8
XOm2C1p5Z8pac+r6dCfBlzyClqftyjL126FI5lgxYHRrqvbxsdJDlqJRJ2Jmh6x4
hhCaoF0eqVZczBg1oEZ+xrTNuJgSOOfmg/WWauWgiG8PCNv1c4pxmIv3qEWAnb0z
5TW/+iYZIdaNGN6gy/lZhS85HY+wZWRYiNy1v2mUpF96qe4iaELzaJo/KfB8wSrL
8VQNr88uDA6Jk8aswmEs0xSBacroLcZIed7H9L/9f8qOC961lel2Cuhj1zkwN+Iz
B/FtqCutqSesWxfZfe1vJixMw5kfHYNzTG9flRfwE9ZuD9Hm/bN28iIH7eTEO7if
v2n1MwWWEwtuC/a82tT56ay9kkwvRZrsJf2j+LlX8g9UBW/aYGHkmjiCjnydK10G
Aob+kxcwy4rhoWNNexZGUgmf29mMaOO+upVKve4vUMfe9Y6dV13AuRcU+zfvurI7
eyCBgGnMLgihUmiLwuyfoMahaoVB1DD6cemmUCwKgQahryaNwuCqNMVumV3L4vOX
4kSRs2drKzKn2gUNJ9vqMcnAcRNr1BeoO6/P3nGxjZhnre4JrHXmfhET3641UEnE
mXVo7RHlYf9jGiChl/r1+TGwgQqf60WHr+qQxKUVqEc9z05fCTg=
=JDLW
-----END PGP SIGNATURE-----

--KHOH8mh7VuNscweI--