Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uX3Ny-0055Ro-Eb for pgsql-committers@arkaria.postgresql.org; Wed, 02 Jul 2025 19:44:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uX3Nw-005iIx-Et for pgsql-committers@arkaria.postgresql.org; Wed, 02 Jul 2025 19:44:49 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uX3Nw-005iIp-7J for pgsql-committers@lists.postgresql.org; Wed, 02 Jul 2025 19:44:48 +0000 Received: from mail-io1-xd2d.google.com ([2607:f8b0:4864:20::d2d]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1uX3Nu-005MeD-2X for pgsql-committers@lists.postgresql.org; Wed, 02 Jul 2025 19:44:48 +0000 Received: by mail-io1-xd2d.google.com with SMTP id ca18e2360f4ac-8731c3473c3so57556739f.1 for ; Wed, 02 Jul 2025 12:44:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751485485; x=1752090285; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=b7twC/QUSSYP6t+Ko/u4twJcLrBhoYq1eehOYKVgVZg=; b=ZygV9NmJfJvPqbggKgLzQhBWikJGQKu9Bs7vh1XMCkscd+mtbpX4o5wPfmR5nB/ARZ kWVOPRM2+GVtFuyMLjqKN+7V1pg6cH0S/3/FrTIhLvhakD5D8I8glRxDoowRVjyDYrqs 5f9i4x2PrCG4jQxeM0xggcXEQcgckZ3s2FtF/y5/9MlXhpecLqtdjagjtJzknRRZ5+XL Z0ZFxqNW3P0R16jeEh3iL8148uWGSXeE6szKY9Y5V4eZBMzfsHhwiMsgtReKuSAx9CkN OP7Fd58O08fOS6gxOHswBgv1rE+7Kywklv5B7RtOs5Im9Fdi9mZ+a+/IA6E6PyE7KTRe sSIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751485485; x=1752090285; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b7twC/QUSSYP6t+Ko/u4twJcLrBhoYq1eehOYKVgVZg=; b=gE/o4jk/ebPGfTz4o7iyiL9IaAQsH/I4nJcySh3kCru5/Ns9dwtY51BZW2kSCywtar 9zwQwiohYQhCs1JkH03z0Qifs+u/ypYC4P7eYkJszryyMHIw0wkTrapQV9nKP1ndunsf wGoQf0Jn2mwPPy6hTdpX+evGbpU66rZaJR+kIENS0Co/E5e6qMC5LXfMJO1BoQnCAgyU otGlcu2SFgj+WbUZJMMj/gxNCcSzcG2txwWg3BHhKLf4GWHT0durR43/XhD7jFQhSX+S N70iLPI7wDvhYGdnah2btakcSj0EkZ3tkw5p9s7sIa1lixg2iX1LyPI9hQkZQUztwMub 57ZA== X-Forwarded-Encrypted: i=1; AJvYcCUtxF4wpUy+cUHtHgJ8sJn4ATwUWCOhWAF4nsUlnjcP+U+INuxH3yYb+J2y9dxz/RyQAvwge9EMYBVwJ77IXx4K@lists.postgresql.org X-Gm-Message-State: AOJu0YwkON+Ce5f7oebEEJ9dU5BZajkzw2e3SdSkAiSogHRosH0knG/c 4fDe+4LBx2DK82VMFlh/wg0RC18tj5rpmhbdCnBX44XoJX9JVTt460zUTLmx3g== X-Gm-Gg: ASbGncvHfNsEN9IDVCSohl1k+/Numa98Rwfe/c0uG3OMSSMFQwO05cGURRxf1pflh1D CDIauQs00mdnM6/mMkHIudjJ1fyu9OxkN3cqYW4H0acOxG6ifOcpELVhGxCcAcIK8AOQ7XNWjHu u42wadf102P7Qua/LcaPjCH3blIC0VNEgsFrf2/zVqZ0PgIJIyA9HACxRpIjhfcONZvj2/WAFzS asM4VTHhwY9P7zR+hS+2qGexodVc9fNYZGP7kR8OfbjQBe+cuHvnzh7clFo+ZP5bhz+Ur3uvE4f ILrD8gqfXtjkEabaEel+eYs04m2nftGoKagiSpDH9LP8TPURE6AEIrCHoq9kbr0jKU34j+aRKWT RB2YT9YlORVOxtcPXzssDoLSU0U+uXaHr0MpT4LTFVhZkXN+twjdx X-Google-Smtp-Source: AGHT+IEGznk79Yf+gfcOiY+ayU0F8x3mcRBCFns3n4yLq6g9Fhv5jv0gULrr4Yu0Ad47B4fvOib1QA== X-Received: by 2002:a05:6602:a014:b0:86c:cf7e:d85d with SMTP id ca18e2360f4ac-876c6a96bedmr600376739f.12.1751485484864; Wed, 02 Jul 2025 12:44:44 -0700 (PDT) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-502048d64absm3105953173.60.2025.07.02.12.44.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jul 2025 12:44:44 -0700 (PDT) Date: Wed, 2 Jul 2025 14:44:42 -0500 From: Nathan Bossart To: Andrew Dunstan Cc: Nathan Bossart , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Fix cross-version upgrade test breakage from commit fe07100e82. Message-ID: References: <597c8ce0-12e5-4522-b8d7-eff378720085@dunslane.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <597c8ce0-12e5-4522-b8d7-eff378720085@dunslane.net> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Jul 02, 2025 at 03:43:02PM -0400, Andrew Dunstan wrote: > On 2025-07-02 We 2:27 PM, Nathan Bossart wrote: >> To fix, revert those renames. I could probably get away with only >> un-renaming the C symbols, but I figured I'd avoid introducing >> function name mismatches. Also, AFAICT the buildfarm's >> cross-version upgrade tests do not run the test module tests >> post-upgrade, else we'll need to properly version the extension. > > It doesn't really run any sanity checks at all other than amchecks.. It just > compares the pre- and post- upgrade dumps (with suitable modifications). > > So far that seems to have been enough. Thanks for confirming. -- nathan